unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ken Manheimer <ken.manheimer@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: move-beginning-of-line misbehaves on wrapped-line invisible text - recent cvs checkout
Date: Mon, 23 Jan 2006 15:47:28 -0500	[thread overview]
Message-ID: <2cd46e7f0601231247p76c5e25fk582a2f90c7876146@mail.gmail.com> (raw)
In-Reply-To: <2cd46e7f0601231017h65e30274x18504d460d5d8042@mail.gmail.com>

i now have a fix i'm more confident about, because (1) it takes care
of another problem i noticed, even with my previous fix, and (2) it
departs less from the checked-in version of the function, leaving less
room for betrayal of unfamiliar concerns.  here's the diff from
simple.el 1.786:

Index: simple.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/simple.el,v
retrieving revision 1.786
diff -u -u -r1.786 simple.el
--- simple.el	23 Jan 2006 04:05:59 -0000	1.786
+++ simple.el	23 Jan 2006 20:46:34 -0000
@@ -3735,11 +3735,14 @@
   (or arg (setq arg 1))
   (if (/= arg 1)
       (line-move (1- arg) t))
-
+
   ;; Move to beginning-of-line, ignoring fields and invisibles.
   (skip-chars-backward "^\n")
   (while (and (not (bobp)) (line-move-invisible-p (1- (point))))
-    (goto-char (previous-char-property-change (1- (point))))
+    (goto-char (previous-char-property-change
+                (if (line-move-invisible-p (point))
+                    (point)
+                  (1- (point)))))
     (skip-chars-backward "^\n"))

   (let ((orig (point)))
@@ -3747,7 +3750,6 @@
     (if (/= orig (point))
 	(goto-char (constrain-to-field (point) orig (/= arg 1) t nil)))))

-
 ;;; Many people have said they rarely use this feature, and often type
 ;;; it by accident.  Maybe it shouldn't even be on a key.
 (put 'set-goal-column 'disabled t)

  reply	other threads:[~2006-01-23 20:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-01-13  0:12 move-beginning-of-line misbehaves on wrapped-line invisible text - recent cvs checkout Ken Manheimer
2006-01-19 17:45 ` Richard M. Stallman
2006-01-22 16:12   ` Ken Manheimer
2006-01-23 18:17     ` Ken Manheimer
2006-01-23 20:47       ` Ken Manheimer [this message]
2006-01-26  3:28         ` Lőrentey Károly
2006-01-27  0:19           ` Ken Manheimer
2006-01-30 18:46         ` Richard M. Stallman
2006-01-31 19:10           ` Ken Manheimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2cd46e7f0601231247p76c5e25fk582a2f90c7876146@mail.gmail.com \
    --to=ken.manheimer@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).