From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Manheimer Newsgroups: gmane.emacs.devel Subject: Re: move-beginning-of-line misbehaves on wrapped-line invisible text - recent cvs checkout Date: Mon, 23 Jan 2006 15:47:28 -0500 Message-ID: <2cd46e7f0601231247p76c5e25fk582a2f90c7876146@mail.gmail.com> References: <2cd46e7f0601121612y386d057ft68324aeb352b777d@mail.gmail.com> <2cd46e7f0601220812v53945980x8d045c3df55e5f2c@mail.gmail.com> <2cd46e7f0601231017h65e30274x18504d460d5d8042@mail.gmail.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1138051244 9754 80.91.229.2 (23 Jan 2006 21:20:44 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 23 Jan 2006 21:20:44 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jan 23 22:20:42 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F196w-0008Lv-AL for ged-emacs-devel@m.gmane.org; Mon, 23 Jan 2006 22:20:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F194j-0001lr-Iz for ged-emacs-devel@m.gmane.org; Mon, 23 Jan 2006 16:18:09 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F18dl-0008S7-4B for emacs-devel@gnu.org; Mon, 23 Jan 2006 15:50:17 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F18dk-0008RU-D4 for emacs-devel@gnu.org; Mon, 23 Jan 2006 15:50:16 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F18dj-0008RJ-Uc for emacs-devel@gnu.org; Mon, 23 Jan 2006 15:50:16 -0500 Original-Received: from [66.249.92.197] (helo=uproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1F18iX-0003zb-4o for emacs-devel@gnu.org; Mon, 23 Jan 2006 15:55:13 -0500 Original-Received: by uproxy.gmail.com with SMTP id u2so64394uge for ; Mon, 23 Jan 2006 12:47:29 -0800 (PST) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=GrSu9ww6MO7wZRrT8AuYq4pNm4mXxiVl21ijJONBc6Utwo5/yvoiFtaDVIoZ6hOFLPNT1m5D4LnQd4ZPVOm9V861xbl1yRXRiw+qUCXn5bnWkRL3WAzGp2G3CwUYjRfujIG9sZ50bE3Cing9mqgy2sv3RhP3KyxF9+VE5/f5fas= Original-Received: by 10.67.26.13 with SMTP id d13mr2518381ugj; Mon, 23 Jan 2006 12:47:28 -0800 (PST) Original-Received: by 10.66.220.6 with HTTP; Mon, 23 Jan 2006 12:47:28 -0800 (PST) Original-To: rms@gnu.org In-Reply-To: <2cd46e7f0601231017h65e30274x18504d460d5d8042@mail.gmail.com> Content-Disposition: inline X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:49459 Archived-At: i now have a fix i'm more confident about, because (1) it takes care of another problem i noticed, even with my previous fix, and (2) it departs less from the checked-in version of the function, leaving less room for betrayal of unfamiliar concerns. here's the diff from simple.el 1.786: Index: simple.el =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/lisp/simple.el,v retrieving revision 1.786 diff -u -u -r1.786 simple.el --- simple.el=0923 Jan 2006 04:05:59 -0000=091.786 +++ simple.el=0923 Jan 2006 20:46:34 -0000 @@ -3735,11 +3735,14 @@ (or arg (setq arg 1)) (if (/=3D arg 1) (line-move (1- arg) t)) - + ;; Move to beginning-of-line, ignoring fields and invisibles. (skip-chars-backward "^\n") (while (and (not (bobp)) (line-move-invisible-p (1- (point)))) - (goto-char (previous-char-property-change (1- (point)))) + (goto-char (previous-char-property-change + (if (line-move-invisible-p (point)) + (point) + (1- (point))))) (skip-chars-backward "^\n")) (let ((orig (point))) @@ -3747,7 +3750,6 @@ (if (/=3D orig (point)) =09(goto-char (constrain-to-field (point) orig (/=3D arg 1) t nil))))) - ;;; Many people have said they rarely use this feature, and often type ;;; it by accident. Maybe it shouldn't even be on a key. (put 'set-goal-column 'disabled t)