unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Regression with calc-eval
@ 2013-03-25 10:25 Carsten Dominik
  2013-03-25 14:33 ` Jay Belanger
  0 siblings, 1 reply; 3+ messages in thread
From: Carsten Dominik @ 2013-03-25 10:25 UTC (permalink / raw)
  To: <emacs-devel@gnu.org> developers

Hi,

I just noticed a regression with calc-eval.

Calc-eval can no longer be called out of the blue.  Calc-eval calls calc-do-calc-eval which calls calc-check-defines.  calc-check-defines does a set-buffer to "*Calculator*", so it needs this buffer present and initialized, as if M-x calc had already been called interactively.  This did not be the case earlier, and I have not been able to see when this change occurred.

This should be fixed.  I would like to know how to work around it.  Org-mode calls calc-eval to do its table calculations.

Any suggestions on how to go about fixing this issue?

Thanks!

- Carsten


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Regression with calc-eval
  2013-03-25 10:25 Regression with calc-eval Carsten Dominik
@ 2013-03-25 14:33 ` Jay Belanger
  2013-03-25 14:51   ` Carsten Dominik
  0 siblings, 1 reply; 3+ messages in thread
From: Jay Belanger @ 2013-03-25 14:33 UTC (permalink / raw)
  To: Carsten Dominik; +Cc: jay.p.belanger, <emacs-devel@gnu.org> developers


> I just noticed a regression with calc-eval.
>
> Calc-eval can no longer be called out of the blue.  Calc-eval calls
> calc-do-calc-eval which calls calc-check-defines.  calc-check-defines
> does a set-buffer to "*Calculator*", so it needs this buffer present
> and initialized, as if M-x calc had already been called interactively.

calc-check-defines only does anything when calc-define has a property
list, which isn't always the case.  But calc-do-calc-eval also calls
calc-create-buffer, and always has.

But the *Calculator* buffer is not shown by default, so what problems
does this cause?

> This did not be the case earlier,

Are you sure?
When I get the chance I'll try it out on older versions of emacs, but do
you have a specific version where the *Calculator* buffer wasn't
created?

> This should be fixed.  I would like to know how to work around it.

I'll look at it when I get the chance.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Regression with calc-eval
  2013-03-25 14:33 ` Jay Belanger
@ 2013-03-25 14:51   ` Carsten Dominik
  0 siblings, 0 replies; 3+ messages in thread
From: Carsten Dominik @ 2013-03-25 14:51 UTC (permalink / raw)
  To: jay.p.belanger; +Cc: <emacs-devel@gnu.org> developers


On 25 mrt. 2013, at 15:33, Jay Belanger <jay.p.belanger@gmail.com> wrote:

> 
>> I just noticed a regression with calc-eval.
>> 
>> Calc-eval can no longer be called out of the blue.  Calc-eval calls
>> calc-do-calc-eval which calls calc-check-defines.  calc-check-defines
>> does a set-buffer to "*Calculator*", so it needs this buffer present
>> and initialized, as if M-x calc had already been called interactively.
> 
> calc-check-defines only does anything when calc-define has a property
> list, which isn't always the case.  But calc-do-calc-eval also calls
> calc-create-buffer, and always has.

Ahh, you brought me on the right track, thank you.  I caused
the problem myself by restructuring my init file and by
loading the .calc file explicitly, by mistake.  This
adds properties to calc-define and causes the problems in the wake.

No loading .calc explicitly fixes the issue - sorry for the noise.

- Carsten



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-03-25 14:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-25 10:25 Regression with calc-eval Carsten Dominik
2013-03-25 14:33 ` Jay Belanger
2013-03-25 14:51   ` Carsten Dominik

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).