emacs face widget

emacs face widget

[mr mike]

Hello all,

is the face widget code in src/widget.c, widget.h, widgetprv.h used, or
is it just bitrotted code?

mike

Re: emacs face widget

[Eli Zaretskii]

> From: mr mike <mwingert7149@wowway.com>
> Date: Sat, 03 Jan 2004 21:33:03 -0500
> 
> is the face widget code in src/widget.c, widget.h, widgetprv.h used, or
> is it just bitrotted code?

It looks like it's used: you will see that xterm.c and frame.c use
(for the toolkit build) the two external functions defined by
widget.c.

Why did you ask?

Re: emacs face widget

[mr mike]

Eli,

I'm asking because there is a lot of code like this:

#if 0

...some code...

#endif

thanks.

mike


On Sun, 2004-01-04 at 01:28, Eli Zaretskii wrote:
> > From: mr mike <mwingert7149@wowway.com>
> > Date: Sat, 03 Jan 2004 21:33:03 -0500
> > 
> > is the face widget code in src/widget.c, widget.h, widgetprv.h used, or
> > is it just bitrotted code?
> 
> It looks like it's used: you will see that xterm.c and frame.c use
> (for the toolkit build) the two external functions defined by
> widget.c.
> 
> Why did you ask?
> 
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://mail.gnu.org/mailman/listinfo/emacs-devel
> 

Re: emacs face widget

[Richard Stallman]

    is the face widget code in src/widget.c, widget.h, widgetprv.h used, or
    is it just bitrotted code?

The comment "face widget" is misleading.  I think this widget
is used when Emacs runs on Xt, to hold the actual contents
of the Emacs frame.

Re: emacs face widget

[Richard Stallman]

    I'm asking because there is a lot of code like this:

    #if 0

    ...some code...

    #endif

I never entirely understood Xt, so I got that file to work
by essentially trial and error.  I probably left the code
that I replaced inside #if 0.

It would be nice if someone who really understood Xt were
to rewrite this file and make it work cleanly.  I would expect
it could be much cleaner than it is.

Re: emacs face widget

[Jan D.]

>     I'm asking because there is a lot of code like this:
>
>     #if 0
>
>     ...some code...
>
>     #endif
>
> I never entirely understood Xt, so I got that file to work
> by essentially trial and error.  I probably left the code
> that I replaced inside #if 0.
>
> It would be nice if someone who really understood Xt were
> to rewrite this file and make it work cleanly.  I would expect
> it could be much cleaner than it is.

I'll have a look.  But are we supporting Emacs as an external widget,
that is can be compiled into other applications like any other Xt
widget, or is it just for Emacs internally?  I don't think Emacs as
an external widget works now.

	Jan D.

Re: emacs face widget

[Richard Stallman]

    I'll have a look.  But are we supporting Emacs as an external widget,
    that is can be compiled into other applications like any other Xt
    widget, or is it just for Emacs internally?

I don't know whether it tries to be an external widget.
I believe Emacs needs this merely to work with Xt at all.

Re: emacs face widget

[Jan D.]

>     I'll have a look.  But are we supporting Emacs as an external 
> widget,
>     that is can be compiled into other applications like any other Xt
>     widget, or is it just for Emacs internally?
>
> I don't know whether it tries to be an external widget.

After inspection, it does not look like it is possible to use it like 
that.

> I believe Emacs needs this merely to work with Xt at all.

Yes and no.  For Lesstif/Motif/Athena there are DrawingArea type widgets
one can use, but for Lucid it is needed.  One idea I am contemplating
is to make a drawing area widget for Lucid in lwlib, and then we can
mostly discard the stuff in widget.c and instead use the drawing area
as just any X window (like the GTK port does).  This should reduce
the amount of code a bit.  There may be issues with toolbar and/or
menubar, I haven't looked at that yet.

	Jan D.