unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "T.V Raman" <raman@google.com>
To: dgutov@yandex.ru
Cc: raman@google.com, emacs-devel@gnu.org
Subject: Re: master@head: completing-read behavior change?
Date: Thu, 23 Jan 2020 08:45:53 -0800	[thread overview]
Message-ID: <24105.52673.69083.360821@retriever.mtv.corp.google.com> (raw)
In-Reply-To: <c5cd49ed-e3fa-d2cb-d14e-f18cd4df0e89@yandex.ru>

I just checked, emacspeak doesn't have explicit code for
icomplete. That said, I'll implement the more general approach you
suggest at some point -- likely by creating an Emacspeak-specific
minibuffer-contents equivalent. Is there some generic test I can use
to spot the new pattern vs old?
Dmitry Gutov writes:
 > Hi T.V.,
 > 
 > On 23.01.2020 3:03, T.V Raman wrote:
 > > Fix is here for the curious:-)
 > > https://github.com/tvraman/emacspeak/blob/master/lisp/emacspeak-ido.el#L85
 > 
 > You haven't answered my question about support for icomplete-mode. Do 
 > you only support Ido?
 > 
 > I'm happy you made it work, but I think it would be better to handle the 
 > general approach. Meaning, instead of hardcoding the names of (private) 
 > variables, scan the minibuffer, look for the overlays with after-string, 
 > order by 'priority', and read their contents one after another.
 > 
 > The new set-minibuffer-message feature uses the same approach if 
 > minibuffer is active. Although, in that case, you could advise this 
 > function, or set an alternative handler via the set-message-function 
 > variable (also just added in Emacs 27).

-- 
Id: kg:/m/0285kf1 

-- 
Id: kg:/m/0285kf1 



  parent reply	other threads:[~2020-01-23 16:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 21:42 master@head: completing-read behavior change? T.V Raman
2020-01-22 21:56 ` Dmitry Gutov
2020-01-22 23:53   ` T.V Raman
2020-01-23  0:01     ` T.V Raman
2020-01-23  0:03       ` T.V Raman
2020-01-23 13:58         ` Dmitry Gutov
2020-01-23 14:44           ` T.V Raman
2020-01-23 14:49             ` Dmitry Gutov
2020-01-23 16:45           ` T.V Raman [this message]
2020-01-23 17:19             ` Dmitry Gutov
2020-01-22 23:55   ` T.V Raman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24105.52673.69083.360821@retriever.mtv.corp.google.com \
    --to=raman@google.com \
    --cc=dgutov@yandex.ru \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).