From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "T.V Raman" Newsgroups: gmane.emacs.devel Subject: Re: master@head: completing-read behavior change? Date: Thu, 23 Jan 2020 08:45:53 -0800 Message-ID: <24105.52673.69083.360821@retriever.mtv.corp.google.com> References: <24104.57455.730537.220936@retriever.mtv.corp.google.com> <24104.57963.869782.597096@retriever.mtv.corp.google.com> <24104.58069.333584.189273@retriever.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="96713"; mail-complaints-to="usenet@ciao.gmane.io" Cc: raman@google.com, emacs-devel@gnu.org To: dgutov@yandex.ru Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 23 18:44:37 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iugWz-000P7g-GY for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Jan 2020 18:44:37 +0100 Original-Received: from localhost ([::1]:33868 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iugWx-00066p-Rj for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Jan 2020 12:44:35 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40580) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iufcD-00031w-T0 for emacs-devel@gnu.org; Thu, 23 Jan 2020 11:46:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iufcC-0005bj-Nr for emacs-devel@gnu.org; Thu, 23 Jan 2020 11:45:57 -0500 Original-Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]:41629) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iufcC-0005bT-FZ for emacs-devel@gnu.org; Thu, 23 Jan 2020 11:45:56 -0500 Original-Received: by mail-pl1-x632.google.com with SMTP id t14so1575704plr.8 for ; Thu, 23 Jan 2020 08:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=from:mime-version:content-transfer-encoding:message-id:date:to:cc :subject:in-reply-to:references; bh=U7cRwMAcTEexUIh1fgLUQftrnH0ES+8xKXS7abcgaiE=; b=X/Oy+vswJXXiOWfVB3+xi5q8aOgTzxW1MWYf1P9kgrZC4QfjdKqBDPpDqLZAo3ixEQ 0Ft7xIAfdLXRVNWfwI9o6r8MUVUVzETY3AcoGD2MS5SWFJu+Uupb1JCjKzDKjfBXfbd7 8t5xA27oW5KzJyL2oT+v9hAkSeg3ZFthfaJJuLw8vhZpFQWIBBBb8iQMigJO6RO2kAUs bBys+jjOcmVnAdAGtu2ZRLo2tGnh3ap0SSNcLr2YOZ5X4EvDxb44bcwWRiMJlcZKJaiQ X/MvTbJ3A57KAPLq5TPuX+06SQK22F9SmBJx+c6kFQyPuo6eoeKK3e3bhsHqFMRLLNBz tfeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:content-transfer-encoding :message-id:date:to:cc:subject:in-reply-to:references; bh=U7cRwMAcTEexUIh1fgLUQftrnH0ES+8xKXS7abcgaiE=; b=ASNokCFXSaWcsuxSxdoLOJxnLc6QUDOS6YPHoLNt93HnA94fTfESXErtMMXEF+GMVM bSXs7/K0257SPDPHkYkoOjgFatOUbBU9PYn46f/GmJqp54YQlnoDXW0tWltBh0HKzEqk raAHSRVaQbx+LvArSYSGqgOpi7INTV0jhpZDcOKDiDYBOTsJy/Nr+KnpFDHu/NT0RO1U vEE6k4QbBzXqmCr4FZXogvUcRt4xinusj/+cDV1ZGpNwCvoTTX/8zjHRzDRC9DaH22EZ Rzn+zMEYGQtW7Ja5YdnLhRAYxBIXrKws8HhaW4E3yxtpdqXC1K+FAvUcg96f9r3L+KGs TIaA== X-Gm-Message-State: APjAAAXO+M3m5k4UiWVIpafYvRqn7FKZWshR2ivyF4vsAIk+IN6AZpdt N8Oeucubqk/MQ6EmQc+R4biGfm1X7dasRQ== X-Google-Smtp-Source: APXvYqxnOYGUG/f0N3jxxQWHXvSqCiBkLI/Onf71YmKuHINW36g/NZoYHFwiG6nKe5q5NTY91mGQQg== X-Received: by 2002:a17:90a:9b18:: with SMTP id f24mr5548160pjp.77.1579797954781; Thu, 23 Jan 2020 08:45:54 -0800 (PST) Original-Received: from retriever.mtv.corp.google.com ([2620:0:1000:1510:1031:34f3:35d5:596f]) by smtp.gmail.com with ESMTPSA id q15sm3569189pgi.55.2020.01.23.08.45.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jan 2020 08:45:53 -0800 (PST) Original-Received: by retriever.mtv.corp.google.com (Postfix, from userid 13930) id 1AD13180039C; Thu, 23 Jan 2020 08:45:53 -0800 (PST) In-Reply-To: X-Mailer: VM 8.1.1 under 28.0.50 (x86_64-pc-linux-gnu) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::632 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244541 Archived-At: I just checked, emacspeak doesn't have explicit code for icomplete. That said, I'll implement the more general approach you suggest at some point -- likely by creating an Emacspeak-specific minibuffer-contents equivalent. Is there some generic test I can use to spot the new pattern vs old? Dmitry Gutov writes: > Hi T.V., > > On 23.01.2020 3:03, T.V Raman wrote: > > Fix is here for the curious:-) > > https://github.com/tvraman/emacspeak/blob/master/lisp/emacspeak-ido.el#L85 > > You haven't answered my question about support for icomplete-mode. Do > you only support Ido? > > I'm happy you made it work, but I think it would be better to handle the > general approach. Meaning, instead of hardcoding the names of (private) > variables, scan the minibuffer, look for the overlays with after-string, > order by 'priority', and read their contents one after another. > > The new set-minibuffer-message feature uses the same approach if > minibuffer is active. Although, in that case, you could advise this > function, or set an alternative handler via the set-message-function > variable (also just added in Emacs 27). -- Id: kg:/m/0285kf1 -- Id: kg:/m/0285kf1