* make check failing since 15693c81163e70b5df786e7c034bd236a40794bb
@ 2021-12-22 10:33 john muhl
2021-12-22 11:09 ` Robert Pluim
0 siblings, 1 reply; 6+ messages in thread
From: john muhl @ 2021-12-22 10:33 UTC (permalink / raw)
To: emacs-devel
a fresh checkout or `git clean -dx` might be needed for reproduction.
fails on latest stable Debian and Fedora.
15693c8: https://builds.sr.ht/~johnmuhl/job/654631#bottom
f6967d2: https://builds.sr.ht/~johnmuhl/job/654649#bottom
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: make check failing since 15693c81163e70b5df786e7c034bd236a40794bb
2021-12-22 10:33 make check failing since 15693c81163e70b5df786e7c034bd236a40794bb john muhl
@ 2021-12-22 11:09 ` Robert Pluim
2021-12-22 15:23 ` Stefan Kangas
2021-12-22 18:20 ` john muhl
0 siblings, 2 replies; 6+ messages in thread
From: Robert Pluim @ 2021-12-22 11:09 UTC (permalink / raw)
To: john muhl; +Cc: emacs-devel
>>>>> On Wed, 22 Dec 2021 04:33:16 -0600, john muhl <email@johnmuhl.mx> said:
john> a fresh checkout or `git clean -dx` might be needed for reproduction.
john> fails on latest stable Debian and Fedora.
john> 15693c8: https://builds.sr.ht/~johnmuhl/job/654631#bottom
john> f6967d2: https://builds.sr.ht/~johnmuhl/job/654649#bottom
This is due to adding a binding in the minibuffer map, and not
updating help-tests-substitute-command-keys/keymaps
commit 15693c81163e70b5df786e7c034bd236a40794bb
Author: Philip Kaludercic <philipk@posteo.net>
Date: Thu Dec 9 17:26:14 2021 +0100
(does sr.ht run a build on every commit?)
Robert
--
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: make check failing since 15693c81163e70b5df786e7c034bd236a40794bb
2021-12-22 11:09 ` Robert Pluim
@ 2021-12-22 15:23 ` Stefan Kangas
2021-12-22 15:26 ` Lars Ingebrigtsen
2021-12-22 18:20 ` john muhl
1 sibling, 1 reply; 6+ messages in thread
From: Stefan Kangas @ 2021-12-22 15:23 UTC (permalink / raw)
To: Robert Pluim, john muhl; +Cc: emacs-devel
Robert Pluim <rpluim@gmail.com> writes:
> This is due to adding a binding in the minibuffer map, and not
> updating help-tests-substitute-command-keys/keymaps
We should probably make these tests less brittle.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: make check failing since 15693c81163e70b5df786e7c034bd236a40794bb
2021-12-22 15:23 ` Stefan Kangas
@ 2021-12-22 15:26 ` Lars Ingebrigtsen
2021-12-22 22:11 ` Stefan Kangas
0 siblings, 1 reply; 6+ messages in thread
From: Lars Ingebrigtsen @ 2021-12-22 15:26 UTC (permalink / raw)
To: Stefan Kangas; +Cc: Robert Pluim, emacs-devel, john muhl
Stefan Kangas <stefankangas@gmail.com> writes:
> Robert Pluim <rpluim@gmail.com> writes:
>
>> This is due to adding a binding in the minibuffer map, and not
>> updating help-tests-substitute-command-keys/keymaps
>
> We should probably make these tests less brittle.
Yup. Testing for the entire keymap (of keymaps that change, like the
minibuffer map) is too much work. It'd be better if the tests just
defined their own maps.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: make check failing since 15693c81163e70b5df786e7c034bd236a40794bb
2021-12-22 11:09 ` Robert Pluim
2021-12-22 15:23 ` Stefan Kangas
@ 2021-12-22 18:20 ` john muhl
1 sibling, 0 replies; 6+ messages in thread
From: john muhl @ 2021-12-22 18:20 UTC (permalink / raw)
To: Robert Pluim; +Cc: emacs-devel
On Wed, 2021-12-22 at 12:09 +0100, Robert Pluim wrote:
> commit 15693c81163e70b5df786e7c034bd236a40794bb
> Author: Philip Kaludercic <philipk@posteo.net>
> Date: Thu Dec 9 17:26:14 2021 +0100
>
> (does sr.ht run a build on every commit?)
no these are ad-hoc builds. of course it can run on each commit. i'm
working on setting that up but it might be a few days so if anyone
else wanted to have a go at it that would be fine.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: make check failing since 15693c81163e70b5df786e7c034bd236a40794bb
2021-12-22 15:26 ` Lars Ingebrigtsen
@ 2021-12-22 22:11 ` Stefan Kangas
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Kangas @ 2021-12-22 22:11 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: Robert Pluim, emacs-devel, john muhl
Lars Ingebrigtsen <larsi@gnus.org> writes:
> Yup. Testing for the entire keymap (of keymaps that change, like the
> minibuffer map) is too much work. It'd be better if the tests just
> defined their own maps.
Now fixed on master (commit 205030ba5a).
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-12-22 22:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-22 10:33 make check failing since 15693c81163e70b5df786e7c034bd236a40794bb john muhl
2021-12-22 11:09 ` Robert Pluim
2021-12-22 15:23 ` Stefan Kangas
2021-12-22 15:26 ` Lars Ingebrigtsen
2021-12-22 22:11 ` Stefan Kangas
2021-12-22 18:20 ` john muhl
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).