unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Yuan Fu <casouri@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Tim Cross <theophilusx@gmail.com>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Add some built-in faces for inheritance
Date: Sat, 19 Sep 2020 16:00:38 -0400	[thread overview]
Message-ID: <213CCC9C-B9CB-453B-A9C9-A5D0FB4FDE4F@gmail.com> (raw)
In-Reply-To: <jwvbli1a6w5.fsf-monnier+emacs@gnu.org>



> On Sep 19, 2020, at 3:50 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> 
>> - foreground-highlight: highlight text using a different foreground color,
>> used for matched results, etc.
> 
> Please don't rely too much on things like "color" in your descriptions.
> Think more of what is the intended use rather than the visual effect you
> expect for it.

Indeed.

> [ I for one likely wouldn't change the foreground color of "matched
>  results".  ]
> 
> What kind of "matched results" are you thinking of?
> The text matched during isearch?
> 
>> - background-highlight: highlighted text using a different background color,
>> used for selected candidate in company/ivy/helm, etc.
> 
> I think this one could be an alias for the current `highlight`, right?
> 
> 
>        Stefan
> 

Maybe I should use “match-highlight”, and “selected-candidate”, respectively. The problem is that “highlight” is a bit too board, there are many different types of highlight: highlight of matched text during isearch, lazy-highlight for isearch, highlight for current selection in company/ivy/helm, etc, etc. We probably should make the definition more specific, so people know which one to inherit from.

Yuan


  reply	other threads:[~2020-09-19 20:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-17 16:43 light, dark, and theme adjustment & generation [was: solarized] Drew Adams
2020-09-17 23:21 ` Tim Cross
2020-09-19 19:36   ` Add some built-in faces for inheritance Yuan Fu
2020-09-19 19:50     ` Stefan Monnier
2020-09-19 20:00       ` Yuan Fu [this message]
2020-09-19 23:51         ` chad
2020-09-20 13:21           ` Howard Melman
2020-09-20 19:18     ` Juri Linkov
2020-09-21  7:48       ` Protesilaos Stavrou
2020-09-21 19:14         ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=213CCC9C-B9CB-453B-A9C9-A5D0FB4FDE4F@gmail.com \
    --to=casouri@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=theophilusx@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).