From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.devel Subject: Re: Add some built-in faces for inheritance Date: Sat, 19 Sep 2020 16:00:38 -0400 Message-ID: <213CCC9C-B9CB-453B-A9C9-A5D0FB4FDE4F@gmail.com> References: <5a3685f0-a1dd-44f9-9e15-e8f1bc35ea57@default> <87h7rw7zxf.fsf@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28761"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Tim Cross , emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 19 22:03:06 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJj4a-0007OA-V9 for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Sep 2020 22:03:04 +0200 Original-Received: from localhost ([::1]:48442 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJj4a-0006h6-1C for ged-emacs-devel@m.gmane-mx.org; Sat, 19 Sep 2020 16:03:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36006) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kJj2K-0005dW-TE for emacs-devel@gnu.org; Sat, 19 Sep 2020 16:00:48 -0400 Original-Received: from mail-qk1-x72a.google.com ([2607:f8b0:4864:20::72a]:41051) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kJj2J-0001ZU-2U for emacs-devel@gnu.org; Sat, 19 Sep 2020 16:00:44 -0400 Original-Received: by mail-qk1-x72a.google.com with SMTP id g72so10592103qke.8 for ; Sat, 19 Sep 2020 13:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=+obf0dVZvVjMojR8rToxMA/baIZ2CTlFof7BjDd27tw=; b=iXD5Guw2ZJRdNQjOwqQLmTaeQHFnTxTk+Xt7cfTfYLmafGeqZUJJ3SL3LZZ+LzSGR3 6CpkAhjPGkyXkCf3TNB9dvvtHU6IVnwwO1mDZXybo8UcQBHjvI4W7AjjjB11YQ7oU+6l wiQpEkOWqj3x16s6AM3eHCdZ5Uov0/Go73XswHhFpfSE67m47DRvi7x51ex8w6/P4mGd zG6sPAg+xEMGfZVBEmHRuTxq0pPxD+sNpcuNH84quHGeduwu069eHCIAjrqcP35ARX7y VpibsZjR4u3AmMGSimhmdDTUKg3rZtYqvHhYChVq5PiBkW33QkvwJMBsdTfCBxiX9u1c UP5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=+obf0dVZvVjMojR8rToxMA/baIZ2CTlFof7BjDd27tw=; b=fjieuavY0Ux0i8LtD4BAbbfhVTcLZr0RGlr8W/+m3ccWlThjDYyq5ypQbjCONSuUTY GOJM5A2LaJJ/VxoNVPIGiyYAQMF7Lv4sV9ERFezkGOiSR0LpUkus1JQ9hY7mVvQcc/KD jHujfUQIeNSG/whm7Ebe5R52kwMGzAqfTwJciSUycgShzfmRAx0QM9wn9RxrtjkGkwQC qZ4eKOA/KJiGewByv3G7UDuucJyURPthqxX46t1NJ1rLNiDibb64sB49XJC6iuMzTU3k heyhJZLn7vzAKhTkGXaIfWw4G+kPibkMRgViHrwIb+dPlWaM6fDBI3djidkGB0L+RRPO mk8w== X-Gm-Message-State: AOAM531iXCBxX1P7h1aZJkoXhHphD5VFryyf0gwwdqmGohSgL4a89V2h juZxETmF9dZILapt9bqMSyU= X-Google-Smtp-Source: ABdhPJwUdspRqzTcPyDaXaor/zYQNN/0turJtUUJHKKAfBtVBmXNfS76qC/R77owzDwbG5qW82cLQg== X-Received: by 2002:ae9:ed86:: with SMTP id c128mr37366793qkg.289.1600545640180; Sat, 19 Sep 2020 13:00:40 -0700 (PDT) Original-Received: from ?IPv6:2601:98a:4200:9210:d9f6:8d22:812e:482b? ([2601:98a:4200:9210:d9f6:8d22:812e:482b]) by smtp.gmail.com with ESMTPSA id n136sm4847104qkn.14.2020.09.19.13.00.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 19 Sep 2020 13:00:39 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.3608.120.23.2.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::72a; envelope-from=casouri@gmail.com; helo=mail-qk1-x72a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256215 Archived-At: > On Sep 19, 2020, at 3:50 PM, Stefan Monnier = wrote: >=20 >> - foreground-highlight: highlight text using a different foreground = color, >> used for matched results, etc. >=20 > Please don't rely too much on things like "color" in your = descriptions. > Think more of what is the intended use rather than the visual effect = you > expect for it. Indeed. > [ I for one likely wouldn't change the foreground color of "matched > results". ] >=20 > What kind of "matched results" are you thinking of? > The text matched during isearch? >=20 >> - background-highlight: highlighted text using a different background = color, >> used for selected candidate in company/ivy/helm, etc. >=20 > I think this one could be an alias for the current `highlight`, right? >=20 >=20 > Stefan >=20 Maybe I should use =E2=80=9Cmatch-highlight=E2=80=9D, and = =E2=80=9Cselected-candidate=E2=80=9D, respectively. The problem is that = =E2=80=9Chighlight=E2=80=9D is a bit too board, there are many different = types of highlight: highlight of matched text during isearch, = lazy-highlight for isearch, highlight for current selection in = company/ivy/helm, etc, etc. We probably should make the definition more = specific, so people know which one to inherit from. Yuan=