From: Yuuki Harano <masm+emacs@masm11.me>
To: makovick@gmail.com
Cc: rudalics@gmx.at, emacs-devel@gnu.org
Subject: Re: [PATCH] src/pgtkfns.c: Do not show an empty frame prematurely
Date: Mon, 14 Jun 2021 20:56:32 +0900 (JST) [thread overview]
Message-ID: <20210614.205632.1183483673307728728.masm@luna.pink.masm11.me> (raw)
In-Reply-To: <20210614083951.78e39723@holly>
On Mon, 14 Jun 2021 08:39:51 +0200,
Jindřich Makovička <makovick@gmail.com> wrote:
>> Applied, thanks.
>>
>
> I see the patch being reverted immediately - did it break anything?
I'm sorry, I should have told you what was broken.
emacs -Q --eval "(scroll-bar-mode -1)" --eval "(menu-bar-mode -1)" --eval "(tool-bar-mode -1)" --eval "(make-frame-command)"
This command created an empty frame.
It is reported here:
https://github.com/masm11/emacs/issues/105
I debugged a bit but I couldn't solve it, so I reverted the patch.
I'm going to debug with the patch.
On Mon, 14 Jun 2021 10:29:41 +0200,
martin rudalics <rudalics@gmx.at> wrote:
>> I see the patch being reverted immediately - did it break anything?
>
> And if it broke anything, please explain somewhere in the code what it
> broke. This should avoid that people apply this or a similar patch in
> the future.
OK, I'll explain the reason in the commit message of the revert commit
next time.
--
Yuuki Harano
next prev parent reply other threads:[~2021-06-14 11:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-29 18:58 [PATCH] src/pgtkfns.c: Do not show an empty frame prematurely Jindřich Makovička
2021-06-08 15:54 ` Yuuki Harano
2021-06-12 13:13 ` Jindřich Makovička
2021-06-13 9:40 ` Yuuki Harano
2021-06-14 6:39 ` Jindřich Makovička
2021-06-14 8:29 ` martin rudalics
2021-06-14 11:56 ` Yuuki Harano [this message]
2021-06-18 14:32 ` Yuuki Harano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210614.205632.1183483673307728728.masm@luna.pink.masm11.me \
--to=masm+emacs@masm11.me \
--cc=emacs-devel@gnu.org \
--cc=makovick@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).