From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuuki Harano Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] src/pgtkfns.c: Do not show an empty frame prematurely Date: Mon, 14 Jun 2021 20:56:32 +0900 (JST) Organization: Ingage Inc. Message-ID: <20210614.205632.1183483673307728728.masm@luna.pink.masm11.me> References: <20210612151316.23521960@holly> <20210613.184004.1128996643936687998.masm@luna.pink.masm11.me> <20210614083951.78e39723@holly> Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-2 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10201"; mail-complaints-to="usenet@ciao.gmane.io" Cc: rudalics@gmx.at, emacs-devel@gnu.org To: makovick@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 14 13:57:23 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lslDV-0002Tn-VM for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Jun 2021 13:57:22 +0200 Original-Received: from localhost ([::1]:39706 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lslDU-0000vf-5c for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Jun 2021 07:57:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lslCw-0000E2-HZ for emacs-devel@gnu.org; Mon, 14 Jun 2021 07:56:46 -0400 Original-Received: from shiro.masm11.me ([150.95.182.25]:52110) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lslCt-0004SG-84 for emacs-devel@gnu.org; Mon, 14 Jun 2021 07:56:46 -0400 Original-Received: from luna.pink.masm11.me (KD111239252145.au-net.ne.jp [111.239.252.145]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shiro.masm11.me (Postfix) with ESMTPSA id 2111FC00C6; Mon, 14 Jun 2021 20:56:34 +0900 (JST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=masm11.me; s=202002; t=1623671794; bh=MRmYgWmrRO/Q3xFF+w5huM9Qs+pt4waxlu8T/76F+Xs=; h=Date:To:Cc:Subject:From:In-Reply-To:References; b=DZDSi1F+3h5kLoXCch2lFBMCtNQ8cRxCwoIbeaGlV7pCwOnZpVdBsQbqHDZ9D9VU0 S4irso8LxsYOb4n7Y5KNLdsF0XET9lKeqT/gidHXHZ69l2cwvLsOBiNAo8rAvKvZD1 bZIsG64QAbksvwq3h9T5b6kGMWAol9vEezhA7FyE= In-Reply-To: <20210614083951.78e39723@holly> X-Mailer: Mew version 6.8 on Emacs 28.0 Received-SPF: pass client-ip=150.95.182.25; envelope-from=masm@masm11.me; helo=shiro.masm11.me X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270809 Archived-At: On Mon, 14 Jun 2021 08:39:51 +0200, Jind=F8ich Makovi=E8ka wrote: >> Applied, thanks. >> = > = > I see the patch being reverted immediately - did it break anything? I'm sorry, I should have told you what was broken. emacs -Q --eval "(scroll-bar-mode -1)" --eval "(menu-bar-mode -1)" --ev= al "(tool-bar-mode -1)" --eval "(make-frame-command)" This command created an empty frame. It is reported here: https://github.com/masm11/emacs/issues/105 I debugged a bit but I couldn't solve it, so I reverted the patch. I'm going to debug with the patch. On Mon, 14 Jun 2021 10:29:41 +0200, martin rudalics wrote: >> I see the patch being reverted immediately - did it break anything? > = > And if it broke anything, please explain somewhere in the code what i= t > broke. This should avoid that people apply this or a similar patch i= n > the future. OK, I'll explain the reason in the commit message of the revert commit next time. -- = Yuuki Harano