* GNUstep display problem
@ 2019-09-22 16:04 Alan Third
2019-09-23 8:30 ` martin rudalics
0 siblings, 1 reply; 3+ messages in thread
From: Alan Third @ 2019-09-22 16:04 UTC (permalink / raw)
To: emacs-devel; +Cc: Alexander Gramiak
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
Hi, there’s a problem with how GNUstep builds are displaying text.
It’s not displaying all the characters, and is mostly just displaying
characters that come after a space. I traced it to this commit:
a4fe9c70af7a60117480d3361541550341da801a
Replace XChar2b with unsigned in all font backends
however I can’t see what in that commit is affecting GNUstep
specifically. I can’t replicate it on macOS and I tried undoing the
changes in nsfont.m and nsgui.h, but it made no difference.
--
Alan Third
[-- Attachment #2: gnustep.png --]
[-- Type: image/png, Size: 31421 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: GNUstep display problem
2019-09-22 16:04 GNUstep display problem Alan Third
@ 2019-09-23 8:30 ` martin rudalics
2019-09-23 18:30 ` Alan Third
0 siblings, 1 reply; 3+ messages in thread
From: martin rudalics @ 2019-09-23 8:30 UTC (permalink / raw)
To: Alan Third, emacs-devel; +Cc: Alexander Gramiak
> Hi, there’s a problem with how GNUstep builds are displaying text.
> It’s not displaying all the characters, and is mostly just displaying
> characters that come after a space. I traced it to this commit:
>
> a4fe9c70af7a60117480d3361541550341da801a
> Replace XChar2b with unsigned in all font backends
>
> however I can’t see what in that commit is affecting GNUstep
> specifically. I can’t replicate it on macOS and I tried undoing the
> changes in nsfont.m and nsgui.h, but it made no difference.
When in nsfont.m I replace
unsigned short *t = s->char2b;
with
unsigned *t = s->char2b;
it seems to work normally.
martin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: GNUstep display problem
2019-09-23 8:30 ` martin rudalics
@ 2019-09-23 18:30 ` Alan Third
0 siblings, 0 replies; 3+ messages in thread
From: Alan Third @ 2019-09-23 18:30 UTC (permalink / raw)
To: martin rudalics; +Cc: Alexander Gramiak, emacs-devel
On Mon, Sep 23, 2019 at 10:30:31AM +0200, martin rudalics wrote:
> > Hi, there’s a problem with how GNUstep builds are displaying text.
> > It’s not displaying all the characters, and is mostly just displaying
> > characters that come after a space. I traced it to this commit:
> >
> > a4fe9c70af7a60117480d3361541550341da801a
> > Replace XChar2b with unsigned in all font backends
> >
> > however I can’t see what in that commit is affecting GNUstep
> > specifically. I can’t replicate it on macOS and I tried undoing the
> > changes in nsfont.m and nsgui.h, but it made no difference.
>
> When in nsfont.m I replace
>
> unsigned short *t = s->char2b;
>
> with
>
> unsigned *t = s->char2b;
>
> it seems to work normally.
It looks like that’s the fix. I don’t see anything else that needs
changed, so I’ve pushed the change.
Thanks!
--
Alan Third
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-23 18:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-22 16:04 GNUstep display problem Alan Third
2019-09-23 8:30 ` martin rudalics
2019-09-23 18:30 ` Alan Third
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).