Re: Releasing Emacs 26.1

[Alan Third <alan@idiocy.org>]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

On Sun, May 06, 2018 at 10:52:15PM +0300, Eli Zaretskii wrote:
> Any objections to releasing Emacs 26.1 in a week's time, anyone?

None from me as long as I can apply the attached patch for a crash bug
I just discovered this evening.
-- 
Alan Third

[-- Attachment #2: 0001-Check-NSWindow-is-actually-a-frame.patch --]
[-- Type: text/plain, Size: 1047 bytes --]

From e9368809ed26240d3c23d2c9d8946a896a7acfa0 Mon Sep 17 00:00:00 2001
From: Alan Third <alan@idiocy.org>
Date: Sun, 6 May 2018 21:49:31 +0100
Subject: [PATCH] Check NSWindow is actually a frame

* src/nsfns.m (Fns_frame_list_z_order): Check NSWindow is an instance
of EmacsView before treating it as one.
---
 src/nsfns.m | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/nsfns.m b/src/nsfns.m
index 7f2f060dda..34a7e38c76 100644
--- a/src/nsfns.m
+++ b/src/nsfns.m
@@ -1497,7 +1497,8 @@ Frames are listed from topmost (first) to bottommost (last).  */)
       Lisp_Object frame;
 
       /* Check against [win parentWindow] so that it doesn't match itself. */
-      if (parent == nil || ns_window_is_ancestor (parent, [win parentWindow]))
+      if ([[win delegate] isKindOfClass:[EmacsView class]]
+          && parent == nil || ns_window_is_ancestor (parent, [win parentWindow]))
         {
           XSETFRAME (frame, ((EmacsView *)[win delegate])->emacsframe);
           frames = Fcons(frame, frames);
-- 
2.16.1