From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Alan Third Newsgroups: gmane.emacs.devel Subject: Re: Releasing Emacs 26.1 Date: Sun, 6 May 2018 22:00:13 +0100 Message-ID: <20180506210013.GA5047@breton.holly.idiocy.org> References: <83o9hsr28g.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="MGYHOYXEY6WxJCY8" X-Trace: blaine.gmane.org 1525640309 31582 195.159.176.226 (6 May 2018 20:58:29 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 6 May 2018 20:58:29 +0000 (UTC) User-Agent: Mutt/1.9.3 (2018-01-21) Cc: John Wiegley , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 06 22:58:25 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fFQjg-00085N-Mw for ged-emacs-devel@m.gmane.org; Sun, 06 May 2018 22:58:24 +0200 Original-Received: from localhost ([::1]:43278 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFQll-0002nv-TT for ged-emacs-devel@m.gmane.org; Sun, 06 May 2018 17:00:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56358) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fFQla-0002nm-3Z for emacs-devel@gnu.org; Sun, 06 May 2018 17:00:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fFQlZ-0005y9-9Z for emacs-devel@gnu.org; Sun, 06 May 2018 17:00:22 -0400 Original-Received: from mail-wr0-x235.google.com ([2a00:1450:400c:c0c::235]:35050) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fFQlW-0005th-Fw; Sun, 06 May 2018 17:00:18 -0400 Original-Received: by mail-wr0-x235.google.com with SMTP id i14-v6so22911433wre.2; Sun, 06 May 2018 14:00:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=l6fi12aPprE1lDRb1Bq2nojQx+bBDynM4vBZiYzrE5s=; b=Jrc6OFBPxNwkGt4LUpM+VSU9K0Oay6fNAOpQaIcIUDJespekEcl3hnmgdChPG+k7Ra cVkTg4NXoUXWmgdL3m/4n9v5b/Kc8xXokpEmCW45dW5vX75ZWW0yOk3ugpI7MQJ6tqVj x3BZoQ/ZhyDYy42Gm80oFlgoy0Vbt32Bis7wCc5Y8bZ9hFDRKqw+/hyvS8TsdbMX9WRG iLGteIz2Of9odUw5D04/FEhXfm3fSZxeXdsBvwGI0cNR2CyHDWNeCusd8U/QuJxHZX89 5srHALlrW2tmM5RHNnO/gTAGlzRem1FKBO3WNRbLRKFcOjx8ag6jwuvUgtw0SC3UW6d9 oFbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=l6fi12aPprE1lDRb1Bq2nojQx+bBDynM4vBZiYzrE5s=; b=NRbAoCRlHReedFU1tEn//wLp5VflJCdQnDk0KZlnRNeiEmPz6Dle2C6Ybj4HSdyqC6 lo9Gntmh5CiwUgqA69A/+k3maIaFSo3ZXLpN1CBNupVVEJ12BSgxoWLV86DZZo49MnqS PQv67NexEE4Ij1W2otinaYBuCNAGpfD72/mrRyrFewpxnb9G8+/jA4F/CDi9MNojgenD KuXo2SeoM40DeW/YIrQ3a0sfkWFAt+W7ZqMGcuv7c1O44Be9uoB3loGE+5d/7wuiFI50 SXPidRWivpDIaUpThdkrretVu0/LIyvltjH4TeKrHxuP7eY4bDANLryJNzaU68Ni86SF x3pQ== X-Gm-Message-State: ALQs6tAmaPEIBLQV8xdtu/Hd4PTPT/jfkUOeOUEZJBPLe/55KRLFZT27 fAhcZPRGEhae1Zh/NhLrM9TrH+Ko X-Google-Smtp-Source: AB8JxZqvvSqk0NySIrloOnAlIfKxCZqddON1kmhdzAomYnS76qHODVeFPZ7cYfkc2zm3njVCG1VVuw== X-Received: by 10.28.186.136 with SMTP id k130mr20737546wmf.101.1525640416818; Sun, 06 May 2018 14:00:16 -0700 (PDT) Original-Received: from breton.holly.idiocy.org (ip6-2001-08b0-03f8-8129-1109-7699-a3f9-a404.holly.idiocy.org. [2001:8b0:3f8:8129:1109:7699:a3f9:a404]) by smtp.gmail.com with ESMTPSA id x73-v6sm5365341wmf.21.2018.05.06.14.00.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 06 May 2018 14:00:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <83o9hsr28g.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:400c:c0c::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:225094 Archived-At: --MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, May 06, 2018 at 10:52:15PM +0300, Eli Zaretskii wrote: > Any objections to releasing Emacs 26.1 in a week's time, anyone? None from me as long as I can apply the attached patch for a crash bug I just discovered this evening. -- Alan Third --MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="0001-Check-NSWindow-is-actually-a-frame.patch" >From e9368809ed26240d3c23d2c9d8946a896a7acfa0 Mon Sep 17 00:00:00 2001 From: Alan Third Date: Sun, 6 May 2018 21:49:31 +0100 Subject: [PATCH] Check NSWindow is actually a frame * src/nsfns.m (Fns_frame_list_z_order): Check NSWindow is an instance of EmacsView before treating it as one. --- src/nsfns.m | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/nsfns.m b/src/nsfns.m index 7f2f060dda..34a7e38c76 100644 --- a/src/nsfns.m +++ b/src/nsfns.m @@ -1497,7 +1497,8 @@ Frames are listed from topmost (first) to bottommost (last). */) Lisp_Object frame; /* Check against [win parentWindow] so that it doesn't match itself. */ - if (parent == nil || ns_window_is_ancestor (parent, [win parentWindow])) + if ([[win delegate] isKindOfClass:[EmacsView class]] + && parent == nil || ns_window_is_ancestor (parent, [win parentWindow])) { XSETFRAME (frame, ((EmacsView *)[win delegate])->emacsframe); frames = Fcons(frame, frames); -- 2.16.1 --MGYHOYXEY6WxJCY8--