From: Masatake YAMATO <yamato@redhat.com>
To: dancol@dancol.org
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH 1/2] Merge subword-mode and capitalized-words-mode
Date: Wed, 08 Aug 2012 03:33:47 +0900 (JST) [thread overview]
Message-ID: <20120808.033347.1098400470410804074.yamato@redhat.com> (raw)
In-Reply-To: <f5700e10ab0deca0a2060a86d931d9bb36f8d610.1344358927.git.dancol@dancol.org>
> subword-mode began life as part of cc-mode, but because it's
> generally useful, it was extracted and made a generic part of
> Emacs. subword-mode uses command remapping to achive its subword
> motion, however, and this mechanism can't catch all kinds of word-
> based motion, resulting in inconsistency.
>
> capitalized-words-mode attempts to do what subword-mode does, but
> using a hook added to C core for the purpose. This hook allows
> capitalizd-words-mode to change all kinds of word-based motion
> into subword motion. Unfortunately, capitalized-words-mode used
> overly simplistic code that caused it to fail to properly move
> over words like "fooBarBAZ"; subword-mode handles these words
> properly. capitalized-words-mode is also disadvantaged by
> a long and misleading name.
>
> This patch merges subword-mode and capitalized-words-mode by
> modifying subword-mode to use the core hook and marking
> capitalized-words-mode as an obsolete alias for subword-mode.
>
> This patch also includes an automated test for subword motion.
Nice.
> -;; TODO: ispell-word.
> -
Does this mean subword-mode can handle ispell with your patch?
If yes, it is really nice.
If not, please keep the TODO item in the comment of the file.
> diff --git a/test/automated/subword.el b/test/automated/subword.el
> new file mode 100644
> index 0000000..9e769cf
> --- /dev/null
> +++ b/test/automated/subword.el
> @@ -0,0 +1,58 @@
> +;;; vc-bzr.el --- tests for progmodes/subword.el
This should be subword.el, shouldn't be?
Masatake YAMATO
next prev parent reply other threads:[~2012-08-07 18:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-07 17:03 [PATCH 0/2] Merge subword-mode and capitalized-words-mode; add to UI Daniel Colascione
2012-08-07 17:03 ` [PATCH 2/2] For better visibility, add subword-mode to options menu Daniel Colascione
2012-08-08 7:53 ` Chong Yidong
2012-08-08 16:25 ` Daniel Colascione
2012-08-07 17:03 ` [PATCH 1/2] Merge subword-mode and capitalized-words-mode Daniel Colascione
2012-08-07 18:33 ` Masatake YAMATO [this message]
2012-08-07 20:43 ` Daniel Colascione
2012-08-07 21:00 ` Daniel Colascione
2012-08-08 2:58 ` Eli Zaretskii
2012-08-07 20:37 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2011-12-30 2:03 Daniel Colascione
2011-12-30 11:23 ` Stefan Monnier
2012-01-04 15:54 ` Masatake YAMATO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120808.033347.1098400470410804074.yamato@redhat.com \
--to=yamato@redhat.com \
--cc=dancol@dancol.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).