From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Masatake YAMATO Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 1/2] Merge subword-mode and capitalized-words-mode Date: Wed, 08 Aug 2012 03:33:47 +0900 (JST) Organization: Red Hat Japan, Inc. Message-ID: <20120808.033347.1098400470410804074.yamato@redhat.com> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1344364446 15910 80.91.229.3 (7 Aug 2012 18:34:06 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 7 Aug 2012 18:34:06 +0000 (UTC) Cc: emacs-devel@gnu.org To: dancol@dancol.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 07 20:34:05 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SyobR-0002Px-2A for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2012 20:34:01 +0200 Original-Received: from localhost ([::1]:45661 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyobQ-0003ia-Bl for ged-emacs-devel@m.gmane.org; Tue, 07 Aug 2012 14:34:00 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyobO-0003iV-2y for emacs-devel@gnu.org; Tue, 07 Aug 2012 14:33:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SyobN-00062j-3d for emacs-devel@gnu.org; Tue, 07 Aug 2012 14:33:58 -0400 Original-Received: from mx1.redhat.com ([209.132.183.28]:8242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SyobM-00062a-Rv for emacs-devel@gnu.org; Tue, 07 Aug 2012 14:33:57 -0400 Original-Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q77IXndJ010939 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 7 Aug 2012 14:33:49 -0400 Original-Received: from localhost (vpn-237-245.phx2.redhat.com [10.3.237.245]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q77IXmB9032686; Tue, 7 Aug 2012 14:33:48 -0400 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.132.183.28 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:152279 Archived-At: > subword-mode began life as part of cc-mode, but because it's > generally useful, it was extracted and made a generic part of > Emacs. subword-mode uses command remapping to achive its subword > motion, however, and this mechanism can't catch all kinds of word- > based motion, resulting in inconsistency. > > capitalized-words-mode attempts to do what subword-mode does, but > using a hook added to C core for the purpose. This hook allows > capitalizd-words-mode to change all kinds of word-based motion > into subword motion. Unfortunately, capitalized-words-mode used > overly simplistic code that caused it to fail to properly move > over words like "fooBarBAZ"; subword-mode handles these words > properly. capitalized-words-mode is also disadvantaged by > a long and misleading name. > > This patch merges subword-mode and capitalized-words-mode by > modifying subword-mode to use the core hook and marking > capitalized-words-mode as an obsolete alias for subword-mode. > > This patch also includes an automated test for subword motion. Nice. > -;; TODO: ispell-word. > - Does this mean subword-mode can handle ispell with your patch? If yes, it is really nice. If not, please keep the TODO item in the comment of the file. > diff --git a/test/automated/subword.el b/test/automated/subword.el > new file mode 100644 > index 0000000..9e769cf > --- /dev/null > +++ b/test/automated/subword.el > @@ -0,0 +1,58 @@ > +;;; vc-bzr.el --- tests for progmodes/subword.el This should be subword.el, shouldn't be? Masatake YAMATO