unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Outline.el: Outlining Perl is failing in a way.
@ 2011-02-02 15:12 Andreas Marschke
  0 siblings, 0 replies; only message in thread
From: Andreas Marschke @ 2011-02-02 15:12 UTC (permalink / raw)
  To: emacs-devel

Hi! 

I like Emacs and I like outline.el, which I frequently use. But it has
a small caveat as I discovered recently. When using outline-minor-mode
on perl-mode with a `sub'(perl-2-lisp:sub->defun). It happens to not
fully wrap-in a function like this:
-*------------------------------------------------------------------*-
sub new {
  my ($class, %parms ) = @_;
  croak("Options to AptPkg::Repackage should be key/value pairs, not hash reference")
    if ref($_[1]) eq 'HASH';

  my $name = delete  $parms{name};
  my $directory = delete  $parms{directory};
  my $verbose = delete  $parms{verbose};
  $verbose = 0 unless defined $verbose;

  print "Build-directory is: ".$directory."\n" if $verbose == 1;
  print "Package-name is: ".$name."\n" if $verbose == 1;

  my $self = bless {
    Package => $name,
    PackageBuildDirectory => $directory,
    Verbose => $verbose
   },$class;

  print "Clean strings...\n" if $verbose == 1;
  $name =~ s:\ ::g if $name =~ m:\ :;
  $directory =~ s:/$::g if $directory =~ m:/$:;

  print "Build-directory is: ".$directory."\n" if $verbose == 1;
  print "Package-name is: ".$name."\n" if $verbose == 1;

  $PackageName = $name;
  $PackageBuildDirectory = $directory."/".$name;
  files();
  return $self;
}
-*------------------------------------------------------------------*-
it only wraps it untill a point like this:
-*------------------------------------------------------------------*-
sub new {...
    Package => $name,
    PackageBuildDirectory => $directory,
    Verbose => $verbose
   },$class;

  print "Clean strings...\n" if $verbose == 1;
  $name =~ s:\ ::g if $name =~ m:\ :;
  $directory =~ s:/$::g if $directory =~ m:/$:;

  print "Build-directory is: ".$directory."\n" if $verbose == 1;
  print "Package-name is: ".$name."\n" if $verbose == 1;

  $PackageName = $name;
  $PackageBuildDirectory = $directory."/".$name;
  files();
  return $self;
}

-*------------------------------------------------------------------*-

Is this fixable? Who is actually the maintainer/developer of
outline.el at the moment? I only found an attribution that it is part
of EMACS and that its © goes to the FSF. What about the person who
wrote it?
 
-- 
Cheers,

Andreas Marschke



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-02-02 15:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-02 15:12 Outline.el: Outlining Perl is failing in a way Andreas Marschke

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).