* recenter is broken
@ 2005-07-07 0:28 Luc Teirlinck
2005-07-07 21:31 ` Richard M. Stallman
0 siblings, 1 reply; 3+ messages in thread
From: Luc Teirlinck @ 2005-07-07 0:28 UTC (permalink / raw)
The following change:
2005-07-06 Richard M. Stallman <rms@gnu.org>
* window.c (Frecenter): When arg is inside the scroll
margin, move it out of the margin.
has some very annoying consequences.
Do `emacs -q -nbc' then:
C-h n
M-x end-of-buffer
Note how the entire file is completely overscrolled out of view.
Apparently, the `(recenter -3)' at the end of end-of-buffer no longer
works.
Sincerely,
Luc.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: recenter is broken
2005-07-07 0:28 recenter is broken Luc Teirlinck
@ 2005-07-07 21:31 ` Richard M. Stallman
2005-07-07 21:41 ` Luc Teirlinck
0 siblings, 1 reply; 3+ messages in thread
From: Richard M. Stallman @ 2005-07-07 21:31 UTC (permalink / raw)
Cc: emacs-devel
Do `emacs -q -nbc' then:
C-h n
M-x end-of-buffer
Note how the entire file is completely overscrolled out of view.
Does this give good results?
*** window.c 06 Jul 2005 14:54:17 -0400 1.509
--- window.c 07 Jul 2005 16:02:47 -0400
***************
*** 5372,5377 ****
--- 5372,5379 ----
line counts would lead to strange effects. */
if (FRAME_WINDOW_P (XFRAME (w->frame)))
{
+ iarg = XINT (arg);
+
if (center_p)
{
struct it it;
***************
*** 5391,5397 ****
int extra_line_spacing;
int h = window_box_height (w);
- iarg = XINT (arg);
iarg = - max (-iarg, this_scroll_margin);
SET_TEXT_POS (pt, PT, PT_BYTE);
--- 5393,5398 ----
***************
*** 5453,5459 ****
{
struct position pos;
- iarg = XINT (arg);
iarg = max (iarg, this_scroll_margin);
pos = *vmotion (PT, -iarg, w);
--- 5454,5459 ----
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-07-07 21:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-07-07 0:28 recenter is broken Luc Teirlinck
2005-07-07 21:31 ` Richard M. Stallman
2005-07-07 21:41 ` Luc Teirlinck
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).