unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* mode-line-highlight
@ 2005-06-02 17:10 Stefan Monnier
  2005-06-02 18:10 ` mode-line-highlight Masatake YAMATO
  2005-06-06 13:19 ` mode-line-highlight Juri Linkov
  0 siblings, 2 replies; 9+ messages in thread
From: Stefan Monnier @ 2005-06-02 17:10 UTC (permalink / raw)


[ I guess this is going to start a useless preference-war, but who knows,
  maybe we're sufficiently clever not to go down that path. ]

I just wanted to mention that I didn't like the default RoyalBlue4/white
appearance of the mode-line-highlight.  It doesn't bother me, but I just
found it loud and ugly.

If people like it, I have no objection to keeping it the way it is (I've
already customized it for myself), but maybe we can use something less
unpleasant to my sense of aesthetics.

What I use instead of

    :background "RoyalBlue4" :foreground "white"
is
    :box (:line-width 2 :color "grey40" :style released-button)

It's much more subdued and sticks to the general grey appearance of
GUI elements.  Also it makes those elements appear as buttons, which I find
to be a good choice for something which can be activated with a click.


        Stefan "ducks & cover"

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mode-line-highlight
  2005-06-02 17:10 mode-line-highlight Stefan Monnier
@ 2005-06-02 18:10 ` Masatake YAMATO
  2005-06-06 13:19 ` mode-line-highlight Juri Linkov
  1 sibling, 0 replies; 9+ messages in thread
From: Masatake YAMATO @ 2005-06-02 18:10 UTC (permalink / raw)
  Cc: emacs-devel

> :background "RoyalBlue4" :foreground "white")

I've just tried your setting and I agree with you; I've found
your definition is better than mine obviously.
New definition fits well with mode-line face.

Masatake YAMATO

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mode-line-highlight
  2005-06-02 17:10 mode-line-highlight Stefan Monnier
  2005-06-02 18:10 ` mode-line-highlight Masatake YAMATO
@ 2005-06-06 13:19 ` Juri Linkov
  2005-06-07  3:32   ` mode-line-highlight Masatake YAMATO
  1 sibling, 1 reply; 9+ messages in thread
From: Juri Linkov @ 2005-06-06 13:19 UTC (permalink / raw)
  Cc: jet, emacs-devel

> I just wanted to mention that I didn't like the default RoyalBlue4/white
> appearance of the mode-line-highlight.  It doesn't bother me, but I just
> found it loud and ugly.
>
> What I use instead of
>
>     :background "RoyalBlue4" :foreground "white"
> is
>     :box (:line-width 2 :color "grey40" :style released-button)
>
> It's much more subdued and sticks to the general grey appearance of
> GUI elements.  Also it makes those elements appear as buttons, which I find
> to be a good choice for something which can be activated with a click.

Yes, the current colors are too loud.  I already proposed to inherit
`mode-line-highlight' from `highlight'.  I still think this is a good
default setting.

But for the 88-colors case (i.e. where the active mode line is
displayed as a big button) your proposal is better.  However, it
looks strange to put a released button over a bigger released button.
Maybe the shape of the pressed button for the mode-line-highlight
is better, i.e.:

    :box (:line-width -1 :color "grey40" :style pressed-button)

BTW, long ago I customized mode-line-inactive in .emacs to a
pressed button:

((t (:inherit mode-line :box (:line-width -1 :style pressed-button))))

It seems logical when the inactive mode line is displayed as
a pressed button while the active mode line is a released button.

PS: There is no distinction currently between active and inactive
modelines on TTY.  Should it be?

PPS: I can't find mode-line-highlight documented in (info "(emacs)Faces").

-- 
Juri Linkov
http://www.jurta.org/emacs/

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mode-line-highlight
  2005-06-06 13:19 ` mode-line-highlight Juri Linkov
@ 2005-06-07  3:32   ` Masatake YAMATO
  2005-06-07  4:30     ` mode-line-highlight Miles Bader
  0 siblings, 1 reply; 9+ messages in thread
From: Masatake YAMATO @ 2005-06-07  3:32 UTC (permalink / raw)
  Cc: monnier, emacs-devel

> PPS: I can't find mode-line-highlight documented in (info "(emacs)Faces").

Thank you for suggestion.
I've just installed it.

Masatake YAMATO

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mode-line-highlight
  2005-06-07  3:32   ` mode-line-highlight Masatake YAMATO
@ 2005-06-07  4:30     ` Miles Bader
  2005-06-07 14:28       ` mode-line-highlight Masatake YAMATO
  0 siblings, 1 reply; 9+ messages in thread
From: Miles Bader @ 2005-06-07  4:30 UTC (permalink / raw)
  Cc: juri, monnier, emacs-devel

BTW, one problem with the mode-line highlighting that I noticed is that
it flickers a lot due to small mouse movements.

Normal in-buffer mouse-highlighting doesn't seem to have this problem
(though I'm judging by eye, not from the code).

-Miles
-- 
I'd rather be consing.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mode-line-highlight
  2005-06-07  4:30     ` mode-line-highlight Miles Bader
@ 2005-06-07 14:28       ` Masatake YAMATO
  2005-06-10 10:23         ` mode-line-highlight Ralf Angeli
  0 siblings, 1 reply; 9+ messages in thread
From: Masatake YAMATO @ 2005-06-07 14:28 UTC (permalink / raw)
  Cc: juri, monnier, emacs-devel

> BTW, one problem with the mode-line highlighting that I noticed is that
> it flickers a lot due to small mouse movements.
> 
> Normal in-buffer mouse-highlighting doesn't seem to have this problem
> (though I'm judging by eye, not from the code).
> 
> -Miles

I've installed a patch to avoid the flickers. Please, try.

Masatake YAMATO

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mode-line-highlight
  2005-06-07 14:28       ` mode-line-highlight Masatake YAMATO
@ 2005-06-10 10:23         ` Ralf Angeli
  2005-06-10 10:39           ` mode-line-highlight Masatake YAMATO
  0 siblings, 1 reply; 9+ messages in thread
From: Ralf Angeli @ 2005-06-10 10:23 UTC (permalink / raw)


* Masatake YAMATO (2005-06-07) writes:

> I've installed a patch to avoid the flickers. Please, try.

Flicker and high CPU load is gone.  But now the highlighting does not
go away once you move the mouse pointer off an active area to another
part of the mode line.

-- 
Ralf

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mode-line-highlight
  2005-06-10 10:23         ` mode-line-highlight Ralf Angeli
@ 2005-06-10 10:39           ` Masatake YAMATO
  2005-06-10 12:16             ` mode-line-highlight Ralf Angeli
  0 siblings, 1 reply; 9+ messages in thread
From: Masatake YAMATO @ 2005-06-10 10:39 UTC (permalink / raw)
  Cc: emacs-devel

> > I've installed a patch to avoid the flickers. Please, try.
> 
> Flicker and high CPU load is gone.  But now the highlighting does not
> go away once you move the mouse pointer off an active area to another
> part of the mode line.

A patch has been installed today. Please try.

2005-06-10  Masatake YAMATO  <jet@gyve.org>

	* xdisp.c (note_mode_line_or_margin_highlight): Call clear_mouse_face
	when mouse_face is not given.
	Remove unnecessary tabs.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: mode-line-highlight
  2005-06-10 10:39           ` mode-line-highlight Masatake YAMATO
@ 2005-06-10 12:16             ` Ralf Angeli
  0 siblings, 0 replies; 9+ messages in thread
From: Ralf Angeli @ 2005-06-10 12:16 UTC (permalink / raw)
  Cc: emacs-devel

* Masatake YAMATO (2005-06-10) writes:

>> Flicker and high CPU load is gone.  But now the highlighting does not
>> go away once you move the mouse pointer off an active area to another
>> part of the mode line.
>
> A patch has been installed today. Please try.

Yes, that fixed it.  Thanks!

-- 
Ralf

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2005-06-10 12:16 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-06-02 17:10 mode-line-highlight Stefan Monnier
2005-06-02 18:10 ` mode-line-highlight Masatake YAMATO
2005-06-06 13:19 ` mode-line-highlight Juri Linkov
2005-06-07  3:32   ` mode-line-highlight Masatake YAMATO
2005-06-07  4:30     ` mode-line-highlight Miles Bader
2005-06-07 14:28       ` mode-line-highlight Masatake YAMATO
2005-06-10 10:23         ` mode-line-highlight Ralf Angeli
2005-06-10 10:39           ` mode-line-highlight Masatake YAMATO
2005-06-10 12:16             ` mode-line-highlight Ralf Angeli

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).