Bug in buffer-local-value

Bug in buffer-local-value

[Luc Teirlinck]

There is a bug in buffer-local-value, when used in connection with
defvaralias.  I believe that the ielm run below is self-explanatory.
The bug affects `C-h v" in a very confusing way.  I am insufficiently
familiar with the involved C code to fix this myself.

*** Welcome to IELM ***  Type (describe-mode) for help.
ELISP> (defvar aa 1)
aa
ELISP> (make-variable-buffer-local 'aa)
aa
ELISP> (defvaralias 'bb 'aa)
aa
ELISP> (setq bb 2)
2
ELISP> bb
2
ELISP> aa
2
ELISP> (buffer-local-value 'bb (current-buffer))
1      ;; Bug: should be 2
ELISP> (buffer-local-value 'aa (current-buffer))
2
ELISP> (local-variable-p 'bb)
t

Re: Bug in buffer-local-value

[Richard Stallman]

Does this fix it?

*** buffer.c	27 May 2005 10:21:40 -0400	1.480
--- buffer.c	28 May 2005 05:48:28 -0400	
***************
*** 889,894 ****
--- 889,897 ----
    CHECK_BUFFER (buffer);
    buf = XBUFFER (buffer);
  
+   if (SYMBOLP (variable))
+     variable = indirect_variable (variable);
+ 
    /* Look in local_var_list */
    result = Fassoc (variable, buf->local_var_alist);
    if (NILP (result))

Re: Bug in buffer-local-value

[Luc Teirlinck]

Richard Stallman wrote:

   Does this fix it?

Yes, it does.

Sincerely,

Luc.