gnus/html2text.el

[Luc Teirlinck <teirllm@dms.auburn.edu>]

gnus/html2text.el calls `beginning-of-buffer', disguised as
`html2text-buffer-head' at several places _inside a loop_.
`beginning-of-buffer' should usually not be called from Lisp to begin
with, unless one really _wants_ to set the mark, but calling it
inside a loop completely ruins the mark ring (and probably slows
things down a lot too).  It should use (goto-char (point-min)), as
clearly explained in the beginning-of-buffer docstring.

Unfortunately, after grepping around a little bit, it would at first
view seem that such abuse of {beginning,end}-of-buffer and other mark
setting commands is even substantially more widespread than the kind
of abuses of `interactive-p' we have been looking at.  Whether
something is an abuse or not is not always obvious, because
occasionally one _really_ wants to set the mark from Lisp.
In the case of gnus/html2text.el it _is_ obvious, however.

Sincerely,

Luc.