From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: gnus/html2text.el Date: Sun, 24 Oct 2004 21:46:46 -0500 (CDT) Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: <200410250246.i9P2kku06530@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1098672527 23782 80.91.229.6 (25 Oct 2004 02:48:47 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 25 Oct 2004 02:48:47 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 25 04:48:35 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CLuuR-0002eq-00 for ; Mon, 25 Oct 2004 04:48:35 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CLv24-0001KK-5n for ged-emacs-devel@m.gmane.org; Sun, 24 Oct 2004 22:56:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CLv1x-0001K4-1U for emacs-devel@gnu.org; Sun, 24 Oct 2004 22:56:21 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CLv1w-0001Js-Kc for emacs-devel@gnu.org; Sun, 24 Oct 2004 22:56:20 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CLv1w-0001Jp-Ib for emacs-devel@gnu.org; Sun, 24 Oct 2004 22:56:20 -0400 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CLuuD-0000Ww-7N for emacs-devel@gnu.org; Sun, 24 Oct 2004 22:48:21 -0400 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id i9P2mKiU002173 for ; Sun, 24 Oct 2004 21:48:20 -0500 (CDT) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id i9P2kku06530; Sun, 24 Oct 2004 21:46:46 -0500 (CDT) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:28876 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:28876 gnus/html2text.el calls `beginning-of-buffer', disguised as `html2text-buffer-head' at several places _inside a loop_. `beginning-of-buffer' should usually not be called from Lisp to begin with, unless one really _wants_ to set the mark, but calling it inside a loop completely ruins the mark ring (and probably slows things down a lot too). It should use (goto-char (point-min)), as clearly explained in the beginning-of-buffer docstring. Unfortunately, after grepping around a little bit, it would at first view seem that such abuse of {beginning,end}-of-buffer and other mark setting commands is even substantially more widespread than the kind of abuses of `interactive-p' we have been looking at. Whether something is an abuse or not is not always obvious, because occasionally one _really_ wants to set the mark from Lisp. In the case of gnus/html2text.el it _is_ obvious, however. Sincerely, Luc.