bug in xselect-convert-to-string

bug in xselect-convert-to-string

[Luc Teirlinck]

Trying to yank text with read-only properties into say, a gnome
terminal, yields an error.   The following patch fixes this.  It seems
like an obvious change to make, but I post the patch before
installing, just to make sure that there are no objections.  If not, I
will install.

===File ~/select-diff=======================================
*** select.el.~1.21.~	Tue Sep  2 07:36:12 2003
--- select.el	Sun May  2 13:00:26 2004
***************
*** 177,182 ****
--- 177,183 ----
  	    (setq coding (coding-system-base coding))
  	  (setq coding 'raw-text))
  	;; Suppress producing escape sequences for compositions.
+ 	(let ((inhibit-read-only t))
  	  (remove-text-properties 0 (length str) '(composition nil) str)
  	  (cond
  	   ((eq type 'TEXT)
***************
*** 216,222 ****
  
  	 (t
  	  (error "Unknow selection type: %S" type))
! 	 ))
  
        (setq next-selection-coding-system nil)
        (cons type str))))
--- 217,223 ----
  
  	   (t
  	    (error "Unknow selection type: %S" type))
! 	   )))
  
        (setq next-selection-coding-system nil)
        (cons type str))))
============================================================

Re: bug in xselect-convert-to-string

[Kenichi Handa]

In article <200405021901.i42J15x05343@raven.dms.auburn.edu>, Luc Teirlinck <teirllm@dms.auburn.edu> writes:

> Trying to yank text with read-only properties into say, a gnome
> terminal, yields an error.   The following patch fixes this.  It seems
> like an obvious change to make, but I post the patch before
> installing, just to make sure that there are no objections.  If not, I
> will install.

I agree with that change.

---
Ken'ichi HANDA
handa@m17n.org

> ===File ~/select-diff=======================================
> *** select.el.~1.21.~	Tue Sep  2 07:36:12 2003
> --- select.el	Sun May  2 13:00:26 2004
> ***************
> *** 177,182 ****
> --- 177,183 ----
>   	    (setq coding (coding-system-base coding))
>   	  (setq coding 'raw-text))
>   	;; Suppress producing escape sequences for compositions.
> + 	(let ((inhibit-read-only t))
>   	  (remove-text-properties 0 (length str) '(composition nil) str)
>   	  (cond
>   	   ((eq type 'TEXT)
> ***************
> *** 216,222 ****
  
>   	 (t
>   	  (error "Unknow selection type: %S" type))
> ! 	 ))
  
>         (setq next-selection-coding-system nil)
>         (cons type str))))
> --- 217,223 ----
  
>   	   (t
>   	    (error "Unknow selection type: %S" type))
> ! 	   )))
  
>         (setq next-selection-coding-system nil)
>         (cons type str))))
> ============================================================


> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://mail.gnu.org/mailman/listinfo/emacs-devel