From: Juanma Barranquero <jmbarranquero@wke.es>
Subject: Re: Improved help from minibuffer prompts
Date: Fri, 30 Apr 2004 15:39:24 +0200 [thread overview]
Message-ID: <20040430153555.28AE.JMBARRANQUERO@wke.es> (raw)
In-Reply-To: <m37jvxixqo.fsf@kfs-l.imdomain.dk>
On 30 Apr 2004 12:08:47 +0200
storm@cua.dk (Kim F. Storm) wrote:
> I have applied your patch locally; I'll use it for a while before
> I'll make a judgement.
Please, try this one instead. It's a bit less elegant because of the
support for CL-style optional arguments, but it works in all tests cases
I've tried.
> But initially, I like it.
Glad to hear.
Juanma
--- help-fns.el.orig 2004-04-30 15:31:10.000000000 +0200
+++ help-fns.el 2004-04-30 15:28:47.000000000 +0200
@@ -131,4 +131,33 @@
;; Functions
+(defun help-highlight-arguments (fun &rest args)
+ (save-excursion
+ (goto-char (point-min))
+ (let* ((case-fold-search nil)
+ (next (and (not args)
+ (re-search-forward (concat "(" (symbol-name fun)) nil t))))
+ (save-restriction
+ (narrow-to-region (point) (re-search-forward ")\n" nil t))
+ (goto-char (point-min))
+ ;; Make a list of all arguments
+ (while next
+ (if (not (re-search-forward " \\((?\\)\\([^ &\)\.]+\\)" nil t))
+ (setq next nil)
+ (setq args (cons (match-string 2) args))
+ (unless (string= (match-string 1) "")
+ ;; A pesky CL-style optional argument with default value,
+ ;; so let's skip over it
+ (search-backward "(")
+ (goto-char (scan-sexps (point) 1))))))
+ ;; Highlight all found arguments anywhere in the *Help* buffer
+ (while args
+ (let* ((arg (car args))
+ (solo (concat "\\<\\(" arg "\\)e?s?\\>"))
+ (high (propertize arg 'face 'font-lock-variable-name-face)))
+ (setq args (cdr args))
+ (goto-char (point-min))
+ (while (re-search-forward solo nil t)
+ (replace-match high nil t nil 1)))))))
+
;;;###autoload
(defun describe-function (function)
@@ -156,4 +185,6 @@
(print-help-return-message)
(with-current-buffer standard-output
+ ;; highlight argument names
+ (help-highlight-arguments function)
;; Return the text we displayed.
(buffer-string))))))
next prev parent reply other threads:[~2004-04-30 13:39 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-13 6:26 Improved help from minibuffer prompts Stefan Reichör
2004-04-13 6:57 ` Miles Bader
2004-04-13 10:48 ` Stefan Reichör
2004-04-14 1:22 ` Miles Bader
2004-04-14 5:35 ` Stefan Reichör
2004-04-14 6:49 ` Miles Bader
2004-04-14 10:04 ` Kim F. Storm
2004-04-14 10:39 ` Stefan Reichör
2004-04-15 16:44 ` Richard Stallman
2004-04-16 6:15 ` Stefan Reichör
2004-04-16 10:04 ` Kim F. Storm
2004-04-16 13:12 ` Kai Grossjohann
2004-04-14 22:53 ` Richard Stallman
2004-04-15 1:23 ` Kim F. Storm
2004-04-16 18:08 ` Richard Stallman
2004-04-14 3:43 ` Masatake YAMATO
2004-04-14 18:02 ` Richard Stallman
2004-04-14 18:02 ` Richard Stallman
2004-04-15 5:50 ` Stefan Reichör
2004-04-16 18:07 ` Richard Stallman
2004-04-16 21:55 ` Kim F. Storm
2004-04-17 19:47 ` Richard Stallman
2004-04-19 7:51 ` Stefan Reichör
2004-04-19 11:50 ` Kim F. Storm
2004-04-29 23:48 ` Juanma Barranquero
2004-04-30 5:32 ` Stefan Reichör
2004-04-30 9:07 ` Juanma Barranquero
2004-05-01 17:51 ` Richard Stallman
2004-05-01 18:33 ` Juanma Barranquero
2004-05-02 19:52 ` Richard Stallman
2004-05-02 22:45 ` Juanma Barranquero
2004-05-03 22:20 ` Richard Stallman
2004-05-06 1:08 ` Juanma Barranquero
2004-05-06 14:13 ` Stefan Monnier
2004-05-07 1:11 ` Juanma Barranquero
2004-05-09 2:03 ` Juanma Barranquero
2004-05-07 0:29 ` Richard Stallman
2004-04-30 10:08 ` Kim F. Storm
2004-04-30 13:39 ` Juanma Barranquero [this message]
2004-04-30 15:50 ` Kim F. Storm
2004-04-30 22:20 ` Juanma Barranquero
2004-04-30 15:57 ` Stefan Monnier
2004-04-30 21:28 ` Juanma Barranquero
2004-04-30 22:49 ` Stefan Monnier
2004-05-01 2:17 ` Juanma Barranquero
2004-05-01 20:23 ` Stefan Monnier
2004-05-02 1:52 ` Juanma Barranquero
2004-05-04 0:32 ` Juanma Barranquero
2004-05-04 20:07 ` Richard Stallman
2004-05-04 22:52 ` Juanma Barranquero
2004-04-19 17:32 ` Drew Adams
2004-04-20 20:47 ` Richard Stallman
2004-04-20 23:13 ` Drew Adams
2004-04-21 6:25 ` Eli Zaretskii
2004-04-19 18:20 ` Richard Stallman
2004-04-16 18:07 ` Richard Stallman
2004-04-15 11:42 ` Matthew Mundell
2004-04-16 6:05 ` Stefan Reichör
2004-04-18 21:47 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040430153555.28AE.JMBARRANQUERO@wke.es \
--to=jmbarranquero@wke.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).