From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: emacs-devel@gnu.org
Subject: Re: Image support for Carbon Emacs
Date: Fri, 16 Jan 2004 14:05:28 +0900 (JST) [thread overview]
Message-ID: <20040116.140528.59464372.mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <pb.m2vfncg1bu.fsf@ID-42241.user.uni-berlin.de>
>>>>> On Fri, 16 Jan 2004 01:54:29 +0100, Hans-Peter Binder <macosx.pb@gmx.de> said:
> But when I try to view a PBM-File Emacs crashed.
Thanks for your experiment and report. I could reproduce the problem
in Mac OS X 10.2.8. In pbm_load, neither img->width nor img->height
are set before calling image_background, and that caused the crash. I
think similar changes are also needed for xfns.c and w32fns.c.
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
*** src/macfns.c-20040113 Tue Jan 13 17:38:05 2004
--- src/macfns.c Fri Jan 16 13:03:32 2004
***************
*** 6926,6931 ****
--- 6926,6934 ----
free_color_table ();
#endif
+ img->width = width;
+ img->height = height;
+
/* Maybe fill in the background field while we have ximg handy. */
if (NILP (image_spec_value (img->spec, QCbackground, NULL)))
IMAGE_BACKGROUND (img, f, ximg);
***************
*** 6933,6941 ****
/* Put the image into a pixmap. */
x_put_x_image (f, ximg, img->pixmap, width, height);
x_destroy_x_image (ximg);
-
- img->width = width;
- img->height = height;
UNGCPRO;
xfree (contents);
--- 6936,6941 ----
next prev parent reply other threads:[~2004-01-16 5:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-12-18 13:57 Consolidation of image support (was Re: Emacs on MAC OS X 10.3) YAMAMOTO Mitsuharu
2003-12-18 16:42 ` Kim F. Storm
2004-01-13 12:10 ` Image support for Carbon Emacs (Re: Consolidation of image support) YAMAMOTO Mitsuharu
2004-01-13 15:55 ` Stefan Monnier
2004-01-19 11:53 ` YAMAMOTO Mitsuharu
2004-01-28 12:48 ` Sébastien Kirche
2004-01-28 18:07 ` Steven Tamm
2004-01-14 0:20 ` Kim F. Storm
2004-01-15 21:22 ` Richard Stallman
2004-01-16 4:22 ` Steven Tamm
2004-01-16 19:54 ` Richard Stallman
2004-01-16 0:54 ` Image support for Carbon Emacs Hans-Peter Binder
2004-01-16 5:05 ` YAMAMOTO Mitsuharu [this message]
2004-01-16 10:44 ` Hans-Peter Binder
2004-04-20 8:43 ` Image support for Carbon Emacs (Re: Consolidation of image support) YAMAMOTO Mitsuharu
2004-04-20 9:03 ` Miles Bader
2004-04-20 9:31 ` YAMAMOTO Mitsuharu
2004-04-20 9:16 ` David Kastrup
2004-04-20 14:28 ` Stefan Monnier
2004-04-21 1:10 ` YAMAMOTO Mitsuharu
2004-04-21 15:58 ` Stefan Monnier
2004-04-22 1:08 ` YAMAMOTO Mitsuharu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040116.140528.59464372.mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).