Re: [Harald.Maier.BW@t-online.de: Endless Loop with diary entries]

Re: [Harald.Maier.BW@t-online.de: Endless Loop with diary entries]

[Gerd Moellmann]

Richard Stallman <rms@gnu.org> writes:

> Can you investigate this?
> 
> From: Harald.Maier.BW@t-online.de
> Subject: Endless Loop with diary entries
> To: emacs-pretest-bug@gnu.org
> CC: Ed Reingold <reingold@emr.cs.iit.edu>, emacs-devel@gnu.org
> Date: Thu, 08 Aug 2002 08:24:52 +0200
> Reply-To: Harald Maier <maierh@myself.com>
> 
> This bug report will be sent to the Free Software Foundation,
> not to your local site managers!
> Please write in English if possible, because the Emacs maintainers
> usually do not have translators to read other languages for them.
> 
> Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list.
> 
> Please describe exactly what actions triggered the bug
> and the precise symptoms of the bug:
> 
> Hello all,
> 
> I followed the discussion in the emacs-devel mailing list about the
> calendar problem. On my system I figured out a similar problem that is
> too related to this problem. If I execute the following lines in a
> .emacs file then the current cvs emacs (see the compilation date)
> hangs in a endless loop in xdisp.c. Personal, I don't think that this
> problem is related to the author of the diary system. The problem
> seems to be related to the changes in xdisp.c because before Aug 8 it
> worked fine and I also don't have problems with emacs-21.2.90.

[...]

Does this patch fix it for you?  (I'm about to install it, too.)

Index: xdisp.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v
retrieving revision 1.775
diff -c -c -r1.775 xdisp.c
*** xdisp.c	3 Aug 2002 12:44:18 -0000	1.775
--- xdisp.c	9 Aug 2002 17:24:43 -0000
***************
*** 3869,3875 ****
         n += STRINGP (it->string) ? 0 : 1)
      {
        if (!get_next_display_element (it))
! 	break;
        newline_found_p = it->what == IT_CHARACTER && it->c == '\n';
        set_iterator_to_next (it, 0);
      }
--- 3869,3875 ----
         n += STRINGP (it->string) ? 0 : 1)
      {
        if (!get_next_display_element (it))
! 	return 0;
        newline_found_p = it->what == IT_CHARACTER && it->c == '\n';
        set_iterator_to_next (it, 0);
      }

Re: [Harald.Maier.BW@t-online.de: Endless Loop with diary entries]

[Harald.Maier.BW]

gerd.moellmann@t-online.de (Gerd Moellmann) writes:
>
> Does this patch fix it for you?  (I'm about to install it, too.)

Yes, perfect! Diary works now again fine.
Harald

> Index: xdisp.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v
> retrieving revision 1.775
> diff -c -c -r1.775 xdisp.c
> *** xdisp.c	3 Aug 2002 12:44:18 -0000	1.775
> --- xdisp.c	9 Aug 2002 17:24:43 -0000
> ***************
> *** 3869,3875 ****
>          n += STRINGP (it->string) ? 0 : 1)
>       {
>         if (!get_next_display_element (it))
> ! 	break;
>         newline_found_p = it->what == IT_CHARACTER && it->c == '\n';
>         set_iterator_to_next (it, 0);
>       }
> --- 3869,3875 ----
>          n += STRINGP (it->string) ? 0 : 1)
>       {
>         if (!get_next_display_element (it))
> ! 	return 0;
>         newline_found_p = it->what == IT_CHARACTER && it->c == '\n';
>         set_iterator_to_next (it, 0);
>       }

Re: [Harald.Maier.BW@t-online.de: Endless Loop with diary entries]

[Gerd Moellmann]

Harald.Maier.BW@t-online.de writes:

> gerd.moellmann@t-online.de (Gerd Moellmann) writes:
> >
> > Does this patch fix it for you?  (I'm about to install it, too.)
> 
> Yes, perfect! Diary works now again fine.

Thanks for testing it, Harald.

Richard, I've installed the fix in HEAD and RC.

Re: [Harald.Maier.BW@t-online.de: Endless Loop with diary entries]

[Richard Stallman]

    Richard, I've installed the fix in HEAD and RC.

Thank you for handling it.