no confirmation that email sent when setting coding system

no confirmation that email sent when setting coding system

[Robert J. Chassell]

Using a recent CVS snapshot, 2002 Aug  1,
GNU Emacs 21.3.50.144 (i686-pc-linux-gnu, X toolkit)
configured using `configure --with-type1 --prefix=/usr/local --with-sound=yes'
with a large .emacs file.

Sometimes (as with two recent bug reports to Kai), Mail mode asks me
which coding system to use (I have been choosing the default it
offers, which in this case has been utf-8).  

After I choose the coding sytem, Emacs pops back the mail buffer,
marked as changed (i.e., ** in the mode line), whereas the usual
consequence of sending a message is to mark the buffer as unchanged
(i.e., -- in the mode line).  

Also, in the usual course of events, an old *mail* buffer that is
marked unchanged is reused; but in this circumstance, it is not.
(This email message is being written in buffer *mail*<4> !)

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C
  locale-coding-system: nil
  default-enable-multibyte-characters: t

-- 
    Robert J. Chassell                  bob@rattlesnake.com
    Rattlesnake Enterprises             http://www.rattlesnake.com

Re: no confirmation that email sent when setting coding system

[Kenichi Handa]

In article <m17b7bz-000IeIC@localhost>, "Robert J. Chassell" <bob@rattlesnake.com> writes:
> Sometimes (as with two recent bug reports to Kai), Mail mode asks me
> which coding system to use (I have been choosing the default it
> offers, which in this case has been utf-8).  

> After I choose the coding sytem, Emacs pops back the mail buffer,
> marked as changed (i.e., ** in the mode line), whereas the usual
> consequence of sending a message is to mark the buffer as unchanged
> (i.e., -- in the mode line).  

> Also, in the usual course of events, an old *mail* buffer that is
> marked unchanged is reused; but in this circumstance, it is not.
> (This email message is being written in buffer *mail*<4> !)

I've just committed this change.  Could you please try again
with the latest code or with this patch?

---
Ken'ichi HANDA
handa@etl.go.jp


2002-08-07  Kenichi Handa  <handa@etl.go.jp>

	* international/mule-cmds.el (select-safe-coding-system): Call
	pop-to-buffer inside save-window-excursion and save-excursion.

Index: mule-cmds.el
===================================================================
RCS file: /cvs/emacs/lisp/international/mule-cmds.el,v
retrieving revision 1.200
retrieving revision 1.201
diff -u -c -r1.200 -r1.201
cvs server: conflicting specifications of output style
*** mule-cmds.el	5 Aug 2002 16:34:53 -0000	1.200
--- mule-cmds.el	7 Aug 2002 12:21:25 -0000	1.201
***************
*** 676,690 ****
  			  (coding-system-category elt)))
  	    (push elt l))))
  
!       ;; Make sure the offending buffer is displayed.
!       (or (stringp from)
! 	  (pop-to-buffer bufname))
!       (save-excursion
! 	(goto-char (unencodable-char-position
! 		    from to (mapcar #'car default-coding-system)))
! 	;; Then ask users to select one form CODINGS.
! 	(unwind-protect
! 	    (save-window-excursion
  	      (with-output-to-temp-buffer "*Warning*"
  		(save-excursion
  		  (set-buffer standard-output)
--- 676,690 ----
  			  (coding-system-category elt)))
  	    (push elt l))))
  
!       (unwind-protect
! 	  (save-window-excursion
! 	    (save-excursion
! 	      ;; Make sure the offending buffer is displayed.
! 	      (unless (stringp from)
! 		(pop-to-buffer bufname)
! 		(goto-char (unencodable-char-position
! 				from to (mapcar #'car default-coding-system))))
! 	      ;; Then ask users to select one from CODINGS.
  	      (with-output-to-temp-buffer "*Warning*"
  		(save-excursion
  		  (set-buffer standard-output)

Re: no confirmation that email sent when setting coding system

[Richard Stallman]

    Sometimes (as with two recent bug reports to Kai), Mail mode asks me
    which coding system to use (I have been choosing the default it
    offers, which in this case has been utf-8).  

    After I choose the coding sytem, Emacs pops back the mail buffer,
    marked as changed (i.e., ** in the mode line), whereas the usual

Can you come up with a test case for this problem?
Handa, once you can reproduce it, could you investigate?

Re: no confirmation that email sent when setting coding system

[Robert J. Chassell]

   > "Robert J. Chassell" <bob@rattlesnake.com> writes:

   > After I choose the coding sytem, Emacs pops back the mail buffer,
   > marked as changed (i.e., ** in the mode line), whereas the usual
   > consequence of sending a message is to mark the buffer as unchanged
   > (i.e., -- in the mode line).  

   I've just committed this change.  Could you please try again
   with the latest code or with this patch?

Success!  You fixed the problem.  Thank you.  

I tested it with the same text as in a message that had caused the trouble.
using a very new CVS snapshot with your changes in it,
from Wed, 2002 Aug  7  14:42 UTC
GNU Emacs 21.3.50.159 (i686-pc-linux-gnu, X toolkit)

-- 
    Robert J. Chassell            bob@rattlesnake.com  bob@gnu.org
    Rattlesnake Enterprises       http://www.rattlesnake.com
    Free Software Foundation      http://www.gnu.org   GnuPG Key ID: 004B4AC8