From: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>
Cc: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>,
storm@cua.dk (Kim F. Storm),
rms@gnu.org, emacs-devel@gnu.org
Subject: Re: What happened to the key-menu patch?
Date: Wed, 10 Jul 2002 14:12:52 -0400 [thread overview]
Message-ID: <200207101812.g6AICqA31949@rum.cs.yale.edu> (raw)
In-Reply-To: buowus4cnf8.fsf@mcspd15.ucom.lsi.nec.co.jp
> > > sure if it's worth it to add a `dobindings' macro or not.
> > Agreed. There's already a `loop' macro for it in CL.
> Yeah, but we don't really like cl in emacs, remember? Oh wait, you do.
Indeed, I do. And `loop' is a macro so it only needs CL at compile-time
which is usually regarded as OK.
> > > key-description list' is, but it's something like (meta control x).
> > > I guess this is a canonical format for key names in xemacs, but it
> > > doesn't appear to be so in emacs, so I'm not sure how that argument
> > > should be handled (perhaps just punt, and pass whatever's stored in
> > > the keymap).
> >
> > I don't think we should try to re-create the XEmacs (meta control x) form
> > from our M-C-x symbols. We could provide an additional compatibility layer
> > on top of it, if it proves useful/necessary later on.
>
> So, just pass whatever's stored in the keymap directly?
Yes.
> > > (2) How are menu entries handled with this?
> >
> > As for how we should treat them, I think we should not do anything
> > special with them: i.e. `function' will be called with key `menu-bar'
> > and with the corresponding sub-keymap as the binding.
>
> That would be consistent with `lookup-key', but it also throws out
> a bunch of useful information for menu-entries -- in particular, the
> very information that I want for the key-menus!
>
> How about just passing something similar to the corresponding arguments
> to define-key,
Yes, that's exactly what I meant and what my code does.
> e.g., for keys, `function' would be the function, but
> for menu-entries, it would be the whole (menu-item ...) list.
Yes, but I said `menu-bar' and the thing bound to `menu-bar'
is usually just a keymap because the menubar itself has no name:
only entries inside the keymap bound to `menu-bar' will
have `menu-item' thingies.
> Either way, we have to provide some other sort of function to allow
> easily going from one form to the other -- if we just pass the
> function/sub-keymap, there needs to be a way for the user to lookup all
> the menu-item information, and if we pass the (menu-item...) list
> directly, there should probably be some access function(s) to make
> getting at the various pieces cleanly.
Of course, we need to export some kind of parse-menu-item function,
as was discussed a few weeks/months back.
> Perhaps the thing to do is to pass only the function/sub-keymap by
> default, but have an optional argument that says `pass all menu info for
> menu-items'; this could possible be combined with Richard's suggestion
> of having an option to suppress passing menu-items altogether.
I think it's better to just pas the menu-items all the time: we'll
need the parse-menu-item functionality anyway.
> We could (rather, should) add a similar optional argument to
> `lookup-key' for conistency and utility.
I have also thought about it, but the need has never arisen
(not even in the C code).
Stefan
next prev parent reply other threads:[~2002-07-10 18:12 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200205050534.g455YfF01634@aztec.santafe.edu>
2002-05-05 22:02 ` Assignment of misc packages for emacs Kim F. Storm
2002-05-06 23:07 ` Alex Schroeder
2002-05-08 1:16 ` Miles Bader
2002-05-08 1:47 ` Stefan Monnier
2002-05-09 2:45 ` Richard Stallman
2002-05-07 14:08 ` Kai Großjohann
2002-05-08 13:58 ` Richard Stallman
2002-05-08 1:31 ` Miles Bader
2002-05-08 6:23 ` Thien-Thi Nguyen
2002-05-14 19:41 ` Richard Stallman
2002-05-14 19:41 ` Richard Stallman
2002-05-14 23:44 ` Kim F. Storm
2002-05-15 1:08 ` Miles Bader
2002-05-15 21:37 ` Kim F. Storm
2002-05-16 1:19 ` Miles Bader
2002-05-17 19:29 ` Richard Stallman
2002-05-17 21:42 ` Kim F. Storm
2002-05-17 19:29 ` Richard Stallman
2002-05-17 21:31 ` Kim F. Storm
2002-05-16 7:22 ` Richard Stallman
2002-05-16 23:41 ` Kim F. Storm
2002-05-15 4:51 ` Eli Zaretskii
2002-05-15 8:41 ` Andreas Schwab
2002-05-15 10:20 ` Eli Zaretskii
2002-05-15 11:08 ` Andreas Schwab
2002-05-15 21:41 ` Kim F. Storm
2002-05-15 19:27 ` Stefan Monnier
2002-05-15 20:37 ` Andreas Schwab
2002-05-16 23:39 ` Kim F. Storm
2002-05-16 22:49 ` Stefan Monnier
2002-05-17 6:27 ` Eli Zaretskii
2002-05-17 7:10 ` Miles Bader
2002-05-17 9:21 ` Andreas Schwab
2002-05-17 11:13 ` Miles Bader
2002-05-17 9:40 ` Eli Zaretskii
2002-05-17 11:15 ` Miles Bader
2002-05-17 10:47 ` Kim F. Storm
2002-05-17 10:08 ` Stefan Monnier
2002-05-17 11:20 ` Miles Bader
2002-05-17 12:07 ` Kim F. Storm
2002-05-17 11:28 ` Miles Bader
2002-05-18 18:48 ` Richard Stallman
2002-05-18 21:39 ` Kim F. Storm
2002-05-19 19:40 ` Richard Stallman
2002-05-18 22:37 ` Stefan Monnier
2002-05-19 19:40 ` Richard Stallman
2002-05-16 23:07 ` Miles Bader
2002-05-18 18:48 ` Richard Stallman
2002-05-19 11:57 ` Miles Bader
2002-05-19 14:41 ` Stefan Monnier
2002-05-19 15:12 ` Miles Bader
2002-05-20 6:38 ` Miles Bader
2002-05-20 9:57 ` Alex Schroeder
2002-05-20 10:06 ` Kai Großjohann
2002-05-20 21:34 ` Richard Stallman
2002-05-21 9:54 ` Mario Lang
2002-05-21 10:23 ` Miles Bader
2002-05-22 22:29 ` Richard Stallman
2002-05-21 10:20 ` Miles Bader
2002-05-22 22:27 ` Richard Stallman
2002-05-23 7:08 ` Miles Bader
2002-05-23 16:49 ` Mario Lang
2002-05-23 22:21 ` Miles Bader
2002-06-04 17:27 ` Miles Bader
2002-06-05 14:42 ` Stefan Monnier
2002-06-06 1:07 ` Miles Bader
2002-06-06 1:37 ` Stefan Monnier
2002-06-06 1:46 ` Miles Bader
2002-06-06 7:57 ` Miles Bader
2002-06-07 0:45 ` Richard Stallman
2002-06-07 0:45 ` Richard Stallman
2002-06-05 23:10 ` Kim F. Storm
2002-06-06 1:09 ` Miles Bader
2002-06-06 1:24 ` Miles Bader
2002-06-07 0:45 ` Richard Stallman
2002-06-07 23:26 ` Kim F. Storm
2002-06-08 1:09 ` Miles Bader
2002-06-08 19:15 ` Richard Stallman
2002-06-06 12:04 ` Richard Stallman
2002-06-06 12:41 ` Miles Bader
2002-06-06 13:37 ` Stefan Monnier
2002-06-06 13:45 ` Miles Bader
2002-06-07 23:23 ` Richard Stallman
2002-06-08 4:06 ` Miles Bader
2002-06-09 15:19 ` Richard Stallman
2002-06-10 14:35 ` Stefan Monnier
2002-06-11 19:25 ` Richard Stallman
2002-07-07 22:46 ` What happened to the key-menu patch? Kim F. Storm
2002-07-09 7:00 ` Miles Bader
2002-07-09 13:58 ` Stefan Monnier
2002-07-10 2:43 ` Miles Bader
2002-07-10 18:12 ` Stefan Monnier [this message]
2002-07-10 10:43 ` Richard Stallman
2002-07-11 17:13 ` Stefan Monnier
2002-07-12 17:37 ` Richard Stallman
2002-07-12 18:07 ` Stefan Monnier
2002-07-13 14:20 ` Richard Stallman
2002-07-13 17:37 ` Stefan Monnier
2002-07-15 1:09 ` Richard Stallman
2002-07-09 18:51 ` Richard Stallman
2002-07-10 2:45 ` Miles Bader
2002-07-10 19:20 ` Richard Stallman
2002-05-20 14:48 ` Assignment of misc packages for emacs Richard Stallman
2002-05-18 18:48 ` Richard Stallman
2002-05-18 20:07 ` Kim F. Storm
2002-05-19 19:40 ` Richard Stallman
2002-05-16 7:21 ` Richard Stallman
2002-05-16 7:21 ` Richard Stallman
2002-05-15 7:44 ` D. Goel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200207101812.g6AICqA31949@rum.cs.yale.edu \
--to=monnier+gnu/emacs@rum.cs.yale.edu \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
--cc=storm@cua.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).