From: "Jan D." <jan.h.d@swipnet.se>
Cc: emacs-devel@gnu.org, dajo@a-vip.com
Subject: Re: Patch for Emacs X focus issue
Date: Mon, 24 Jun 2002 23:14:49 +0200 (CEST) [thread overview]
Message-ID: <200206242113.g5OLDguO005787@stubby.bodenonline.com> (raw)
In-Reply-To: <200206241939.g5OJdUC26206@aztec.santafe.edu> "from Richard Stallman at Jun 24, 2002 01:39:30 pm"
> The code in question ignored FOCUS_IN_EVENT when looking for pending
> input.
>
> That was the intention. There was a bug report that input-pending-p
> reported that there was input available, even when it was just a focus
> change. I made this change to fix that.
>
> So when a new frame got focus, the modeline face was not
> changed immediately to the "active" looking face.
>
> It is right to fix that bug, but simply removing the change is not
> correct. That would reintroduce the other bug.
I have considerably reduced the number of FOCUS_IN_EVENTs generated with
this patch. On the configuration used where the input-pending-p problem
occured (Gnome/sawfish), with a simple test case (make two frames,
open up one menu and close it, first on the second frame, then on the first,
kill emacs) generated 30 FOCUS_IN_EVENTs with the old code.
With this focus patch the number is 6.
It would be great if the original poster of the input-pending-p
problem could retest with this patch to see if the problem remains.
Is that possible? (Cc:ing the reporter of that bug).
I initially solved the "modline face" bug by making two events, one
FOCUS_IN_EVENT followed by an empty HELP_EVENT. Since this triggers
input-pending-p anyway, I guess it is a bad fix.
A way to fix the "modline face" bug (I noticed now that the cursor also
doesn't start blinking) would be to let only Finput_pending_p ignore
FOCUS_IN_EVENTS. Is that a way to go?
Jan D.
next prev parent reply other threads:[~2002-06-24 21:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-23 19:16 Patch for Emacs X focus issue Jan D.
2002-06-23 19:47 ` Stefan Monnier
2002-06-23 20:08 ` Jan D.
2002-06-24 19:39 ` Richard Stallman
2002-06-24 21:14 ` Jan D. [this message]
2002-06-25 19:10 ` David
2002-06-25 23:32 ` Richard Stallman
2002-06-26 13:03 ` Jan D.
2002-06-28 17:39 ` Richard Stallman
2002-06-28 19:57 ` Jan D.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200206242113.g5OLDguO005787@stubby.bodenonline.com \
--to=jan.h.d@swipnet.se \
--cc=dajo@a-vip.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).