From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Jan D." Newsgroups: gmane.emacs.devel Subject: Re: Patch for Emacs X focus issue Date: Mon, 24 Jun 2002 23:14:49 +0200 (CEST) Sender: emacs-devel-admin@gnu.org Message-ID: <200206242113.g5OLDguO005787@stubby.bodenonline.com> References: <200206241939.g5OJdUC26206@aztec.santafe.edu> NNTP-Posting-Host: localhost.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1024953669 27781 127.0.0.1 (24 Jun 2002 21:21:09 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 24 Jun 2002 21:21:09 +0000 (UTC) Cc: emacs-devel@gnu.org, dajo@a-vip.com Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.33 #1 (Debian)) id 17MbGn-0007Dy-00 for ; Mon, 24 Jun 2002 23:21:09 +0200 Original-Received: from fencepost.gnu.org ([199.232.76.164]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 17MbI7-0005QG-00 for ; Mon, 24 Jun 2002 23:22:31 +0200 Original-Received: from localhost ([127.0.0.1] helo=fencepost.gnu.org) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17MbGs-00033e-00; Mon, 24 Jun 2002 17:21:14 -0400 Original-Received: from stubby.bodenonline.com ([213.115.192.62]) by fencepost.gnu.org with esmtp (Exim 3.34 #1 (Debian)) id 17MbEU-0002lR-00; Mon, 24 Jun 2002 17:18:46 -0400 Original-Received: from pc35.bodenonline.com (IDENT:root@pc35.bodenonline.com [195.196.29.227] (may be forged)) by stubby.bodenonline.com (8.12.1/8.12.1) with ESMTP id g5OLDguO005787; Mon, 24 Jun 2002 23:13:47 +0200 In-Reply-To: <200206241939.g5OJdUC26206@aztec.santafe.edu> "from Richard Stallman at Jun 24, 2002 01:39:30 pm" Original-To: rms@gnu.org Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.9 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:5172 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:5172 > The code in question ignored FOCUS_IN_EVENT when looking for pending > input. > > That was the intention. There was a bug report that input-pending-p > reported that there was input available, even when it was just a focus > change. I made this change to fix that. > > So when a new frame got focus, the modeline face was not > changed immediately to the "active" looking face. > > It is right to fix that bug, but simply removing the change is not > correct. That would reintroduce the other bug. I have considerably reduced the number of FOCUS_IN_EVENTs generated with this patch. On the configuration used where the input-pending-p problem occured (Gnome/sawfish), with a simple test case (make two frames, open up one menu and close it, first on the second frame, then on the first, kill emacs) generated 30 FOCUS_IN_EVENTs with the old code. With this focus patch the number is 6. It would be great if the original poster of the input-pending-p problem could retest with this patch to see if the problem remains. Is that possible? (Cc:ing the reporter of that bug). I initially solved the "modline face" bug by making two events, one FOCUS_IN_EVENT followed by an empty HELP_EVENT. Since this triggers input-pending-p anyway, I guess it is a bad fix. A way to fix the "modline face" bug (I noticed now that the cursor also doesn't start blinking) would be to let only Finput_pending_p ignore FOCUS_IN_EVENTS. Is that a way to go? Jan D.