window.c initialization fix

window.c initialization fix

[Keiichiro Nagano]

Hi,

In make_window, p->height_fixed_p, p->last_cursor_off_p and
p->cursor_off_p are not initialized to zero.  I think this is a bug.

(Now I'm working for 'portable dumper', a new feature for Emacs.  I
was troubled by this bug, bacause, with portable dumper, all basic
Lisp_Objects (Qnil, Qt, Vobarray and so on) are relocated to unusual
address.)

-- 
Keiichiro Nagano



Index: window.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/window.c,v
retrieving revision 1.412
diff -u -u -r1.412 window.c
--- window.c	   17 Apr 2002 10:36:08 -0000	1.412
+++ window.c	   21 Apr 2002 20:20:39 -0000
@@ -287,6 +287,8 @@
   XSETWINDOW (val, p);
   XSETFASTINT (p->last_point, 0);
   p->frozen_window_start_p = 0;
+  p->height_fixed_p = 0;
+  p->last_cursor_off_p = p->cursor_off_p = 0;
 
   Vwindow_list = Qnil;
   return val;

Re: window.c initialization fix

[Pavel Janík]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

   From: Keiichiro Nagano (永野圭一郎) <knagano@sodan.org>
   Date: Mon, 22 Apr 2002 05:38:55 +0900

Hi,

   > (Now I'm working for 'portable dumper', a new feature for Emacs.  I
   > was troubled by this bug, bacause, with portable dumper, all basic
   > Lisp_Objects (Qnil, Qt, Vobarray and so on) are relocated to unusual
   > address.)

[-- Attachment #2: Type: text/plain, Size: 135 bytes --]


can you tell us more about that feature, please?
-- 
Pavel Janík

640 K ought be enough.
                  -- Bill Gates, 1984

portable dumper (Re: window.c initialization fix)

[Keiichiro Nagano]

Hi,

At Mon, 22 Apr 2002 11:01:56 +0200,
Pavel Janík wrote:
>    > (Now I'm working for 'portable dumper', a new feature for Emacs.  I
>    > was troubled by this bug, bacause, with portable dumper, all basic
>    > Lisp_Objects (Qnil, Qt, Vobarray and so on) are relocated to unusual
>    > address.)
> 
> can you tell us more about that feature, please?

  The aim of the portable dumper is to solve the same problem as the
  system-specific dumper, that is to be able to reload quickly, using
  only a small number of files, the fully initialized lisp part of the
  editor, without any system-specific hacks. (XEmacs Internals Manual)

I have done with the portable dumper for Meadow, and now we (Meadow
developers) are testing it.  Soon I will make a patch for FSF Emacs.

-- 
Keiichiro Nagano

Re: portable dumper (Re: window.c initialization fix)

[Richard Stallman]

      The aim of the portable dumper is to solve the same problem as the
      system-specific dumper, that is to be able to reload quickly, using
      only a small number of files, the fully initialized lisp part of the
      editor, without any system-specific hacks. (XEmacs Internals Manual)

    I have done with the portable dumper for Meadow, and now we (Meadow
    developers) are testing it.

I am confused here.  Is the portable dumper an existing part of XEmacs,
or is it something you are writing now?  Did you write the whole
portable dumper, or did other people write some of the code in it?

What is Meadow, and how does it relate to XEmacs?

      Soon I will make a patch for FSF Emacs.

Please don't call our program "FSF Emacs"--that name was put forward
by people who were not working with us, and we have never wanted it.

Re: portable dumper (Re: window.c initialization fix)

[Keiichiro Nagano]

At Tue, 23 Apr 2002 13:31:01 -0600 (MDT),
Richard Stallman wrote:
> I am confused here.  Is the portable dumper an existing part of XEmacs,
> or is it something you are writing now?  Did you write the whole
> portable dumper, or did other people write some of the code in it?

We, Yoshiki Hayashi and I, wrote the whole of the portable dumper
subsystem from scratch, though Hayashi-san is a member of the XEmacs
development team.  Now I am maintaining the code.


> What is Meadow, and how does it relate to XEmacs?

Meadow is a port of Emacs for Windows with additional features, made
by himi-san.  It has no relation to XEmacs.

The idea of the portable dumper is general, it is not
Emacs,XEmacs-specific.  I quoted the XEmacs Internals Manual to
explain what the portable dumper is.  I have no other intentions
except this.


>       Soon I will make a patch for FSF Emacs.
> 
> Please don't call our program "FSF Emacs"--that name was put forward
> by people who were not working with us, and we have never wanted it.

Ok.

-- 
Keiichiro Nagano

Re: portable dumper (Re: window.c initialization fix)

[Richard Stallman]

    We, Yoshiki Hayashi and I, wrote the whole of the portable dumper
    subsystem from scratch, though Hayashi-san is a member of the XEmacs
    development team.  Now I am maintaining the code.

Are both of you willing to sign legal papers for it?  If so, we will
be able to install it in Emacs.

    Meadow is a port of Emacs for Windows with additional features, made
    by himi-san.

What are the extra features that Meadow has?  Are they useful on
systems other than Windows?  Would it make sense to add them to Emacs?