From: Ken Brown <kbrown@cornell.edu>
To: emacs-devel@gnu.org, Eli Zaretskii <eliz@gnu.org>
Subject: Re: master 95b1eacd47: Fix handling of UNCs in 'parse-colon-path
Date: Wed, 24 Aug 2022 14:34:02 -0400 [thread overview]
Message-ID: <1a7d3a5b-6022-906f-8bc3-9280ff1ad4c2@cornell.edu> (raw)
In-Reply-To: <20220824162100.7A8DFC0088A@vcs2.savannah.gnu.org>
On 8/24/2022 12:20 PM, Eli Zaretskii wrote:
> branch: master
> commit 95b1eacd4750da7329380aabcb383a8f9d96a59b
> Author: Eli Zaretskii <eliz@gnu.org>
> Commit: Eli Zaretskii <eliz@gnu.org>
>
> Fix handling of UNCs in 'parse-colon-path
>
> * lisp/files.el (parse-colon-path): Don't remove the second
> leading slash on systems that support UNCs. (Bug#57353)
>
> * test/lisp/files-tests.el (files-tests-bug-21454): Update
> expected results.
> (files-colon-path): Add a new test pattern.
After this commit I'm getting the following test failure on Cygwin. I don't
have time to look into it now, but I can do so in a few days if the fix isn't
obvious.
Test files-tests-bug-21454 backtrace:
signal(ert-test-failed (((should (equal res (parse-colon-path "$FOO"
ert-fail(((should (equal res (parse-colon-path "$FOO"))) :form (equa
#f(compiled-function () #<bytecode 0x197d9660f67edbed>)()
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name files-tests-bug-21454 :documentation
ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m
ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n
ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) (
ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un
eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) (
command-line-1(("-L" ":../../master/test" "-l" "ert" "-l" "lisp/file
command-line()
normal-top-level()
Test files-tests-bug-21454 condition:
(ert-test-failed
((should
(equal res
(parse-colon-path "$FOO")))
:form
(equal
("/foo/bar/" "/bar/qux/" "/qux/foo/")
("//foo/bar/" "/bar/qux/" "/qux/foo/"))
:value nil :explanation
(list-elt 0
(arrays-of-different-length 9 10 "/foo/bar/" "//foo/bar/" first-mismatch-at 1))))
Ken
next parent reply other threads:[~2022-08-24 18:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166135805961.19216.9573795919733967151@vcs2.savannah.gnu.org>
[not found] ` <20220824162100.7A8DFC0088A@vcs2.savannah.gnu.org>
2022-08-24 18:34 ` Ken Brown [this message]
2022-08-24 18:48 ` master 95b1eacd47: Fix handling of UNCs in 'parse-colon-path Eli Zaretskii
2022-08-24 22:03 ` Ken Brown
2022-08-25 5:18 ` Eli Zaretskii
2022-08-25 12:56 ` Ken Brown
2022-08-27 23:04 ` Ken Brown
2022-08-28 5:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a7d3a5b-6022-906f-8bc3-9280ff1ad4c2@cornell.edu \
--to=kbrown@cornell.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).