From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: master 95b1eacd47: Fix handling of UNCs in 'parse-colon-path Date: Wed, 24 Aug 2022 14:34:02 -0400 Message-ID: <1a7d3a5b-6022-906f-8bc3-9280ff1ad4c2@cornell.edu> References: <166135805961.19216.9573795919733967151@vcs2.savannah.gnu.org> <20220824162100.7A8DFC0088A@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4829"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 To: emacs-devel@gnu.org, Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Aug 24 20:35:17 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQvDg-00017z-Nw for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Aug 2022 20:35:17 +0200 Original-Received: from localhost ([::1]:34346 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQvDf-00073C-99 for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Aug 2022 14:35:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44530) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQvCq-0006Cd-FU for emacs-devel@gnu.org; Wed, 24 Aug 2022 14:34:24 -0400 Original-Received: from mail-bn8nam12on2130.outbound.protection.outlook.com ([40.107.237.130]:9952 helo=NAM12-BN8-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQvCo-00052P-CM; Wed, 24 Aug 2022 14:34:24 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XqddKi24OHgyTrtU3s0wpAs3RV0P4u9ZkHxIeHMjPG23weUQ6rGQjxzzZ4LhjohZtE5fH98k5zgF7Kc69x+G64sU4ADyO177oqYQ+VLrpyn34hluhgCR52vbyDRirdjkr0Hg1mOufBgKAzUWrlfAUX/3HHk6zaWXSR4WhIADnZ9rS6LjGdM4NljPz5/C8CNiDbGf1p5b42WbV8z1PP65U3YCIcEIT+2mWI79+nPjKm40QpgaX5opWEZsqIU6zMag4ui1duDyWhIbD+2w2fFTR+w3UodBZLnzSwgF9R8PErh1zBj0dq0ZwEh54m2iyiWpZYIYeQtM2rezs9GmMJrTnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DlzuRWL7Ns6SPgtFoijVnIdT5NHgLwLx3CADHvghzWU=; b=Eg4tHcDwSucPKTeql6vnZ4W/LjvVdYN0PPYVLibPzfsj3PxCDkkORlng3HFIOwcreNY+7z//EJA1MaFzdliXzD0lwtokShDgHdbXdUcZsTJ3bjW8z3t9okptO6nhjMVqNDJHptBPlxRUMJd5xuLI1rT9ZytErpXkVBhGIB8WF20PQ1KUYp02Rk/Q+r/NAkro8TG0Pppgv40ywEMMaeVi+42C3wBuba+tYIWTYremEGDZx2X0OyCWmJ+KReXieNdhKGi46PcQxdHeiXvPEvP0J/s7138B75aFgu6hpUvzgUaUmavHnekYGVRsgRhywXXL7D/84Zngjfqr5yIic8khxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DlzuRWL7Ns6SPgtFoijVnIdT5NHgLwLx3CADHvghzWU=; b=eII8yljneucpxRSWByK2vAPukyaKxyQlq95j9qFar7pZ+fJmea1jehWhLXNy+QSDu6BSWbluhlDLpmXZWbRydgeBa6GtPjiXgqhH8mp+HITpTnC6xM9I2xa8+0Covvj+d3TfFB4NOHUemxbPIR6ygoq0l70aKpr62YQk7ZM1xts= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cornell.edu; Original-Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by BN8PR04MB6210.namprd04.prod.outlook.com (2603:10b6:408:54::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5546.21; Wed, 24 Aug 2022 18:34:04 +0000 Original-Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::4417:167:d80b:6dcd]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::4417:167:d80b:6dcd%5]) with mapi id 15.20.5546.022; Wed, 24 Aug 2022 18:34:04 +0000 Content-Language: en-US In-Reply-To: <20220824162100.7A8DFC0088A@vcs2.savannah.gnu.org> X-ClientProxiedBy: MN2PR03CA0003.namprd03.prod.outlook.com (2603:10b6:208:23a::8) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: cf4cc893-6d9c-46c5-fef1-08da85ff38ae X-MS-TrafficTypeDiagnostic: BN8PR04MB6210:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hJmirTCf8H/sE0vGwkmRJJDd7Kvo71YzqM5tyfBjrtBb0ci+28o0gh/qbOjyQzn4t2ZWw5GujAjxVv9sr2Mys2do+L69ZPPhNUWw9Vt4CNrS6uXrCa8OJbPtPKpadPs9euw2V94PFUWSgt1Bj+vAxokjJZRvUF0Zul7SvFZAjhcK8SYgwZpvC5xttPpLR+VHIYlvgI/Tg4tVnQouBTD4aze7zUhBUgnoixbY9ejekPj3p2+8G6oMN1DzKJc4nRGY8VsFC6dQDJFF0MqU5aQhSBQ1XrYF2uqb3lDlpfRVnmGs4YCz1THLf7QPS7wzRWVNpNxPuzsws66edDtGHmQ58WNAVFHvPyhtMe3ddVIrdzux3lqE5C9JH3A4vdnpMDZvgHow7ineaKAEKCdSRoJPWvL+piGxzGXnnIJdNTIzg3Og/4Ykkfg6gUQ+5hmcHQYXGlcDeJ+jJpEekD6HDypOxNZP1Z0c1HnXHhFNyCiCLeTIfb+LbjnnNhdGky1SLV9FOj3fGysipbNJwaS2m1Z4PmfP7wVXFEDMoVH4w9IQrurKFRGvyT0Ssl+jeG3XpXfdntTGMPto911zQJw4KUSadcE+J9KP5EMqCu7bUR0mp8A7UxVJvaDXDUhc855ddExtMwqwMQ6mUCyvessBIFicqHl3gQ1AtZwo9fgp0jX7GpeiBtH/ceLzs2amX7FRifc5k3rngAQkrVj+4Eas96hw15UBnnULenVqT2Cs2X6gnUwB18l5X8w1uHLivS8l9 fqI/37/lZmGv5x8BAzUDUyCIr8yZbRopPjdbZ/XeKgJf8w= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(376002)(39860400002)(346002)(366004)(396003)(136003)(8676002)(66946007)(66556008)(450100002)(86362001)(6916009)(31696002)(786003)(83380400001)(316002)(41320700001)(6506007)(53546011)(2616005)(41300700001)(38100700002)(478600001)(6486002)(8936002)(66476007)(2906002)(36756003)(186003)(5660300002)(31686004)(6512007)(75432002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M3RYWXRDemxBQTNzVnV3Mi8wWjFSOFhmY3JiMUQ2dUJGS0VxZ2lWNnNReGpX?= =?utf-8?B?d2tuRXU2dDhFNHlNMms5dm5VdDF5QXVxSEx2UktiWVF1YjRLbXF6NVY1bUVO?= =?utf-8?B?TC9GNnJwSDFLVUJ1MUx0R1puMVNqVGhoK1BWM1RkSGRyM3J1STVWU2pQbER3?= =?utf-8?B?TXFhYmN3NDlRQ3lMajA0WGhHOFplc2t5RmtYbDNvdWFHSytDYmJ0ZkFJL0Nt?= =?utf-8?B?Q2RWY2g2Q0RLYnlJN2VVNGY3VTdqb3c0Zm9pVmFwZEpqS0NBelVUc2wveUlr?= =?utf-8?B?cXhXaVJwV2VhY0pEbjRPS3ZKRTZwbFF4SmNjNkkrWEc1ZnhIQTQ3Y2RscWZw?= =?utf-8?B?VVJkeTVZS2VTUmNOWGhiOEF5SE9HN1ZOQzk3ZENOeGhURVFLQ3BuTHRwd3pV?= =?utf-8?B?SEk0NUtXdzltUkFuV1pHWFNmUENiSFIvM0tyWTUvaGpueXBWYnJiMEwzbkdP?= =?utf-8?B?R3Y3MU5qa3JXRTc3d1FGby8rWGRpaGRzM2R3RHduSjI1S1lTWTRjT2RKb2FW?= =?utf-8?B?T1ErUW13KzBWMmk0VzFPRE04RXVoNGE2SU91aDZKY2JIWjlhOXhlVzNZbWxC?= =?utf-8?B?eXdueEJIc2xHRUxlMm5RNzM3RmN2TFluVUxqcjdBb0dueUpkV3Y3c0lJZVor?= =?utf-8?B?ZVhhTndyejhKTEFEMVYyME9jSlJiV2pVVEhmRD X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: cf4cc893-6d9c-46c5-fef1-08da85ff38ae X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Aug 2022 18:34:04.2212 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: G8x1EoAnosFK5avOlVcx7eTong93tcjYm4nBj9VDz3REQ6bAQCtxI/oQCP49mqhx3VvPnNrjVMrDFQS9ynwd7g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR04MB6210 Received-SPF: pass client-ip=40.107.237.130; envelope-from=kbrown@cornell.edu; helo=NAM12-BN8-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294047 Archived-At: On 8/24/2022 12:20 PM, Eli Zaretskii wrote: > branch: master > commit 95b1eacd4750da7329380aabcb383a8f9d96a59b > Author: Eli Zaretskii > Commit: Eli Zaretskii > > Fix handling of UNCs in 'parse-colon-path > > * lisp/files.el (parse-colon-path): Don't remove the second > leading slash on systems that support UNCs. (Bug#57353) > > * test/lisp/files-tests.el (files-tests-bug-21454): Update > expected results. > (files-colon-path): Add a new test pattern. After this commit I'm getting the following test failure on Cygwin. I don't have time to look into it now, but I can do so in a few days if the fix isn't obvious. Test files-tests-bug-21454 backtrace: signal(ert-test-failed (((should (equal res (parse-colon-path "$FOO" ert-fail(((should (equal res (parse-colon-path "$FOO"))) :form (equa #f(compiled-function () #)() ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name files-tests-bug-21454 :documentation ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :expensive-test) (tag :unstable) (tag :n ert-run-tests-batch((not (or (tag :expensive-test) (tag :unstable) ( ert-run-tests-batch-and-exit((not (or (tag :expensive-test) (tag :un eval((ert-run-tests-batch-and-exit '(not (or (tag :expensive-test) ( command-line-1(("-L" ":../../master/test" "-l" "ert" "-l" "lisp/file command-line() normal-top-level() Test files-tests-bug-21454 condition: (ert-test-failed ((should (equal res (parse-colon-path "$FOO"))) :form (equal ("/foo/bar/" "/bar/qux/" "/qux/foo/") ("//foo/bar/" "/bar/qux/" "/qux/foo/")) :value nil :explanation (list-elt 0 (arrays-of-different-length 9 10 "/foo/bar/" "//foo/bar/" first-mismatch-at 1)))) Ken