From: Nick Roberts <nickrob@snap.net.nz>
Cc: Masatake YAMATO <jet@gyve.org>, emacs-devel@gnu.org
Subject: Re: font-lock in machine mode of gdba
Date: Mon, 18 Oct 2004 15:14:25 +1300 [thread overview]
Message-ID: <16755.9985.12185.122942@farnswood.snap.net.nz> (raw)
In-Reply-To: <877jppnv5n.fsf-monnier+emacs@gnu.org>
Stefan Monnier writes:
> > +(defconst gdb-assembler-font-lock-keywords
> > + '(("\\$?0x*[0-9a-f]+" . font-lock-constant-face)
> > + ("<\\([^+>]+\\)\\+[0-9]+>:"
> > + 1 font-lock-function-name-face)
> > + ("%\\sw+" . font-lock-variable-name-face)
> > + ("^\\(Dump of assembler code for function\\) \\(.+\\):"
> > + (1 font-lock-comment-face)
> > + (2 font-lock-function-name-face))
> > + ("^\\(End of assembler dump\\.\\)" . font-lock-comment-face))
> > + "Font lock keywords used in `gdb-assembler-mode'.")
>
> Seems OK.
>
> > + (unless font-lock-mode (font-lock-mode 1))
>
> This is WRONG. The user should be able to choose whether he wants font-lock
> or not. He does that using either asm-mode-hook or global-font-lock-mode.
asm-mode, asm-mode-font-lock-keywords, etc doesn't work because the
disassembly view differs from that of assembler code (it adds the machine
address at the start of each line, for one thing). Since this buffer is not
editable would font-lock-face be the right thing to use here?
Nick
next prev parent reply other threads:[~2004-10-18 2:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-17 15:29 font-lock in machine mode of gdba Masatake YAMATO
2004-10-17 16:55 ` Stefan Monnier
2004-10-18 2:14 ` Nick Roberts [this message]
2004-10-18 2:25 ` Nick Roberts
2004-10-19 2:26 ` Masatake YAMATO
2004-10-19 12:45 ` Stefan Monnier
2004-10-21 10:53 ` Nick Roberts
2004-10-19 13:28 ` Nick Roberts
2004-10-19 13:54 ` Stefan Monnier
2004-10-19 14:27 ` Masatake YAMATO
2004-10-19 16:38 ` Masatake YAMATO
2004-10-23 22:09 ` Nick Roberts
2004-10-23 23:49 ` Masatake YAMATO
2004-10-23 23:59 ` Nick Roberts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16755.9985.12185.122942@farnswood.snap.net.nz \
--to=nickrob@snap.net.nz \
--cc=emacs-devel@gnu.org \
--cc=jet@gyve.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).