From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Nick Roberts Newsgroups: gmane.emacs.devel Subject: Re: font-lock in machine mode of gdba Date: Mon, 18 Oct 2004 15:14:25 +1300 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: <16755.9985.12185.122942@farnswood.snap.net.nz> References: <20041018.002930.45492341.jet@gyve.org> <877jppnv5n.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1098067115 12614 80.91.229.6 (18 Oct 2004 02:38:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 18 Oct 2004 02:38:35 +0000 (UTC) Cc: Masatake YAMATO , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 18 04:38:30 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CJNPp-0008F4-00 for ; Mon, 18 Oct 2004 04:38:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CJNX6-0005cL-O2 for ged-emacs-devel@m.gmane.org; Sun, 17 Oct 2004 22:46:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CJNWz-0005cD-Ow for emacs-devel@gnu.org; Sun, 17 Oct 2004 22:45:53 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CJNWz-0005c1-B8 for emacs-devel@gnu.org; Sun, 17 Oct 2004 22:45:53 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CJNWz-0005by-82 for emacs-devel@gnu.org; Sun, 17 Oct 2004 22:45:53 -0400 Original-Received: from [199.232.41.8] (helo=mx20.gnu.org) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1CJNPN-0005zH-PH for emacs-devel@gnu.org; Sun, 17 Oct 2004 22:38:01 -0400 Original-Received: from [202.124.110.63] (helo=farnswood.snap.net.nz) by mx20.gnu.org with esmtp (Exim 4.34) id 1CJNIs-0000qV-OA for emacs-devel@gnu.org; Sun, 17 Oct 2004 22:31:19 -0400 Original-Received: by farnswood.snap.net.nz (Postfix, from userid 501) id 96E1262F93; Mon, 18 Oct 2004 03:14:25 +0100 (BST) Original-To: Stefan Monnier In-Reply-To: <877jppnv5n.fsf-monnier+emacs@gnu.org> X-Mailer: VM 6.97 under Emacs 21.2.1 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:28542 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:28542 Stefan Monnier writes: > > +(defconst gdb-assembler-font-lock-keywords > > + '(("\\$?0x*[0-9a-f]+" . font-lock-constant-face) > > + ("<\\([^+>]+\\)\\+[0-9]+>:" > > + 1 font-lock-function-name-face) > > + ("%\\sw+" . font-lock-variable-name-face) > > + ("^\\(Dump of assembler code for function\\) \\(.+\\):" > > + (1 font-lock-comment-face) > > + (2 font-lock-function-name-face)) > > + ("^\\(End of assembler dump\\.\\)" . font-lock-comment-face)) > > + "Font lock keywords used in `gdb-assembler-mode'.") > > Seems OK. > > > + (unless font-lock-mode (font-lock-mode 1)) > > This is WRONG. The user should be able to choose whether he wants font-lock > or not. He does that using either asm-mode-hook or global-font-lock-mode. asm-mode, asm-mode-font-lock-keywords, etc doesn't work because the disassembly view differs from that of assembler code (it adds the machine address at the start of each line, for one thing). Since this buffer is not editable would font-lock-face be the right thing to use here? Nick