From: Konstantin Kharlamov <hi-angel@yandex.ru>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>,
Alex Gramiak <agrambot@gmail.com>,
emacs-devel@gnu.org
Subject: Re: Using __builtin_expect (likely/unlikely macros)
Date: Thu, 18 Apr 2019 11:43:33 +0300 [thread overview]
Message-ID: <1555577013.12550.0@yandex.ru> (raw)
In-Reply-To: <66b74701-012a-902e-4a5b-6bc30efa87c0@cs.ucla.edu>
Thanks. I wonder if "AVOID" macro may sound more clear about its
intended use as "NEVER_RETURN" or "DIE"?
On Чт, Apr 18, 2019 at 01:25, Paul Eggert <eggert@cs.ucla.edu> wrote:
> Konstantin Kharlamov wrote:
>> I was told that e.g. "cold" \x7fattribute can sometimes produce
>> unbearably slow code
>> \x7fLINKIFYbCGIEJcaCfdefadGAGFIHJdfGdGCeJBHBFIbaJBf
>
> Although cold functions can be slow, it appears that overall it's a
> win for Emacs to mark _Noreturn error function declarations as cold:
> on my platform, 'make compile-always' ran about 1.3% faster. So I
> installed the attached patch into master. (Like Stefan, I'm wary of
> marking functions 'hot' so I didn't do that.)
>
> This patch also adds a convenience macro AVOID for the now-common
> pattern '_Noreturn ATTRIBUTE_COLD void'.
next prev parent reply other threads:[~2019-04-18 8:43 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-15 0:15 Using __builtin_expect (likely/unlikely macros) Alex Gramiak
2019-04-15 1:18 ` Paul Eggert
2019-04-15 3:11 ` Alex Gramiak
2019-04-15 4:41 ` Paul Eggert
2019-04-16 0:16 ` Alex Gramiak
2019-04-16 2:34 ` Eli Zaretskii
2019-04-16 5:33 ` Alex Gramiak
2019-04-16 15:23 ` Eli Zaretskii
2019-04-16 15:47 ` Alex Gramiak
2019-04-16 3:42 ` Paul Eggert
2019-04-16 13:05 ` Stefan Monnier
2019-04-16 15:22 ` Paul Eggert
2019-04-16 16:10 ` Alex Gramiak
2019-04-16 17:54 ` Paul Eggert
2019-04-16 20:50 ` Alex Gramiak
2019-04-16 21:11 ` Alex Gramiak
2019-04-16 21:27 ` Stefan Monnier
2019-04-16 21:27 ` Konstantin Kharlamov
2019-04-18 8:25 ` Paul Eggert
2019-04-18 8:43 ` Konstantin Kharlamov [this message]
2019-04-18 13:47 ` Andy Moreton
2019-04-18 17:27 ` Paul Eggert
2019-04-18 17:56 ` Andy Moreton
2019-04-18 19:32 ` Paul Eggert
2019-04-19 13:45 ` Alex Gramiak
2019-04-19 13:58 ` Konstantin Kharlamov
2019-04-19 14:45 ` Alex Gramiak
2019-04-19 17:33 ` Paul Eggert
2019-04-19 20:53 ` Alex Gramiak
2019-04-20 0:05 ` Alan Mackenzie
2019-04-20 0:42 ` Paul Eggert
2019-04-20 19:46 ` Alan Mackenzie
2019-04-20 15:29 ` Andy Moreton
2019-04-20 15:57 ` Paul Eggert
2019-04-20 16:03 ` Eli Zaretskii
2019-04-20 16:11 ` Paul Eggert
2019-04-20 16:18 ` Eli Zaretskii
2019-04-20 16:57 ` Paul Eggert
2019-04-20 17:22 ` Eli Zaretskii
2019-04-20 19:13 ` Paul Eggert
2019-04-20 16:28 ` Óscar Fuentes
2019-04-20 18:58 ` Paul Eggert
2019-04-20 19:35 ` Óscar Fuentes
2019-04-20 22:54 ` Paul Eggert
2020-04-15 3:14 ` John Carter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555577013.12550.0@yandex.ru \
--to=hi-angel@yandex.ru \
--cc=agrambot@gmail.com \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).