* Re: Prefer inline functions in character.h
@ 2020-04-17 17:43 Eli Zaretskii
2020-04-17 22:00 ` Paul Eggert
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2020-04-17 17:43 UTC (permalink / raw)
To: Paul Eggert; +Cc: emacs-devel
These changes break the 32-bit build --with-wide-int:
keymap.c: In function 'Fkey_description':
keymap.c:2067:45: warning: passing argument 2 of 'fetch_string_char_advance' from incompatible pointer type [-Wincompatible-pointer-types]
int c = fetch_string_char_advance (list, &i, &i_byte);
^
In file included from keymap.c:48:0:
character.h:416:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
fetch_string_char_advance (Lisp_Object string,
^~~~~~~~~~~~~~~~~~~~~~~~~
fns.c: In function 'mapcar1':
fns.c:2631:44: warning: passing argument 2 of 'fetch_string_char_advance' from incompatible pointer type [-Wincompatible-pointer-types]
int c = fetch_string_char_advance (seq, &i, &i_byte);
^
In file included from fns.c:32:0:
character.h:416:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
fetch_string_char_advance (Lisp_Object string,
^~~~~~~~~~~~~~~~~~~~~~~~~
syntax.c: In function 'scan_lists':
syntax.c:2676:14: warning: passing argument 1 of 'inc_both' from incompatible pointer type [-Wincompatible-pointer-types]
inc_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1649:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
inc_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2692:18: warning: passing argument 1 of 'inc_both' from incompatible pointer type [-Wincompatible-pointer-types]
inc_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1649:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
inc_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2705:18: warning: passing argument 1 of 'inc_both' from incompatible pointer type [-Wincompatible-pointer-types]
inc_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1649:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
inc_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2721:19: warning: passing argument 1 of 'inc_both' from incompatible pointer type [-Wincompatible-pointer-types]
inc_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1649:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
inc_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2732:15: warning: passing argument 1 of 'inc_both' from incompatible pointer type [-Wincompatible-pointer-types]
inc_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1649:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
inc_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2754:18: warning: passing argument 1 of 'inc_both' from incompatible pointer type [-Wincompatible-pointer-types]
inc_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1649:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
inc_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2763:15: warning: passing argument 1 of 'inc_both' from incompatible pointer type [-Wincompatible-pointer-types]
inc_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1649:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
inc_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2803:17: warning: passing argument 1 of 'inc_both' from incompatible pointer type [-Wincompatible-pointer-types]
inc_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1649:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
inc_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2804:15: warning: passing argument 1 of 'inc_both' from incompatible pointer type [-Wincompatible-pointer-types]
inc_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1649:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
inc_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2807:18: warning: passing argument 1 of 'inc_both' from incompatible pointer type [-Wincompatible-pointer-types]
inc_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1649:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
inc_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2832:14: warning: passing argument 1 of 'dec_both' from incompatible pointer type [-Wincompatible-pointer-types]
dec_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1659:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
dec_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2851:18: warning: passing argument 1 of 'dec_both' from incompatible pointer type [-Wincompatible-pointer-types]
dec_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1659:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
dec_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2865:18: warning: passing argument 1 of 'dec_both' from incompatible pointer type [-Wincompatible-pointer-types]
dec_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1659:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
dec_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2891:19: warning: passing argument 1 of 'dec_both' from incompatible pointer type [-Wincompatible-pointer-types]
dec_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1659:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
dec_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2902:15: warning: passing argument 1 of 'dec_both' from incompatible pointer type [-Wincompatible-pointer-types]
dec_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1659:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
dec_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2915:17: warning: passing argument 1 of 'dec_both' from incompatible pointer type [-Wincompatible-pointer-types]
dec_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1659:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
dec_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2958:15: warning: passing argument 1 of 'dec_both' from incompatible pointer type [-Wincompatible-pointer-types]
dec_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1659:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
dec_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
syntax.c:2977:15: warning: passing argument 1 of 'dec_both' from incompatible pointer type [-Wincompatible-pointer-types]
dec_both (&from, &from_byte);
^
In file included from syntax.c:25:0:
buffer.h:1659:1: note: expected 'ptrdiff_t * {aka int *}' but argument is of type 'EMACS_INT * {aka long long int *}'
dec_both (ptrdiff_t *charpos, ptrdiff_t *bytepos)
^~~~~~~~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Prefer inline functions in character.h
2020-04-17 17:43 Prefer inline functions in character.h Eli Zaretskii
@ 2020-04-17 22:00 ` Paul Eggert
2020-04-18 6:52 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggert @ 2020-04-17 22:00 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
> These changes break the 32-bit build --with-wide-int:
Should be fixed now; the fixes exposed some longstanding --with-wide-int
integer-overflow bugs that I fixed while I was in the neighborhood, so there's
that....
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Prefer inline functions in character.h
2020-04-17 22:00 ` Paul Eggert
@ 2020-04-18 6:52 ` Eli Zaretskii
0 siblings, 0 replies; 3+ messages in thread
From: Eli Zaretskii @ 2020-04-18 6:52 UTC (permalink / raw)
To: Paul Eggert; +Cc: emacs-devel
> Cc: emacs-devel@gnu.org
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Fri, 17 Apr 2020 15:00:48 -0700
>
> > These changes break the 32-bit build --with-wide-int:
>
> Should be fixed now; the fixes exposed some longstanding --with-wide-int
> integer-overflow bugs that I fixed while I was in the neighborhood, so there's
> that....
Thanks, compiles cleanly now.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-18 6:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-17 17:43 Prefer inline functions in character.h Eli Zaretskii
2020-04-17 22:00 ` Paul Eggert
2020-04-18 6:52 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).