unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* How to revert the mode line on master
@ 2021-11-25 12:29 Angelo Graziosi
  2021-11-25 13:15 ` Eli Zaretskii
  2021-11-25 17:09 ` john
  0 siblings, 2 replies; 16+ messages in thread
From: Angelo Graziosi @ 2021-11-25 12:29 UTC (permalink / raw)
  To: emacs-devel

I do not like the new behavior of mode line on master. How to revert?

Thanks



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master
  2021-11-25 12:29 How to revert the mode line on master Angelo Graziosi
@ 2021-11-25 13:15 ` Eli Zaretskii
  2021-11-25 16:31   ` Angelo Graziosi
  2021-11-25 17:09 ` john
  1 sibling, 1 reply; 16+ messages in thread
From: Eli Zaretskii @ 2021-11-25 13:15 UTC (permalink / raw)
  To: Angelo Graziosi; +Cc: emacs-devel

> Date: Thu, 25 Nov 2021 13:29:04 +0100 (CET)
> From: Angelo Graziosi <angelo.g0@libero.it>
> 
> I do not like the new behavior of mode line on master. How to revert?

It's described in NEWS.



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master
  2021-11-25 13:15 ` Eli Zaretskii
@ 2021-11-25 16:31   ` Angelo Graziosi
  2021-11-25 16:37     ` Gregory Heytings
  2021-11-25 16:48     ` Eli Zaretskii
  0 siblings, 2 replies; 16+ messages in thread
From: Angelo Graziosi @ 2021-11-25 16:31 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel


> Il 25/11/2021 14:15 Eli Zaretskii ha scritto:
> 
>  
> > Date: Thu, 25 Nov 2021 13:29:04 +0100 (CET)
> > From: Angelo Graziosi
> > 
> > I do not like the new behavior of mode line on master. How to revert?
> 
> It's described in NEWS.

It seems it only states

"To get the old monospaced mode line back, customize the 'mode-line' face"

but does not say HOW, what to add to the init.el file.



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master
  2021-11-25 16:31   ` Angelo Graziosi
@ 2021-11-25 16:37     ` Gregory Heytings
  2021-11-25 16:50       ` Angelo Graziosi
  2021-11-25 16:48     ` Eli Zaretskii
  1 sibling, 1 reply; 16+ messages in thread
From: Gregory Heytings @ 2021-11-25 16:37 UTC (permalink / raw)
  To: Angelo Graziosi; +Cc: Eli Zaretskii, emacs-devel


>>> I do not like the new behavior of mode line on master. How to revert?
>>
>> It's described in NEWS.
>
> It seems it only states
>
> "To get the old monospaced mode line back, customize the 'mode-line' 
> face"
>
> but does not say HOW, what to add to the init.el file.
>

It does, see the last line:

** The mode line now uses a proportional font by default.
To get the old monospaced mode line back, customize the 'mode-line'
face not to inherit from the 'variable-pitch' face, or add this to
your ~/.emacs:

   (set-face-attribute 'mode-line t :inherit nil)



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master
  2021-11-25 16:31   ` Angelo Graziosi
  2021-11-25 16:37     ` Gregory Heytings
@ 2021-11-25 16:48     ` Eli Zaretskii
  2021-11-25 16:53       ` Angelo Graziosi
  1 sibling, 1 reply; 16+ messages in thread
From: Eli Zaretskii @ 2021-11-25 16:48 UTC (permalink / raw)
  To: Angelo Graziosi; +Cc: emacs-devel

> Date: Thu, 25 Nov 2021 17:31:43 +0100 (CET)
> From: Angelo Graziosi <angelo.g0@libero.it>
> Cc: emacs-devel@gnu.org
> 
> 
> > Il 25/11/2021 14:15 Eli Zaretskii ha scritto:
> > 
> >  
> > > Date: Thu, 25 Nov 2021 13:29:04 +0100 (CET)
> > > From: Angelo Graziosi
> > > 
> > > I do not like the new behavior of mode line on master. How to revert?
> > 
> > It's described in NEWS.
> 
> It seems it only states
> 
> "To get the old monospaced mode line back, customize the 'mode-line' face"
> 
> but does not say HOW, what to add to the init.el file.

Maybe your Git clone is not up-to-date?  That was the original text,
but it got updated yesterday with a specific recipe for the init
files.



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master
  2021-11-25 16:37     ` Gregory Heytings
@ 2021-11-25 16:50       ` Angelo Graziosi
  2021-11-25 17:17         ` How to revert the mode line on master, " Robert Pluim
  2021-11-25 18:19         ` Eli Zaretskii
  0 siblings, 2 replies; 16+ messages in thread
From: Angelo Graziosi @ 2021-11-25 16:50 UTC (permalink / raw)
  To: Gregory Heytings; +Cc: Eli Zaretskii, emacs-devel


> Il 25/11/2021 17:37 Gregory Heytings ha scritto:
> 
>  
> >>> I do not like the new behavior of mode line on master. How to revert?
> >>
> >> It's described in NEWS.
> >
> > It seems it only states
> >
> > "To get the old monospaced mode line back, customize the 'mode-line' 
> > face"
> >
> > but does not say HOW, what to add to the init.el file.
> >
> 
> It does, see the last line:
> 
> ** The mode line now uses a proportional font by default.
> To get the old monospaced mode line back, customize the 'mode-line'
> face not to inherit from the 'variable-pitch' face, or add this to
> your ~/.emacs:
> 
>    (set-face-attribute 'mode-line t :inherit nil)

I added it to my init.el file (copy/pasted) but it does not work: it still is in proportional font (very ugly)...



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master
  2021-11-25 16:48     ` Eli Zaretskii
@ 2021-11-25 16:53       ` Angelo Graziosi
  2021-11-25 17:26         ` Andreas Schwab
  0 siblings, 1 reply; 16+ messages in thread
From: Angelo Graziosi @ 2021-11-25 16:53 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: emacs-devel


> Il 25/11/2021 17:48 Eli Zaretskii <eliz@gnu.org> ha scritto:
> 
>  
> > Date: Thu, 25 Nov 2021 17:31:43 +0100 (CET)
> > From: Angelo Graziosi 
> > Cc: emacs-devel@gnu.org
> > 
> > 
> > > Il 25/11/2021 14:15 Eli Zaretskii ha scritto:
> > > 
> > >  
> > > > Date: Thu, 25 Nov 2021 13:29:04 +0100 (CET)
> > > > From: Angelo Graziosi
> > > > 
> > > > I do not like the new behavior of mode line on master. How to revert?
> > > 
> > > It's described in NEWS.
> > 
> > It seems it only states
> > 
> > "To get the old monospaced mode line back, customize the 'mode-line' face"
> > 
> > but does not say HOW, what to add to the init.el file.
> 
> Maybe your Git clone is not up-to-date?  That was the original text,
> but it got updated yesterday with a specific recipe for the init
> files.

I do not have a local git repo. I was reading it from WEB interface.. Now it is updated but as I wrote in anothe replay, adding

(set-face-attribute 'mode-line t :inherit nil)

to the init.el file does not work. I would say i does nothing.



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master
  2021-11-25 12:29 How to revert the mode line on master Angelo Graziosi
  2021-11-25 13:15 ` Eli Zaretskii
@ 2021-11-25 17:09 ` john
  1 sibling, 0 replies; 16+ messages in thread
From: john @ 2021-11-25 17:09 UTC (permalink / raw)
  To: emacs-devel



On Thu, 25 Nov 2021, Angelo Graziosi wrote:

> I do not like the new behavior of mode line on master. How to revert?
>
> Thanks
>
>

I too dislike the new mode line; in patucular the * to show the buffer as 
been modified was nreadable

I saw the suggesion that there are instructions to revert in  NEWS 
but....

>** The mode line now uses a proportional font by default.
>To get the old monospaced mode line back, customize the 'mode-line'
>face not to inherit from the 'variable-pitch' face, or add this to
>your ~/.emacs:
>
>  (set-face-attribute 'mode-line t :inherit nil)

I tried adding that to my .emacs but nothing changed.  I trid customising 
the mode-line face but failed to see where to do this, not detecting 
anything mentioning variable-pitch.

I rarely customise emacs so do not have much practice so I am lost.  But I 
really want the old mode-line back.  Could someone give blow by blow
instructions please?


==John ff




^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master, Re: How to revert the mode line on master
  2021-11-25 16:50       ` Angelo Graziosi
@ 2021-11-25 17:17         ` Robert Pluim
  2021-11-25 17:53           ` Gregory Heytings
  2021-11-25 18:19         ` Eli Zaretskii
  1 sibling, 1 reply; 16+ messages in thread
From: Robert Pluim @ 2021-11-25 17:17 UTC (permalink / raw)
  To: Angelo Graziosi; +Cc: Gregory Heytings, emacs-devel, Eli Zaretskii, john

>>>>> On Thu, 25 Nov 2021 17:50:33 +0100 (CET), Angelo Graziosi <angelo.g0@libero.it> said:


    Angelo> I added it to my init.el file (copy/pasted) but it does not work: it still is in proportional font (very ugly)...
    >> (set-face-attribute 'mode-line t :inherit nil)

    john> I tried adding that to my .emacs but nothing changed.  I trid
    john> customising the mode-line face but failed to see where to do this, not
    john> detecting anything mentioning variable-pitch.

The mode-line face definition was subtly wrong, it should work better
now if you update your git checkouts and rebuild.

Robert
-- 



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master
  2021-11-25 16:53       ` Angelo Graziosi
@ 2021-11-25 17:26         ` Andreas Schwab
  0 siblings, 0 replies; 16+ messages in thread
From: Andreas Schwab @ 2021-11-25 17:26 UTC (permalink / raw)
  To: Angelo Graziosi; +Cc: Eli Zaretskii, emacs-devel

On Nov 25 2021, Angelo Graziosi wrote:

> I do not have a local git repo. I was reading it from WEB interface.. Now it is updated but as I wrote in anothe replay, adding
>
> (set-face-attribute 'mode-line t :inherit nil)
>
> to the init.el file does not work. I would say i does nothing.

You need to use nil instead of t to apply it to existing frames as well.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master, Re: How to revert the mode line on master
  2021-11-25 17:17         ` How to revert the mode line on master, " Robert Pluim
@ 2021-11-25 17:53           ` Gregory Heytings
  2021-11-25 18:06             ` Angelo Graziosi
  2021-11-25 18:13             ` Angelo Graziosi
  0 siblings, 2 replies; 16+ messages in thread
From: Gregory Heytings @ 2021-11-25 17:53 UTC (permalink / raw)
  To: Robert Pluim; +Cc: Eli Zaretskii, john, Angelo Graziosi, emacs-devel


>
> The mode-line face definition was subtly wrong, it should work better 
> now if you update your git checkouts and rebuild.
>

Alas, it doesn't.  Angelo is right, the recipe doesn't work, neither 
before nor after your fix.  An init file with just (set-face-attribute 
'mode-line nil :inherit nil) has no effect on the mode-line of the first 
frame.  (require 'faces) or (with-eval-after-load "faces" ...) do not 
help.  The shortest actually working recipe I found is:

(set-face-attribute 'default nil :foreground (face-attribute 'default :foreground))
(set-face-attribute 'mode-line nil :inherit nil)



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master, Re: How to revert the mode line on master
  2021-11-25 17:53           ` Gregory Heytings
@ 2021-11-25 18:06             ` Angelo Graziosi
  2021-11-25 18:13             ` Angelo Graziosi
  1 sibling, 0 replies; 16+ messages in thread
From: Angelo Graziosi @ 2021-11-25 18:06 UTC (permalink / raw)
  To: Gregory Heytings, Robert Pluim; +Cc: emacs-devel, Eli Zaretskii, john


> Il 25/11/2021 18:53 Gregory Heytings  ha scritto:
> 
>  
> >
> > The mode-line face definition was subtly wrong, it should work better 
> > now if you update your git checkouts and rebuild.
> >
> 
> Alas, it doesn't.  Angelo is right, the recipe doesn't work, neither 
> before nor after your fix.  An init file with just (set-face-attribute 
> 'mode-line nil :inherit nil) has no effect on the mode-line of the first 
> frame.  (require 'faces) or (with-eval-after-load "faces" ...) do not 
> help.  The shortest actually working recipe I found is:
> 
> (set-face-attribute 'default nil :foreground (face-attribute 'default :foreground))
> (set-face-attribute 'mode-line nil :inherit nil)

I just tried the new git repo but i does not work: the mode-line is still in proportional font...



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master, Re: How to revert the mode line on master
  2021-11-25 17:53           ` Gregory Heytings
  2021-11-25 18:06             ` Angelo Graziosi
@ 2021-11-25 18:13             ` Angelo Graziosi
  1 sibling, 0 replies; 16+ messages in thread
From: Angelo Graziosi @ 2021-11-25 18:13 UTC (permalink / raw)
  To: Gregory Heytings, Robert Pluim; +Cc: emacs-devel, Eli Zaretskii, john


> Il 25/11/2021 18:53 Gregory Heytings ha scritto:
> 
> The shortest actually working recipe I found is:
> 
> (set-face-attribute 'default nil :foreground (face-attribute 'default :foreground))
> (set-face-attribute 'mode-line nil :inherit nil)

Yes, this works!

BTW, I understand your work about this. I wonder if mode-line is the place where to add it. My opinion is that mode-line has elements which should not proportional and would be better to leave it as it stands.



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master
  2021-11-25 16:50       ` Angelo Graziosi
  2021-11-25 17:17         ` How to revert the mode line on master, " Robert Pluim
@ 2021-11-25 18:19         ` Eli Zaretskii
  2021-11-25 18:33           ` Angelo Graziosi
  2021-11-30 22:58           ` Angelo Graziosi
  1 sibling, 2 replies; 16+ messages in thread
From: Eli Zaretskii @ 2021-11-25 18:19 UTC (permalink / raw)
  To: Angelo Graziosi; +Cc: gregory, emacs-devel

> Date: Thu, 25 Nov 2021 17:50:33 +0100 (CET)
> From: Angelo Graziosi <angelo.g0@libero.it>
> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
> 
> >    (set-face-attribute 'mode-line t :inherit nil)
> 
> I added it to my init.el file (copy/pasted) but it does not work: it still is in proportional font (very ugly)...

Please try this instead:

  (set-face-attribute 'mode-line nil :inherit 'default)



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master
  2021-11-25 18:19         ` Eli Zaretskii
@ 2021-11-25 18:33           ` Angelo Graziosi
  2021-11-30 22:58           ` Angelo Graziosi
  1 sibling, 0 replies; 16+ messages in thread
From: Angelo Graziosi @ 2021-11-25 18:33 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: gregory, emacs-devel


> Il 25/11/2021 19:19 Eli Zaretskii ha scritto:
> 
>  
> > Date: Thu, 25 Nov 2021 17:50:33 +0100 (CET)
> > From: Angelo Graziosi 
> > Cc: Eli Zaretskii 
> > 
> > >    (set-face-attribute 'mode-line t :inherit nil)
> > 
> > I added it to my init.el file (copy/pasted) but it does not work: it still is in proportional font (very ugly)...
> 
> Please try this instead:
> 
>   (set-face-attribute 'mode-line nil :inherit 'default)

Yes, just adding that works. Thanks.



^ permalink raw reply	[flat|nested] 16+ messages in thread

* Re: How to revert the mode line on master
  2021-11-25 18:19         ` Eli Zaretskii
  2021-11-25 18:33           ` Angelo Graziosi
@ 2021-11-30 22:58           ` Angelo Graziosi
  1 sibling, 0 replies; 16+ messages in thread
From: Angelo Graziosi @ 2021-11-30 22:58 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: gregory, emacs-devel

For the sake of completeness.

> Il 25/11/2021 19:19 Eli Zaretskii ha scritto:
> 
>  
> > Date: Thu, 25 Nov 2021 17:50:33 +0100 (CET)
> > From: Angelo Graziosi 
> > Cc: Eli Zaretskii 
> > 
> > >    (set-face-attribute 'mode-line t :inherit nil)
> > 
> > I added it to my init.el file (copy/pasted) but it does not work: it still is in proportional font (very ugly)...
> 
> Please try this instead:
> 
>   (set-face-attribute 'mode-line nil :inherit 'default)

the issue occurs mainly on Windows and macOS builds. On Windows the font is JetBrains Mono while on macOS it is Monaco. On GNU/Linux Mint it is Monospace font and there mode line looks good also with proportional font. At the end, I think  it is the font type that causes this...



^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2021-11-30 22:58 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-25 12:29 How to revert the mode line on master Angelo Graziosi
2021-11-25 13:15 ` Eli Zaretskii
2021-11-25 16:31   ` Angelo Graziosi
2021-11-25 16:37     ` Gregory Heytings
2021-11-25 16:50       ` Angelo Graziosi
2021-11-25 17:17         ` How to revert the mode line on master, " Robert Pluim
2021-11-25 17:53           ` Gregory Heytings
2021-11-25 18:06             ` Angelo Graziosi
2021-11-25 18:13             ` Angelo Graziosi
2021-11-25 18:19         ` Eli Zaretskii
2021-11-25 18:33           ` Angelo Graziosi
2021-11-30 22:58           ` Angelo Graziosi
2021-11-25 16:48     ` Eli Zaretskii
2021-11-25 16:53       ` Angelo Graziosi
2021-11-25 17:26         ` Andreas Schwab
2021-11-25 17:09 ` john

Code repositories for project(s) associated with this inbox:

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).