Next Emacs RC tomorrow?

Next Emacs RC tomorrow?

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 165 bytes --]

Hi guys,

I plan to release the second RC tomorrow.  I'm not aware of anything
pending, but maybe I missed something and should wait a few more days?

Cheers,
Nico


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

Re: Next Emacs RC tomorrow?

[psachin]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

Go for it..awaiting to test!

On Tue, Aug 9, 2016 at 8:49 PM, Nicolas Petton <nicolas@petton.fr> wrote:

> Hi guys,
>
> I plan to release the second RC tomorrow.  I'm not aware of anything
> pending, but maybe I missed something and should wait a few more days?
>
> Cheers,
> Nico
>
>


-- 
Sachin
psachin.github.io

[-- Attachment #2: Type: text/html, Size: 920 bytes --]

Re: Next Emacs RC tomorrow?

[Marius Kjeldahl]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

Yes, go ahead, should be good. I've built and tested from master/trunk on
two macOS 10.12 systems already and everything has been rock solid since
the IPC messaging patch (or whatever it can/should be called).

On Tue, 9 Aug 2016 at 17:27 psachin <iclcoolster@gmail.com> wrote:

> Go for it..awaiting to test!
>
> On Tue, Aug 9, 2016 at 8:49 PM, Nicolas Petton <nicolas@petton.fr> wrote:
>
>> Hi guys,
>>
>> I plan to release the second RC tomorrow.  I'm not aware of anything
>> pending, but maybe I missed something and should wait a few more days?
>>
>> Cheers,
>> Nico
>>
>>
>
>
> --
> Sachin
> psachin.github.io
>

[-- Attachment #2: Type: text/html, Size: 1482 bytes --]

Re: Next Emacs RC tomorrow?

[Dmitry Gutov]

Hi!

On 08/09/2016 06:19 PM, Nicolas Petton wrote:

> I plan to release the second RC tomorrow.  I'm not aware of anything
> pending, but maybe I missed something and should wait a few more days?

I think we should fix bug#24117 first. It's not marked as a blocker 
(Eli?), but clearly seems to be one.

Re: Next Emacs RC tomorrow?

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 204 bytes --]

Dmitry Gutov <dgutov@yandex.ru> writes:

> I think we should fix bug#24117 first. It's not marked as a blocker 
> (Eli?), but clearly seems to be one.

Sure, I can wait. John, Eli?

Cheers,
Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

Re: Next Emacs RC tomorrow?

[Eli Zaretskii]

> Cc: Eli Zaretskii <eliz@gnu.org>
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Wed, 10 Aug 2016 09:27:40 +0300
> 
> On 08/09/2016 06:19 PM, Nicolas Petton wrote:
> 
> > I plan to release the second RC tomorrow.  I'm not aware of anything
> > pending, but maybe I missed something and should wait a few more days?
> 
> I think we should fix bug#24117 first. It's not marked as a blocker 
> (Eli?), but clearly seems to be one.

I'd like to, but it doesn't sound like we have a consensus about the
way to fix it.

Would it work to make the buffer unibyte _after_ inserting the URL?
Does anyone of those who objected to making it unibyte to begin with
object to this proposal?

Re: Next Emacs RC tomorrow?

[Stefan Monnier]

>> I plan to release the second RC tomorrow.  I'm not aware of anything
>> pending, but maybe I missed something and should wait a few more days?
> I think we should fix bug#24117 first. It's not marked as a blocker (Eli?),
> but clearly seems to be one.

AFAIK this bug has been with us for a long time and the fix (whichever
is chosen) is likely to introduce breakage at other places, so I don't
think it deserves to delay the release.


        Stefan

Re: Next Emacs RC tomorrow?

[Dmitry Gutov]

On 08/10/2016 05:29 PM, Stefan Monnier wrote:

> AFAIK this bug has been with us for a long time and the fix (whichever
> is chosen) is likely to introduce breakage at other places, so I don't
> think it deserves to delay the release.

No, this bug by itself a regression from a recent fix. And it makes HTTP 
requests with multibyte body impossible.

At the very least, we'll have to revert the commit that caused it. With 
the unfortunate consequences the previous bug entailed.

Re: Next Emacs RC tomorrow?

[Dmitry Gutov]

On 08/10/2016 05:28 PM, Eli Zaretskii wrote:

> I'd like to, but it doesn't sound like we have a consensus about the
> way to fix it.
>
> Would it work to make the buffer unibyte _after_ inserting the URL?
> Does anyone of those who objected to making it unibyte to begin with
> object to this proposal?

Which buffer do you mean?

Please take a look at my last two messages in that bug, by the way.

Re: Next Emacs RC tomorrow?

[Eli Zaretskii]

> From: Nicolas Petton <nicolas@petton.fr>
> Date: Wed, 10 Aug 2016 15:49:08 +0200
> Cc: Eli Zaretskii <eliz@gnu.org>, johnw@gnu.org
> 
> > I think we should fix bug#24117 first. It's not marked as a blocker 
> > (Eli?), but clearly seems to be one.
> 
> Sure, I can wait. John, Eli?

Let's see what happens in the discussions of that bug in the next 24
hours.

Re: Next Emacs RC tomorrow?

[Eli Zaretskii]

> Cc: nicolas@petton.fr, emacs-devel@gnu.org
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Wed, 10 Aug 2016 17:36:27 +0300
> 
> > Would it work to make the buffer unibyte _after_ inserting the URL?
> > Does anyone of those who objected to making it unibyte to begin with
> > object to this proposal?
> 
> Which buffer do you mean?

The one used by url-generic-parse-url.

> Please take a look at my last two messages in that bug, by the way.

Done.

Re: Next Emacs RC tomorrow?

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 125 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

> Let's see what happens in the discussions of that bug in the next 24
> hours.

Sure.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

Re: Next Emacs RC tomorrow?

[Stefan Monnier]

>> AFAIK this bug has been with us for a long time and the fix (whichever
>> is chosen) is likely to introduce breakage at other places, so I don't
>> think it deserves to delay the release.
> No, this bug by itself a regression from a recent fix. And it makes HTTP
> requests with multibyte body impossible.
> At the very least, we'll have to revert the commit that caused it. With the
> unfortunate consequences the previous bug entailed.

I'm sorry, then: I confused this bug with the previous one.


        Stefan

Re: Next Emacs RC tomorrow?

[John Wiegley]

>>>>> Nicolas Petton <nicolas@petton.fr> writes:

> Sure, I can wait. John, Eli?

It's been 24 hours, so cut when ready if that issue is not blocking.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Re: Next Emacs RC tomorrow?

[Eli Zaretskii]

> From: John Wiegley <jwiegley@gmail.com>
> Cc: Dmitry Gutov <dgutov@yandex.ru>,  emacs-devel <emacs-devel@gnu.org>,  Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 11 Aug 2016 10:34:45 -0700
> 
> >>>>> Nicolas Petton <nicolas@petton.fr> writes:
> 
> > Sure, I can wait. John, Eli?
> 
> It's been 24 hours, so cut when ready if that issue is not blocking.

The bug we were talking about was fixed, so the issue doesn't exist.

Re: Next Emacs RC tomorrow?

[Nicolas Petton]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

Eli Zaretskii <eliz@gnu.org> writes:

>> It's been 24 hours, so cut when ready if that issue is not blocking.
>
> The bug we were talking about was fixed, so the issue doesn't exist.

Ok, I'll do it tomorrow then.

Cheers,
Nico

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 512 bytes --]

Re: Next Emacs RC tomorrow?

[Stefan Monnier]

>> At the very least, we'll have to revert the commit that caused it. With the
>> unfortunate consequences the previous bug entailed.
> I'm sorry, then: I confused this bug with the previous one.

And I think it would indeed make sense to revert the patch (and hence
re-introduce the previous bug, which was a fairly long-standing bug).


        Stefan

Re: Next Emacs RC tomorrow?

[Stefan Monnier]

> The bug we were talking about was fixed, so the issue doesn't exist.

Great, thanks, and please ignore my latest email.


        Stefan


PS: Why do I feel like an idiot?

Re: Next Emacs RC tomorrow?

[Dmitry Gutov]

On 08/11/2016 11:36 PM, Stefan Monnier wrote:

> And I think it would indeed make sense to revert the patch (and hence
> re-introduce the previous bug, which was a fairly long-standing bug).

That would be the conservative choice, yes, and we'll do that if any new 
regressions come up.

The long-standing bug, though, has become more problematic in Emacs 25, 
because json-encode-string doesn't escape characters it doesn't have to 
anymore (including most multibyte characters).

Re: Next Emacs RC tomorrow?

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Date: Thu, 11 Aug 2016 16:37:37 -0400
> 
> > The bug we were talking about was fixed, so the issue doesn't exist.
> 
> Great, thanks, and please ignore my latest email.

Done.

> PS: Why do I feel like an idiot?

I don't know, you shouldn't.