unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Re: master ef732bd2083: ; * lisp/progmodes/project.el (project-any-command): Fix last change
       [not found] ` <20231208223728.B5347C0C6AB@vcs2.savannah.gnu.org>
@ 2023-12-10  2:59   ` Dmitry Gutov
  2023-12-10 16:00     ` Sean Whitton
  0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Gutov @ 2023-12-10  2:59 UTC (permalink / raw)
  To: emacs-devel, Sean Whitton

On 09/12/2023 00:37, Sean Whitton wrote:
> branch: master
> commit ef732bd2083c5f28c37dc52a6f96923eed2f5aa8
> Author: Sean Whitton<spwhitton@spwhitton.name>
> Commit: Sean Whitton<spwhitton@spwhitton.name>
> 
>      ; * lisp/progmodes/project.el (project-any-command): Fix last change
> ---
>   lisp/progmodes/project.el | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index 7789243cb00..cc473a12baf 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -1862,7 +1862,7 @@ which will take priority over the global ones."
>       (when command
>         (if (when (symbolp command)
>               (or (string-prefix-p "project-" (symbol-name command))
> -                (get command 'project-command)))
> +                (get command 'project-related)))
>             (let ((project-current-directory-override root))
>               (call-interactively command))
>           (let ((default-directory root))

It was definitely a typo somewhere, though maybe in the docstring.

Speaking of names, perhaps the property name 'project-aware' might suit 
the situation better than either of the above options.



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: master ef732bd2083: ; * lisp/progmodes/project.el (project-any-command): Fix last change
  2023-12-10  2:59   ` master ef732bd2083: ; * lisp/progmodes/project.el (project-any-command): Fix last change Dmitry Gutov
@ 2023-12-10 16:00     ` Sean Whitton
  2023-12-11  1:39       ` Dmitry Gutov
  0 siblings, 1 reply; 3+ messages in thread
From: Sean Whitton @ 2023-12-10 16:00 UTC (permalink / raw)
  To: Dmitry Gutov; +Cc: emacs-devel

Hello,

On Sun 10 Dec 2023 at 04:59am +02, Dmitry Gutov wrote:

> On 09/12/2023 00:37, Sean Whitton wrote:
>> branch: master
>> commit ef732bd2083c5f28c37dc52a6f96923eed2f5aa8
>> Author: Sean Whitton<spwhitton@spwhitton.name>
>> Commit: Sean Whitton<spwhitton@spwhitton.name>
>>      ; * lisp/progmodes/project.el (project-any-command): Fix last change
>> ---
>>   lisp/progmodes/project.el | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
>> index 7789243cb00..cc473a12baf 100644
>> --- a/lisp/progmodes/project.el
>> +++ b/lisp/progmodes/project.el
>> @@ -1862,7 +1862,7 @@ which will take priority over the global ones."
>>       (when command
>>         (if (when (symbolp command)
>>               (or (string-prefix-p "project-" (symbol-name command))
>> -                (get command 'project-command)))
>> +                (get command 'project-related)))
>>             (let ((project-current-directory-override root))
>>               (call-interactively command))
>>           (let ((default-directory root))
>
> It was definitely a typo somewhere, though maybe in the docstring.
>
> Speaking of names, perhaps the property name 'project-aware' might suit the
> situation better than either of the above options.

Makes sense to me.

-- 
Sean Whitton



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: master ef732bd2083: ; * lisp/progmodes/project.el (project-any-command): Fix last change
  2023-12-10 16:00     ` Sean Whitton
@ 2023-12-11  1:39       ` Dmitry Gutov
  0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Gutov @ 2023-12-11  1:39 UTC (permalink / raw)
  To: Sean Whitton; +Cc: emacs-devel

On 10/12/2023 18:00, Sean Whitton wrote:
>> Speaking of names, perhaps the property name 'project-aware' might suit the
>> situation better than either of the above options.
> Makes sense to me.

Great, updated.



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-12-11  1:39 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <170207504844.3728.8521907427206698810@vcs2.savannah.gnu.org>
     [not found] ` <20231208223728.B5347C0C6AB@vcs2.savannah.gnu.org>
2023-12-10  2:59   ` master ef732bd2083: ; * lisp/progmodes/project.el (project-any-command): Fix last change Dmitry Gutov
2023-12-10 16:00     ` Sean Whitton
2023-12-11  1:39       ` Dmitry Gutov

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).