Re: How does nativecomp compile circular lists?

[Jimmy Yuen Ho Wong <wyuenho@gmail.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1048 bytes --]

On 30/07/2021 9:20 AM, Andrea Corallo wrote:
> Jimmy Yuen Ho Wong <wyuenho@gmail.com> writes:
>> Here's a new patch. Thanks in advance for installing it.
>>
>> diff --git a/lisp/emacs-lisp/disass.el b/lisp/emacs-lisp/disass.el
>> index 6ac76f1c19..bb2e4849ad 100644
>> --- a/lisp/emacs-lisp/disass.el
>> +++ b/lisp/emacs-lisp/disass.el
>> @@ -95,6 +95,7 @@ disassemble-internal
>>                 (re-search-forward (concat "^.*"
>>                                            (regexp-quote
>>                                             (concat "<"
>> +                                                  (when (eq system-type 'darwin) "_")
>>                                                     (comp-c-func-name
>>                                                      (subr-name obj) "F" t)
>>                                                     ">:"))))
> Hi Jimmy,
>
> as mentioned please write a Changelog entry (see the CONTRIBUTE file).
>
> TIA
>
>    Andrea
>    

Here's a new patch with a Changelog commit message. Thanks.

-- 
Jimmy Wong


[-- Attachment #1.2: Type: text/html, Size: 1620 bytes --]

[-- Attachment #2: 0001-Fix-error-while-disassembling-native-code-on-macOS.patch --]
[-- Type: text/plain, Size: 1112 bytes --]

From 2d1fbfc87b87e2726252e05db6f27177c6965b09 Mon Sep 17 00:00:00 2001
From: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
Date: Tue, 3 Aug 2021 08:14:38 +0100
Subject: [PATCH] Fix error while disassembling native code on macOS

* lisp/emacs-lisp/disass.el (disassemble-internal): Make sure the
regexp that searches for a symbol takes into account of llvm-objdump's
output format.
---
 lisp/emacs-lisp/disass.el | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lisp/emacs-lisp/disass.el b/lisp/emacs-lisp/disass.el
index 6ac76f1c19..bb2e4849ad 100644
--- a/lisp/emacs-lisp/disass.el
+++ b/lisp/emacs-lisp/disass.el
@@ -95,6 +95,7 @@ disassemble-internal
               (re-search-forward (concat "^.*"
                                          (regexp-quote
                                           (concat "<"
+                                                  (when (eq system-type 'darwin) "_")
                                                   (comp-c-func-name
                                                    (subr-name obj) "F" t)
                                                   ">:"))))
-- 
2.32.0