From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jimmy Yuen Ho Wong Newsgroups: gmane.emacs.devel Subject: Re: How does nativecomp compile circular lists? Date: Tue, 3 Aug 2021 08:23:25 +0100 Message-ID: <07d2e975-95e9-009e-0361-3dbcd907dbc5@gmail.com> References: <6247f78b-282f-27e7-e0cf-6bc3b1cdee26@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------F2C8264FC64233B080E32B0F" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22922"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 Cc: Emacs-Devel devel To: Andrea Corallo Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 03 09:24:08 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mAomW-0005nd-EH for ged-emacs-devel@m.gmane-mx.org; Tue, 03 Aug 2021 09:24:08 +0200 Original-Received: from localhost ([::1]:36156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAomU-0006WQ-S0 for ged-emacs-devel@m.gmane-mx.org; Tue, 03 Aug 2021 03:24:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAolx-0005q4-6L for emacs-devel@gnu.org; Tue, 03 Aug 2021 03:23:33 -0400 Original-Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:33564) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mAolu-0001gZ-Pb for emacs-devel@gnu.org; Tue, 03 Aug 2021 03:23:32 -0400 Original-Received: by mail-wr1-x436.google.com with SMTP id k4so13316938wrc.0 for ; Tue, 03 Aug 2021 00:23:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=1+eJwQ/3TtQ0vpftPlpj06MOwTlVECi/VasEIYIpLuA=; b=mPRVRxNyRBAl3wM2IX7/L320SsZeV++Jx28ra2O4iNK4JpvIoU5cn/QRUOCe+q94Qo VhX2q7IkKkKQ0svf6J5YZ8mVRSbl8seZh1te6cj4UYsL24ZyZ3M2ioRDkMtHFeSEhlkC PX9KaU4cqTb9QBPG6Xdxi4GwzuFkhv9JAKn/mtcYJvRFTyVzSZPTAiajWJNbP6TUdKqE PfQY+Jpp01TawtNUBIFJSnsBJP2fm6U7a5CySGfQa/4uwUnYun/0lfsgYRRCw/kA7dz0 KpqhyAU9sjTWJAWrf0IAqNS0AosXbULxYUbHKBxN56T4y2ZZFE+0TzNTRSD1L9pr9eyg G3lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=1+eJwQ/3TtQ0vpftPlpj06MOwTlVECi/VasEIYIpLuA=; b=QLnBVwg7yUVeq8xRr5M4K9miDD89BTVnTxpUDyOw00UQ+6beLkgfz3LrK1fJzgid00 ZSvZ2RlalJIGV4GxuCdgQ5U8KO0b28mCd4qejS8bhlUsSJNmnSWBdE+mvkKXH7PVcjX6 6a+Wl0j1F/U7xNVmQ1be+bRL+x2NfuIC1DY8qc4ZWsbzrbzy4x5x9EcnZfSbCV0pZT1Q RXCn6qL2CyN1xohtJBSTn2/6zOTsjsyzvf6LPnTf3T1W16AzOmG91NND0dq5RBr7yEby JOTs+GYdekhejBrehlGVgeSOVx5WxjeV5Dy/Qlq0dUNZGswa4AF4IPB/mfK4lCw79EXa w1Vw== X-Gm-Message-State: AOAM5330RfOq4DZ7sbfeL0zUIRyN1TL/h8M2AK22+yUs++CCfffnKOTF Uq7mHmSfrmD76GWyVPeT1W8liEw33/k= X-Google-Smtp-Source: ABdhPJzDFgi19MUi4yfie3e2k/jOx0w3EBagfhh97bWOLe104VWf6iIJ0w1xAWh+IbQaJWa2nxny5A== X-Received: by 2002:adf:e6cf:: with SMTP id y15mr21030522wrm.217.1627975407705; Tue, 03 Aug 2021 00:23:27 -0700 (PDT) Original-Received: from MobileCat.local ([137.220.76.130]) by smtp.gmail.com with ESMTPSA id h25sm1579178wmp.33.2021.08.03.00.23.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Aug 2021 00:23:26 -0700 (PDT) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=wyuenho@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:271952 Archived-At: This is a multi-part message in MIME format. --------------F2C8264FC64233B080E32B0F Content-Type: multipart/alternative; boundary="------------8FEA207F5F77EB332B7A8036" --------------8FEA207F5F77EB332B7A8036 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 30/07/2021 9:20 AM, Andrea Corallo wrote: > Jimmy Yuen Ho Wong writes: >> Here's a new patch. Thanks in advance for installing it. >> >> diff --git a/lisp/emacs-lisp/disass.el b/lisp/emacs-lisp/disass.el >> index 6ac76f1c19..bb2e4849ad 100644 >> --- a/lisp/emacs-lisp/disass.el >> +++ b/lisp/emacs-lisp/disass.el >> @@ -95,6 +95,7 @@ disassemble-internal >> (re-search-forward (concat "^.*" >> (regexp-quote >> (concat "<" >> + (when (eq system-type 'darwin) "_") >> (comp-c-func-name >> (subr-name obj) "F" t) >> ">:")))) > Hi Jimmy, > > as mentioned please write a Changelog entry (see the CONTRIBUTE file). > > TIA > > Andrea > Here's a new patch with a Changelog commit message. Thanks. -- Jimmy Wong --------------8FEA207F5F77EB332B7A8036 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit
On 30/07/2021 9:20 AM, Andrea Corallo wrote:
Jimmy Yuen Ho Wong <wyuenho@gmail.com> writes:

Here's a new patch. Thanks in advance for installing it.

diff --git a/lisp/emacs-lisp/disass.el b/lisp/emacs-lisp/disass.el
index 6ac76f1c19..bb2e4849ad 100644
--- a/lisp/emacs-lisp/disass.el
+++ b/lisp/emacs-lisp/disass.el
@@ -95,6 +95,7 @@ disassemble-internal
               (re-search-forward (concat "^.*"
                                          (regexp-quote
                                           (concat "<"
+                                                  (when (eq system-type 'darwin) "_")
                                                   (comp-c-func-name
                                                    (subr-name obj) "F" t)
                                                   ">:"))))

Hi Jimmy,

as mentioned please write a Changelog entry (see the CONTRIBUTE file).

TIA

  Andrea

Here's a new patch with a Changelog commit message. Thanks.

-- 
Jimmy Wong
--------------8FEA207F5F77EB332B7A8036-- --------------F2C8264FC64233B080E32B0F Content-Type: text/plain; charset=UTF-8; x-mac-type="0"; x-mac-creator="0"; name="0001-Fix-error-while-disassembling-native-code-on-macOS.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Fix-error-while-disassembling-native-code-on-macOS.patc"; filename*1="h" RnJvbSAyZDFmYmZjODdiODdlMjcyNjI1MmUwNWRiNmYyNzE3N2M2OTY1YjA5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW1teSBZdWVuIEhvIFdvbmcgPHd5dWVuaG9AZ21h aWwuY29tPgpEYXRlOiBUdWUsIDMgQXVnIDIwMjEgMDg6MTQ6MzggKzAxMDAKU3ViamVjdDog W1BBVENIXSBGaXggZXJyb3Igd2hpbGUgZGlzYXNzZW1ibGluZyBuYXRpdmUgY29kZSBvbiBt YWNPUwoKKiBsaXNwL2VtYWNzLWxpc3AvZGlzYXNzLmVsIChkaXNhc3NlbWJsZS1pbnRlcm5h bCk6IE1ha2Ugc3VyZSB0aGUKcmVnZXhwIHRoYXQgc2VhcmNoZXMgZm9yIGEgc3ltYm9sIHRh a2VzIGludG8gYWNjb3VudCBvZiBsbHZtLW9iamR1bXAncwpvdXRwdXQgZm9ybWF0LgotLS0K IGxpc3AvZW1hY3MtbGlzcC9kaXNhc3MuZWwgfCAxICsKIDEgZmlsZSBjaGFuZ2VkLCAxIGlu c2VydGlvbigrKQoKZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9kaXNhc3MuZWwgYi9s aXNwL2VtYWNzLWxpc3AvZGlzYXNzLmVsCmluZGV4IDZhYzc2ZjFjMTkuLmJiMmU0ODQ5YWQg MTAwNjQ0Ci0tLSBhL2xpc3AvZW1hY3MtbGlzcC9kaXNhc3MuZWwKKysrIGIvbGlzcC9lbWFj cy1saXNwL2Rpc2Fzcy5lbApAQCAtOTUsNiArOTUsNyBAQCBkaXNhc3NlbWJsZS1pbnRlcm5h bAogICAgICAgICAgICAgICAocmUtc2VhcmNoLWZvcndhcmQgKGNvbmNhdCAiXi4qIgogICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAocmVnZXhwLXF1b3RlCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY29uY2F0ICI8Igor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAod2hl biAoZXEgc3lzdGVtLXR5cGUgJ2RhcndpbikgIl8iKQogICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoY29tcC1jLWZ1bmMtbmFtZQogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN1YnItbmFt ZSBvYmopICJGIiB0KQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAiPjoiKSkpKQotLSAKMi4zMi4wCgo= --------------F2C8264FC64233B080E32B0F--