Re: GnuTLS/TLS proposals for after the release

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 532 bytes --]

On 07/20/2016 03:14 PM, Ted Zlatanov wrote:
> SM> Another step in the same direction is to make ./configure fail if
> SM> libgnutls is not found.
>
> That's a one-line change IIRC, so it just needs the OK from John or Eli
> (since it's a pretty major change).

It's not that big a deal to treat libgnutls like other key libraries. 
Namely, 'configure' fails if the library is missing, unless you 
specifically say you don't want the library by configuring with the 
--with-gnutls=no option. Something like the attached patch, say.


[-- Attachment #2: 0001-Require-libgnutls-unless-with-gnutls-no.patch --]
[-- Type: text/x-patch, Size: 1677 bytes --]

From 5f508198cd31afd08c3a50af6c7fb38ed65992cc Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 20 Jul 2016 16:18:34 +0200
Subject: [PATCH] Require libgnutls unless --with-gnutls=no

* configure.ac: Report an error if the gnutls library is missing,
unless --with-gnutls=no is specified.
---
 configure.ac | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/configure.ac b/configure.ac
index c94ecb6..cca555c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -3568,9 +3568,9 @@ AC_DEFUN
 AC_SUBST(LIBGIF)
 
 dnl Check for required libraries.
+MISSING=
+WITH_NO=
 if test "${HAVE_X11}" = "yes"; then
-  MISSING=""
-  WITH_NO=""
   test "${with_xpm}" != "no" && test "${HAVE_XPM}" != "yes" &&
     MISSING="libXpm" && WITH_NO="--with-xpm=no"
   test "${with_jpeg}" != "no" && test "${HAVE_JPEG}" != "yes" &&
@@ -3581,15 +3581,16 @@ AC_DEFUN
     MISSING="$MISSING libgif/libungif" && WITH_NO="$WITH_NO --with-gif=no"
   test "${with_tiff}" != "no" && test "${HAVE_TIFF}" != "yes" &&
     MISSING="$MISSING libtiff" && WITH_NO="$WITH_NO --with-tiff=no"
-
-  if test "X${MISSING}" != X; then
-    AC_MSG_ERROR([The following required libraries were not found:
+fi
+test "${with_gnutls}" != "no" && test "${HAVE_GNUTLS}" != "yes" &&
+  MISSING="$MISSING gnutls" && WITH_NO="$WITH_NO --with-gnutls=no"
+if test "X${MISSING}" != X; then
+  AC_MSG_ERROR([The following required libraries were not found:
     $MISSING
 Maybe some development libraries/packages are missing?
 If you don't want to link with them give
     $WITH_NO
 as options to configure])
-  fi
 fi
 
 ### Use -lgpm if available, unless '--with-gpm=no'.
-- 
2.5.5