From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: GnuTLS/TLS proposals for after the release Date: Wed, 20 Jul 2016 16:21:37 +0200 Message-ID: <0432f4c8-9fb4-828f-89b2-3428a8eecea6@cs.ucla.edu> References: <87furnhj3g.fsf@lifelogs.com> <871t2obge8.fsf@lifelogs.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------7B806D8E9A59D48F1466CC6D" X-Trace: ger.gmane.org 1469024543 12037 80.91.229.3 (20 Jul 2016 14:22:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Jul 2016 14:22:23 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jul 20 16:22:14 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bPsO5-0007Mc-SC for ged-emacs-devel@m.gmane.org; Wed, 20 Jul 2016 16:22:14 +0200 Original-Received: from localhost ([::1]:34891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPsO1-0005QD-Ni for ged-emacs-devel@m.gmane.org; Wed, 20 Jul 2016 10:22:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPsNn-0005M6-NX for emacs-devel@gnu.org; Wed, 20 Jul 2016 10:21:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bPsNk-0008HZ-1H for emacs-devel@gnu.org; Wed, 20 Jul 2016 10:21:55 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:36008) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bPsNj-0008HH-PS for emacs-devel@gnu.org; Wed, 20 Jul 2016 10:21:51 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A817C16116D for ; Wed, 20 Jul 2016 07:21:50 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id c10PvQv1q1ZB for ; Wed, 20 Jul 2016 07:21:49 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 9C57C161173 for ; Wed, 20 Jul 2016 07:21:49 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id pnrbwurBS27y for ; Wed, 20 Jul 2016 07:21:49 -0700 (PDT) Original-Received: from [192.168.1.52] (AMontpellier-656-1-291-239.w90-0.abo.wanadoo.fr [90.0.119.239]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9CCBB16116D for ; Wed, 20 Jul 2016 07:21:48 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 In-Reply-To: <871t2obge8.fsf@lifelogs.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205880 Archived-At: This is a multi-part message in MIME format. --------------7B806D8E9A59D48F1466CC6D Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 07/20/2016 03:14 PM, Ted Zlatanov wrote: > SM> Another step in the same direction is to make ./configure fail if > SM> libgnutls is not found. > > That's a one-line change IIRC, so it just needs the OK from John or Eli > (since it's a pretty major change). It's not that big a deal to treat libgnutls like other key libraries. Namely, 'configure' fails if the library is missing, unless you specifically say you don't want the library by configuring with the --with-gnutls=no option. Something like the attached patch, say. --------------7B806D8E9A59D48F1466CC6D Content-Type: text/x-patch; name="0001-Require-libgnutls-unless-with-gnutls-no.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Require-libgnutls-unless-with-gnutls-no.patch" >From 5f508198cd31afd08c3a50af6c7fb38ed65992cc Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Wed, 20 Jul 2016 16:18:34 +0200 Subject: [PATCH] Require libgnutls unless --with-gnutls=no * configure.ac: Report an error if the gnutls library is missing, unless --with-gnutls=no is specified. --- configure.ac | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/configure.ac b/configure.ac index c94ecb6..cca555c 100644 --- a/configure.ac +++ b/configure.ac @@ -3568,9 +3568,9 @@ AC_DEFUN AC_SUBST(LIBGIF) dnl Check for required libraries. +MISSING= +WITH_NO= if test "${HAVE_X11}" = "yes"; then - MISSING="" - WITH_NO="" test "${with_xpm}" != "no" && test "${HAVE_XPM}" != "yes" && MISSING="libXpm" && WITH_NO="--with-xpm=no" test "${with_jpeg}" != "no" && test "${HAVE_JPEG}" != "yes" && @@ -3581,15 +3581,16 @@ AC_DEFUN MISSING="$MISSING libgif/libungif" && WITH_NO="$WITH_NO --with-gif=no" test "${with_tiff}" != "no" && test "${HAVE_TIFF}" != "yes" && MISSING="$MISSING libtiff" && WITH_NO="$WITH_NO --with-tiff=no" - - if test "X${MISSING}" != X; then - AC_MSG_ERROR([The following required libraries were not found: +fi +test "${with_gnutls}" != "no" && test "${HAVE_GNUTLS}" != "yes" && + MISSING="$MISSING gnutls" && WITH_NO="$WITH_NO --with-gnutls=no" +if test "X${MISSING}" != X; then + AC_MSG_ERROR([The following required libraries were not found: $MISSING Maybe some development libraries/packages are missing? If you don't want to link with them give $WITH_NO as options to configure]) - fi fi ### Use -lgpm if available, unless '--with-gpm=no'. -- 2.5.5 --------------7B806D8E9A59D48F1466CC6D--