* Re: master 701ed2e 2/2: Use lexical binding in fortran.el
[not found] ` <20201022102707.4F7A220BDB@vcs0.savannah.gnu.org>
@ 2020-10-22 15:29 ` Stefan Monnier
2020-10-22 16:35 ` Mattias Engdegård
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2020-10-22 15:29 UTC (permalink / raw)
To: Mattias Engdegård; +Cc: emacs-devel
> Use lexical binding in fortran.el
[...]
> (eval ;I hate `eval', but it's hard to avoid it here.
> - '(syntax-propertize-rules
> + `(syntax-propertize-rules
> ("^[CcDd\\*]" (0 "<"))
> ;; We mark all chars after line-length as "comment-start", rather than
> ;; just the first one. This is so that a closing ' that's past the
> ;; line-length will indeed be ignored (and will result in a string that
> ;; leaks into subsequent lines).
> - ((format "^[^CcDd\\*\t\n].\\{%d\\}\\(.+\\)" (1- line-length))
> + (,(format "^[^CcDd\\*\t\n].\\{%d\\}\\(.+\\)" (1- line-length))
> (1 "<")))))
Hmm... you say "Use lexical binding" yet the above code uses dynamic
binding (since the second arg of `eval` is nil).
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master 701ed2e 2/2: Use lexical binding in fortran.el
2020-10-22 15:29 ` master 701ed2e 2/2: Use lexical binding in fortran.el Stefan Monnier
@ 2020-10-22 16:35 ` Mattias Engdegård
0 siblings, 0 replies; 2+ messages in thread
From: Mattias Engdegård @ 2020-10-22 16:35 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
22 okt. 2020 kl. 17.29 skrev Stefan Monnier <monnier@iro.umontreal.ca>:
> Hmm... you say "Use lexical binding" yet the above code uses dynamic
> binding (since the second arg of `eval` is nil).
Thank you, rectified.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-22 16:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20201022102705.23516.82800@vcs0.savannah.gnu.org>
[not found] ` <20201022102707.4F7A220BDB@vcs0.savannah.gnu.org>
2020-10-22 15:29 ` master 701ed2e 2/2: Use lexical binding in fortran.el Stefan Monnier
2020-10-22 16:35 ` Mattias Engdegård
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).