From: "Ben Key" <Bkey1@tampabay.rr.com>
Cc: <emacs-devel@gnu.org>
Subject: RE: Updated patch for a Windows implementation of play-sound - 2
Date: Sun, 27 Oct 2002 20:13:13 -0500 [thread overview]
Message-ID: <000001c27e1f$315fc0c0$6401a8c0@GODDESS> (raw)
In-Reply-To: <E185wyc-0000pK-00@fencepost.gnu.org>
> What would it mean to "state exactly"? How can you be more explicit
> than our current convention?
With the style of comment that I use, you can do a search for the exact text
within the comment. This makes it much easier to find the each of the
components of the #if statement, the #if, the #else (if present), and the
#endif part. With a comment like "!FOO" or "not FOO" you cannot search for
that exact text and find each respective part of the #if block. This can
make the code much more difficult to read and to understand.
However, I do understand the importance of following programming standards
when programming with a large group. I will update my code and submit a new
patch.
Since my GNU/Linux system is for the most part up and running (I still
cannot connect to it from my other computers because I have failed to set up
Samba, but I can connect to my other computers from it), I will be able to
test the patch on Windows with MinGW and MSVC 6.0 and on GNU/Linux.
prev parent reply other threads:[~2002-10-28 1:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-10-25 5:03 Updated patch for a Windows implementation of play-sound - 2 Ben Key
2002-10-25 14:17 ` Stefan Monnier
2002-10-26 4:47 ` Ben Key
2002-10-26 12:39 ` Kai Großjohann
2002-10-27 23:38 ` Richard Stallman
2002-10-27 23:37 ` Richard Stallman
2002-10-28 1:13 ` Ben Key [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001c27e1f$315fc0c0$6401a8c0@GODDESS' \
--to=bkey1@tampabay.rr.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).