From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Ben Key" Newsgroups: gmane.emacs.devel Subject: RE: Updated patch for a Windows implementation of play-sound - 2 Date: Sun, 27 Oct 2002 20:13:13 -0500 Sender: emacs-devel-admin@gnu.org Message-ID: <000001c27e1f$315fc0c0$6401a8c0@GODDESS> References: Reply-To: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Trace: main.gmane.org 1035767740 25304 80.91.224.249 (28 Oct 2002 01:15:40 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 28 Oct 2002 01:15:40 +0000 (UTC) Cc: Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 185yVH-0006Zz-00 for ; Mon, 28 Oct 2002 02:15:39 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 185yZA-0007io-00 for ; Mon, 28 Oct 2002 02:19:40 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 185yTu-0000nD-00; Sun, 27 Oct 2002 20:14:14 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 185ySs-0000Yc-00 for emacs-devel@gnu.org; Sun, 27 Oct 2002 20:13:10 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 185ySo-0000YF-00 for emacs-devel@gnu.org; Sun, 27 Oct 2002 20:13:10 -0500 Original-Received: from smtp-server1.tampabay.rr.com ([65.32.1.34]) by monty-python.gnu.org with esmtp (Exim 4.10) id 185ySn-0000WV-00; Sun, 27 Oct 2002 20:13:06 -0500 Original-Received: from GODDESS (6535194hfc48.tampabay.rr.com [65.35.194.48]) by smtp-server1.tampabay.rr.com (8.12.2/8.12.2) with SMTP id g9S1D0Ml016295; Sun, 27 Oct 2002 20:13:00 -0500 (EST) Original-To: X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook CWS, Build 9.0.2416 (9.0.2911.0) Importance: Normal In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2600.0000 Errors-To: emacs-devel-admin@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: Xref: main.gmane.org gmane.emacs.devel:8837 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:8837 > What would it mean to "state exactly"? How can you be more explicit > than our current convention? With the style of comment that I use, you can do a search for the exact text within the comment. This makes it much easier to find the each of the components of the #if statement, the #if, the #else (if present), and the #endif part. With a comment like "!FOO" or "not FOO" you cannot search for that exact text and find each respective part of the #if block. This can make the code much more difficult to read and to understand. However, I do understand the importance of following programming standards when programming with a large group. I will update my code and submit a new patch. Since my GNU/Linux system is for the most part up and running (I still cannot connect to it from my other computers because I have failed to set up Samba, but I can connect to my other computers from it), I will be able to test the patch on Windows with MinGW and MSVC 6.0 and on GNU/Linux.