unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 9990@debbugs.gnu.org
Subject: bug#9990: valgrind warning in add_row_entry
Date: Tue, 15 Nov 2011 12:21:56 -0500	[thread overview]
Message-ID: <yxqpqgte1xn.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <83k475fsxp.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Nov 2011 14:04:18 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Dan Nicolaescu <dann@gnu.org>
>> Cc: 9990@debbugs.gnu.org
>> Date: Fri, 11 Nov 2011 15:20:19 -0500
>> 
>> I haven't seen the one in row_equal_p anymore (but that one was not easy
>> to reproduce), the ones in update_window still show up.
>
> I added a function that verifies the hash value of glyph rows before
> it is used in row_equal_p, and also in adjust_glyph_matrix, where the
> offending reallocation takes place.  I cannot trigger the xasserts
> that use this function when I use "C-h H".  Can you?

BTW, why is the hash only using 28 bits instead of the full 32?  Won't
it get a bit more precision if using 32?





  parent reply	other threads:[~2011-11-15 17:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-08 14:27 bug#9990: valgrind warning in add_row_entry Dan Nicolaescu
2011-11-08 17:17 ` Eli Zaretskii
2011-11-08 18:44   ` Andreas Schwab
2011-11-08 20:35     ` Eli Zaretskii
2011-11-11  5:56   ` Dan Nicolaescu
2011-11-11 15:30     ` Eli Zaretskii
2011-11-11 15:59       ` Eli Zaretskii
2011-11-11 20:20         ` Dan Nicolaescu
2011-11-12 12:04           ` Eli Zaretskii
2011-11-15 16:58             ` Dan Nicolaescu
2011-11-15 17:44               ` Eli Zaretskii
2011-11-18 12:44               ` Eli Zaretskii
2011-11-18 19:40                 ` Dan Nicolaescu
2011-11-18 21:08                   ` Eli Zaretskii
2011-11-18 21:43                     ` Dan Nicolaescu
2011-11-19  8:28                       ` Eli Zaretskii
2011-11-20 21:30                         ` Dan Nicolaescu
2011-11-15 17:21             ` Dan Nicolaescu [this message]
2011-11-15 17:49               ` Eli Zaretskii
2011-11-11 20:17       ` Dan Nicolaescu
2020-08-17 22:34 ` Stefan Kangas
2020-10-01  1:55   ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yxqpqgte1xn.fsf@fencepost.gnu.org \
    --to=dann@gnu.org \
    --cc=9990@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).