From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.bugs Subject: bug#9990: valgrind warning in add_row_entry Date: Tue, 15 Nov 2011 12:21:56 -0500 Message-ID: References: <83k47ailf0.fsf@gnu.org> <83zkg2fzgt.fsf@gnu.org> <83vcqqfy5h.fsf@gnu.org> <83k475fsxp.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1321377762 29975 80.91.229.12 (15 Nov 2011 17:22:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 15 Nov 2011 17:22:42 +0000 (UTC) Cc: 9990@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 15 18:22:35 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RQMiO-0005u2-NV for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Nov 2011 18:22:32 +0100 Original-Received: from localhost ([::1]:51523 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQMiO-0000B6-7u for geb-bug-gnu-emacs@m.gmane.org; Tue, 15 Nov 2011 12:22:32 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:37058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQMiI-0000Af-J7 for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2011 12:22:31 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RQMiE-00040e-0L for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2011 12:22:26 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49166) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RQMiD-00040a-PT for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2011 12:22:21 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RQMir-0004Rz-U4 for bug-gnu-emacs@gnu.org; Tue, 15 Nov 2011 12:23:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dan Nicolaescu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Nov 2011 17:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 9990 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 9990-submit@debbugs.gnu.org id=B9990.132137776217022 (code B ref 9990); Tue, 15 Nov 2011 17:23:01 +0000 Original-Received: (at 9990) by debbugs.gnu.org; 15 Nov 2011 17:22:42 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RQMiX-0004QR-2A for submit@debbugs.gnu.org; Tue, 15 Nov 2011 12:22:41 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10] ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RQMiT-0004Q8-Uz for 9990@debbugs.gnu.org; Tue, 15 Nov 2011 12:22:39 -0500 Original-Received: from dann by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1RQMho-0001mf-Pl; Tue, 15 Nov 2011 12:21:56 -0500 In-Reply-To: <83k475fsxp.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 12 Nov 2011 14:04:18 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 15 Nov 2011 12:23:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:53935 Archived-At: Eli Zaretskii writes: >> From: Dan Nicolaescu >> Cc: 9990@debbugs.gnu.org >> Date: Fri, 11 Nov 2011 15:20:19 -0500 >> >> I haven't seen the one in row_equal_p anymore (but that one was not easy >> to reproduce), the ones in update_window still show up. > > I added a function that verifies the hash value of glyph rows before > it is used in row_equal_p, and also in adjust_glyph_matrix, where the > offending reallocation takes place. I cannot trigger the xasserts > that use this function when I use "C-h H". Can you? BTW, why is the hash only using 28 bits instead of the full 32? Won't it get a bit more precision if using 32?