unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dan Nicolaescu <dann@gnu.org>
To: 13387@debbugs.gnu.org
Cc: Paul Eggert <eggert@cs.ucla.edu>
Subject: bug#13387: emacsclient  -t  suspends  emacs
Date: Thu, 10 Jan 2013 02:04:25 -0500	[thread overview]
Message-ID: <yxqk3rltt6u.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <yxq8v83zjnv.fsf@fencepost.gnu.org> (Dan Nicolaescu's message of "Tue, 08 Jan 2013 12:09:08 -0500")

Dan Nicolaescu <dann@gnu.org> writes:

> With the current trunk:
>
> emacs -Q &
> M-x server-start RET
> and  from the same terminal do:
> emacsclient -t
>
> This results in:
> [1]  + Suspended (tty output)        emacs -Q
>
> This is a regression, it works just fine in 24.1

The commit that caused this is 110801.

This hunk looks suspicious:

@@ -1286,11 +1282,7 @@ child_setup (int in, int out, int err, c
   if (err != in && err != out)
     emacs_close (err);

-#if defined HAVE_SETPGID || ! (defined USG && defined SETPGRP_RELEASES_CTTY)
-  setpgid (pid, pid);
-#endif
-
-  /* setpgrp_of_tty is incorrect here; it uses input_fd.  */
+  setpgid (0, 0);
   tcsetpgrp (0, pid);
 
   /* execvp does not accept an environment arg so the only way


it replaces setpgid (pid, pid) with setpgid (0, 0) on GNU/Linux.





  reply	other threads:[~2013-01-10  7:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-08 17:09 bug#13387: emacsclient -t suspends emacs Dan Nicolaescu
2013-01-10  7:04 ` Dan Nicolaescu [this message]
2013-01-10  9:39   ` Andreas Schwab
2013-01-10 13:43     ` Dan Nicolaescu
2013-01-11  2:47       ` Paul Eggert
2013-01-13 20:09         ` Dan Nicolaescu
2013-01-13 20:08     ` Dan Nicolaescu
2013-01-13 20:29       ` Andreas Schwab
2013-01-13 21:03         ` Dan Nicolaescu
2013-01-13 23:08           ` Andreas Schwab
2013-01-13 23:56             ` Dan Nicolaescu
2013-01-14 10:08               ` Andreas Schwab
2013-01-14 18:51                 ` Dan Nicolaescu
2013-01-14 22:43                   ` Andreas Schwab
2013-01-15  4:38                     ` Dan Nicolaescu
2013-01-15  9:12                       ` Andreas Schwab
2013-01-21  3:34                         ` Dan Nicolaescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yxqk3rltt6u.fsf@fencepost.gnu.org \
    --to=dann@gnu.org \
    --cc=13387@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).